public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Zhaolei" <zhaolei@cn.fujitsu.com>
To: "Pavel Machek" <pavel@ucw.cz>,
	"Andrew Morton" <akpm@linux-foundation.org>
Cc: <mingo@elte.hu>, <tglx@linutronix.de>,
	<hirofumi@mail.parknet.co.jp>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Add function to convert between calendar time andbroken-down time for universal use
Date: Mon, 20 Jul 2009 10:56:55 +0800	[thread overview]
Message-ID: <04e101ca08e5$be078fa0$808410ac@zhaoleiwin> (raw)
In-Reply-To: 20090718115019.GH1433@ucw.cz

* From: "Pavel Machek" <pavel@ucw.cz>
>> > +extern void gmtime(__kernel_time_t totalsecs,
>> > +        unsigned int *year, unsigned int *mon, unsigned int *mday,
>> > +        unsigned int *hour, unsigned int *min, unsigned int *sec,
>> > +        unsigned int *wday, unsigned int *yday);
>> > +extern void localtime(__kernel_time_t totalsecs,
>> > +        unsigned int *year, unsigned int *mon, unsigned int *mday,
>> > +        unsigned int *hour, unsigned int *min, unsigned int *sec,
>> > +        unsigned int *wday, unsigned int *yday);
> 
> 
> Should year/mon/.../yday be passed up as a structure?

Hello, Pavel

Thanks for your attention.

Actually, I considered to introduce a struct as your think, but finally I
choose to use arguments list instead of a struct, because:
1: User can easy to call this function without define a struct
2: Get rid of adding a additional struct into kernel

In fact, I think both(use a struct or not) should be ok.

Thanks
Zhaolei
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2009-07-20  2:56 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14  8:03 [PATCH 1/2] Add function to convert between calendar time and broken-down time for universal use Zhaolei
2009-07-14  8:04 ` [PATCH 2/2] fs/fat: Use common localtime/gmtime in fat_time_unix2fat() Zhaolei
2009-07-14 22:10 ` [PATCH 1/2] Add function to convert between calendar time and broken-down time for universal use Andrew Morton
2009-07-15  0:59   ` Zhaolei
2009-07-15  7:23   ` [PATCH v2 0/2] " Zhaolei
2009-07-15  7:24     ` [PATCH v2 1/2] " Zhaolei
2009-07-15  7:25     ` [PATCH v2 2/2] Use common localtime/gmtime in fat_time_unix2fat() Zhaolei
2009-07-18 11:50   ` [PATCH 1/2] Add function to convert between calendar time and broken-down time for universal use Pavel Machek
2009-07-20  2:56     ` Zhaolei [this message]
2009-07-20  3:20       ` [PATCH 1/2] Add function to convert between calendar time andbroken-down " Andrew Morton
2009-07-20  9:55         ` [PATCH v3 0/2] Add function to convert between calendar time and broken-down " Zhaolei
2009-07-20  9:56           ` [PATCH v3 1/2] " Zhaolei
2009-07-25  5:42             ` OGAWA Hirofumi
2009-07-25  8:50               ` OGAWA Hirofumi
2009-07-25 12:15               ` OGAWA Hirofumi
2009-07-27  3:15               ` Zhaolei
2009-07-27  6:04                 ` OGAWA Hirofumi
2009-07-28  3:05                   ` Zhaolei
2009-07-28  5:12                     ` OGAWA Hirofumi
2009-07-30  5:39                       ` [PATCH v4 0/2] " Zhaolei
2009-07-30  5:40                         ` [PATCH v4 1/2] " Zhaolei
2009-07-30  5:41                         ` [PATCH v4 2/2] Use common time_to_tm in fat_time_unix2fat() Zhaolei
2009-07-27 22:44               ` [PATCH v3 1/2] Add function to convert between calendar time and broken-down time for universal use Pavel Machek
2009-07-28  4:52                 ` OGAWA Hirofumi
2009-07-20  9:57           ` [PATCH v3 2/2] Use common localtime/gmtime in fat_time_unix2fat() Zhaolei
2009-07-20 10:03             ` Pavel Machek
2009-07-25  5:43             ` OGAWA Hirofumi
2009-07-27  3:21               ` Zhaolei
2009-07-18 10:02 ` [PATCH 1/2] Add function to convert between calendar time and broken-down time for universal use Ingo Molnar
2009-07-18 12:10   ` H. Peter Anvin
2009-07-18 12:41   ` Ulrich Drepper
2009-07-18 12:26 ` Andi Kleen
2009-07-20  2:41   ` Zhaolei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='04e101ca08e5$be078fa0$808410ac@zhaoleiwin' \
    --to=zhaolei@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pavel@ucw.cz \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox