From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1608C433EF for ; Thu, 24 Feb 2022 18:05:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232530AbiBXSGO (ORCPT ); Thu, 24 Feb 2022 13:06:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbiBXSGM (ORCPT ); Thu, 24 Feb 2022 13:06:12 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C49270252; Thu, 24 Feb 2022 10:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645725942; x=1677261942; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=hxBAdTR0owOoMKt0GpG1ZgSex/03IjMwvi0Jz7GXfd8=; b=EGOnyT8tOl/v9zJVaF1UoHGTHd5I5TdNF0SO4VVeG7Nv6aL52l4z1Mxt rpS5wvqV2FO5z2sRL6Zt8MO1hG3IzbU2upacbE9EyKMWxs5uiYdQ/flN4 lKROVaO9iSNt3LLr7nBpOCriTax2dnCogiYgqq91w5XxsEvbADVKlJuk6 Lw0yB6VrAWknR95AG6JimIt1p9UlqzvdIhNQDqxUrBF/C3s5DIaGETbXu k9ojEFXcIAEO/+cZla5qMqzAXrpLYSW9z/MbLVJUi27V6vNvh+8DdustJ UpnEQE94C2Q0FykwrDCQTc2d2ZCvZ1clzelV5dPSHp7tmCkZfFIUn/OPV g==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="252039190" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="252039190" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 10:05:42 -0800 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="533236249" Received: from ronakmeh-mobl1.amr.corp.intel.com (HELO [10.212.97.131]) ([10.212.97.131]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 10:05:40 -0800 Message-ID: <04e79b9c-ccb1-119a-c2e2-34c8ca336215@linux.intel.com> Date: Thu, 24 Feb 2022 12:05:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM Content-Language: en-US To: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= , Ammar Faizi , Mark Brown Cc: alsa-devel@alsa-project.org, Kai Vehmanen , Rander Wang , linux-kernel@vger.kernel.org, Takashi Iwai , Keyon Jie , stable@vger.kernel.org, Liam Girdwood , Ranjani Sridharan , Daniel Baluta , sound-open-firmware@alsa-project.org References: <20220224145124.15985-1-ammarfaizi2@gnuweeb.org> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> From: Ammar Faizi >> >> Do not call snd_dma_free_pages() when snd_dma_alloc_pages() returns >> -ENOMEM because it leads to a NULL pointer dereference bug. > > Reviewed-by: Peter Ujfalusi Thanks for this patch. looks good and tested by our CI, so Reviewed-by: Pierre-Louis Bossart