From: Marc Zyngier <marc.zyngier@arm.com>
To: Derek Basehore <dbasehore@chromium.org>, linux-kernel@vger.kernel.org
Cc: Soby.Mathew@arm.com, sudeep.holla@arm.com,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux-pm@vger.kernel.org,
rafael.j.wysocki@intel.com, tglx@linutronix.de,
briannorris@chromium.org
Subject: Re: [PATCH v5 1/4] cpu_pm: add syscore_suspend error handling
Date: Wed, 7 Feb 2018 08:57:27 +0000 [thread overview]
Message-ID: <04ebd1d9-b45b-df87-d59e-1a3df97f3371@arm.com> (raw)
In-Reply-To: <20180207014117.62611-2-dbasehore@chromium.org>
On 07/02/18 01:41, Derek Basehore wrote:
> If cpu_cluster_pm_enter() fails, cpu_pm_exit() should be called. This
> will put the CPU in the correct state to resume from the failure.
>
> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> ---
> kernel/cpu_pm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/cpu_pm.c b/kernel/cpu_pm.c
> index 67b02e138a47..03bcc0751a51 100644
> --- a/kernel/cpu_pm.c
> +++ b/kernel/cpu_pm.c
> @@ -186,6 +186,9 @@ static int cpu_pm_suspend(void)
> return ret;
>
> ret = cpu_cluster_pm_enter();
> + if (ret)
> + cpu_pm_exit();
> +
> return ret;
> }
>
>
It is unclear to me why we need this patch as part of the ITS series. I
probably fixes something for you, but I don't see the connection with
the other patches.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-02-07 8:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 1:41 [PATCH v5 0/5] GICv3 Save and Restore Derek Basehore
2018-02-07 1:41 ` [PATCH v5 1/4] cpu_pm: add syscore_suspend error handling Derek Basehore
2018-02-07 8:57 ` Marc Zyngier [this message]
2018-02-07 22:01 ` Brian Norris
2018-02-07 22:10 ` Marc Zyngier
2018-02-07 1:41 ` [PATCH v5 2/4] irqchip/gic-v3-its: add ability to save/restore ITS state Derek Basehore
2018-02-07 9:18 ` Marc Zyngier
2018-02-07 1:41 ` [PATCH v5 3/4] DT/arm,gic-v3-its: add reset-on-suspend property Derek Basehore
2018-02-07 9:21 ` Marc Zyngier
2018-02-08 2:59 ` dbasehore .
2018-02-07 1:41 ` [PATCH v5 4/4] irqchip/gic-v3-its: add ability to resend MAPC on resume Derek Basehore
2018-02-07 8:46 ` Marc Zyngier
2018-02-07 23:22 ` Brian Norris
2018-02-08 0:00 ` dbasehore .
2018-02-08 9:08 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04ebd1d9-b45b-df87-d59e-1a3df97f3371@arm.com \
--to=marc.zyngier@arm.com \
--cc=Soby.Mathew@arm.com \
--cc=briannorris@chromium.org \
--cc=dbasehore@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox