From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD47C2D0C3 for ; Tue, 17 Dec 2019 01:19:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A00A7205ED for ; Tue, 17 Dec 2019 01:19:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726530AbfLQBTz (ORCPT ); Mon, 16 Dec 2019 20:19:55 -0500 Received: from mga07.intel.com ([134.134.136.100]:23805 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbfLQBTy (ORCPT ); Mon, 16 Dec 2019 20:19:54 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 17:19:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,323,1571727600"; d="scan'208";a="247255807" Received: from chauvina-mobl1.ger.corp.intel.com ([10.251.85.48]) by fmsmga002.fm.intel.com with ESMTP; 16 Dec 2019 17:19:49 -0800 Message-ID: <04ff0dc94f25272726bbdf77867b28cf667023d9.camel@linux.intel.com> Subject: Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init From: Jarkko Sakkinen To: Jerry Snitselaar , linux-kernel@vger.kernel.org Cc: Christian Bundy , Dan Williams , Peter Huewe , Jason Gunthorpe , Stefan Berger , stable@vger.kernel.org, linux-integrity@vger.kernel.org In-Reply-To: <5aef0fbe28ed23b963c53d61445b0bac6f108642.camel@linux.intel.com> References: <20191211231758.22263-1-jsnitsel@redhat.com> <20191211235455.24424-1-jsnitsel@redhat.com> <5aef0fbe28ed23b963c53d61445b0bac6f108642.camel@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Tue, 17 Dec 2019 03:19:44 +0200 User-Agent: Evolution 3.34.1-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-12-17 at 02:58 +0200, Jarkko Sakkinen wrote: > On Wed, 2019-12-11 at 16:54 -0700, Jerry Snitselaar wrote: > > Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when > > issuing commands to the tpm during initialization, just reserve the > > chip after wait_startup, and release it when we are ready to call > > tpm_chip_register. > > > > Cc: Christian Bundy > > Cc: Dan Williams > > Cc: Peter Huewe > > Cc: Jarkko Sakkinen > > Cc: Jason Gunthorpe > > Cc: Stefan Berger > > Cc: stable@vger.kernel.org > > Cc: linux-integrity@vger.kernel.org > > Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") > > Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's") > > Signed-off-by: Jerry Snitselaar > > I pushed to my master with minor tweaks and added my tags. > > Please check before I put it to linux-next. Oops. Forgot to push please check now git://git.infradead.org/users/jjs/linux-tpmdd.git master /Jarkko