Re: [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set

Jacek Kowalski
2025-04-24T16:46:48Z

>> Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM
>> checksum")
>
> I think that while the commit cited above relates to this problem,
> this bug actually dates back to the patch I'm citing immediately
> below. And I think we should cite that commit here. IOW, I'm
> suggesting:
>
> Fixes: fb776f5d57ee ("e1000e: Add support for Tiger Lake")

I had my doubts when choosing a commit for the "Fixes" tag, but since
my setup would most likely work up until 4051f68318ca9, I selected it
specifically.

On my laptop NVM write attempt does (temporarily) fix a checksum
and makes driver loading possible. Only after 4051f68318ca9, which
disabled this code path (because it broke someone else's setup), I'd
be unable to use my network adapter anymore.

--
Best regards,
Jacek Kowalski