Re: [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set

Simon Horman
2025-04-24T16:24:49Z

On Tue, Apr 22, 2025 at 09:43:01AM +0200, Jacek Kowalski wrote:
> Some Dell Tiger Lake systems have incorrect NVM checksum. These also
> have a bitmask that indicates correct checksum set to "invalid".
>
> Because it is impossible to determine whether the NVM write would finish
> correctly or hang (see https://bugzilla.kernel.org/show_bug.cgi?id=213667)
> it makes sense to skip the validation completely under these conditions.
>
> Signed-off-by: Jacek Kowalski <Jacek@jacekk.info>
> Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM checksum")

I think that while the commit cited above relates to this problem,
this bug actually dates back to the patch I'm citing immediately below.
And I think we should cite that commit here. IOW, I'm suggesting:

Fixes: fb776f5d57ee ("e1000e: Add support for Tiger Lake")

> Cc: stable@vger.kernel.org

That not withstanding, based on the commit message,
and the use of e1000_pch_tgp in another Tiger Lake fix [1],
I think this patch looks good.

Reviewed-by: Simon Horman <horms@kernel.org>

[1] commit ffd24fa2fcc7 ("e1000e: Correct NVM checksum verification flow")