From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Tobias Schramm <t.schramm@manjaro.org>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] leds: add generic inverted led trigger support
Date: Sun, 8 Mar 2020 18:35:02 +0100 [thread overview]
Message-ID: <057e4efd-30a1-20df-d990-d11ef2573a3e@gmail.com> (raw)
In-Reply-To: <20200308142722.1199260-2-t.schramm@manjaro.org>
Hi Tobias,
We have already some triggers that accomplish that by introducing
a custom sysfs file. It seems less intrusive to do the same for
ledtrig-disk.c. You could also try to make this a generic feature
for all LED triggers.
On 3/8/20 3:27 PM, Tobias Schramm wrote:
> This commit allows inversion of triggers by appending "-inverted" to the
> name of a trigger.
>
> This can be useful when dealing with device that lack separate LEDs for
> indicating e.g. disk activity. With this commit applied the power LED
> can be used as a disk activity indicator by setting its default state to
> on and using the "disk-activity-inverted" trigger. The LED will then turn
> off briefly when there is disk activity.
>
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-03-08 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 14:27 [RFC PATCH 0/1] Add generic inverted led triggers Tobias Schramm
2020-03-08 14:27 ` [RFC PATCH 1/1] leds: add generic inverted led trigger support Tobias Schramm
2020-03-08 17:35 ` Jacek Anaszewski [this message]
2020-03-09 13:46 ` Tobias Schramm
2020-03-08 21:26 ` [RFC PATCH 0/1] Add generic inverted led triggers Pavel Machek
2020-03-09 14:05 ` Tobias Schramm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=057e4efd-30a1-20df-d990-d11ef2573a3e@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox