Re: [PATCH] dt-bindings: arm: socfpga: Add Altera SOCFPGA SDRAM EDAS

Krzysztof Kozlowski
2024-08-01T08:46:18Z

On 01/08/2024 10:44, Krzysztof Kozlowski wrote:
> On 01/08/2024 01:02, Alessandro Zanni wrote:
>
> Thank you for your patch. There is something to discuss/improve.
>
>
>> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml
>> new file mode 100644
>> index 000000000000..78fbe31e4a2b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml
>
> Filename like compatible, so altr,sdram-edac.yaml
>
> Fix the placement - arm is only for top-level sutff. This goes to
> memory-controllers or edac
>

So this was a v2? Then version your patches correctly and add
appropriate and detailed changelog under ---.

See submitting patches.

Best regards,
Krzysztof