From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD4AB3B4EA4
	for <linux-kernel@vger.kernel.org>; Wed, 13 May 2026 22:58:56 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778713136; cv=none; b=mur5wHk8NjsR5tJS8mLVvLbMYh4an9s0oJwD87752qpnSMQ5bWzEYtRwDt/tUcwCUHx8WPNzaLGjCfndosAte9WeOU1F+mBtB8fBq/WYQQv95OOCckhvu+Q+HJTHzdG7B4yzwqaeW00t7gp90RNOB9vCoVP7BHybqmzcsfYaZhU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778713136; c=relaxed/simple;
	bh=2WTmkC68e9++sLwAfu2OeUF95dYZL1zeLYcchbQyNdU=;
	h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:
	 MIME-Version:Content-Type; b=Bm6dURjsZOuKvC6CDeRQ1P+hkKrNuKNiNKiwnnE6Cw32rMdjJmi8rUNmQ4SN7Or8hmKA3BGeVraU/gC0FDKYQf8BGUVAkT1dnhMg5SZuxpj7mvT4792hi+jv99nkGI2cGdqoWmUTnj6VaxRjTdIQpwrC/vwkRYZUEmZ5f1JXIEE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AD87Xc44; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AD87Xc44"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA69FC19425;
	Wed, 13 May 2026 22:58:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1778713136;
	bh=2WTmkC68e9++sLwAfu2OeUF95dYZL1zeLYcchbQyNdU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=AD87Xc44ykaO/I7Q760mBQSZKJUCuvBmGzlDSEy17rzOon9mvkshOSFJw+Zva6bIx
	 3LndLIuEf0uI/WN9KTjy6L9sKiwUyn85u5y7cjSQosm38ttDasCEAynS4xI7SZxIu7
	 CEPo1qJLg/WpRJPeZr0cAKGKt0gDLfoQz3LdpQ0Kn4MVOjHmFrMSPEwHUQWtk4pc4j
	 pZiZ3nIA42fjCEgaMeNd3CaVw6oTd7V+AvuraHLhkqzhsuiHoXeR6Kemz2v/KplG1c
	 CPOpFsjW7hK4487FE06Pzn95sP9Gvrj0dqh48vyeI+sJtelWu6v7hIl1wTzj8aENkU
	 OUpQcvSQFUCfg==
Date: Wed, 13 May 2026 16:58:55 -0600 (MDT)
From: Paul Walmsley <pjw@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
cc: Paul Walmsley <pjw@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, 
    Albert Ou <aou@eecs.berkeley.edu>, Alexandre Ghiti <alex@ghiti.fr>, 
    =?ISO-8859-15?Q?Bj=F6rn_T=F6pel?= <bjorn@rivosinc.com>, 
    Conor Dooley <conor.dooley@microchip.com>, 
    Yu-Chun Lin <eleanor.lin@realtek.com>, 
    Kuan-Wei Chiu <visitorckw@gmail.com>, Han Gao <rabenda.cn@gmail.com>, 
    Nam Cao <namcao@linutronix.de>, Pu Lehui <pulehui@huawei.com>, 
    Klara Modin <klarasmodin@gmail.com>, Ben Dooks <ben.dooks@codethink.co.uk>, 
    Alexandre Ghiti <alexghiti@rivosinc.com>, linux-riscv@lists.infradead.org, 
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] riscv: propagate insert_resource result from
 add_resource
In-Reply-To: <20260512172034.328405-4-thorsten.blum@linux.dev>
Message-ID: <05988bfc-6de7-1011-6535-a80c7a710282@kernel.org>
References: <20260512172034.328405-4-thorsten.blum@linux.dev>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 12 May 2026, Thorsten Blum wrote:

> Currently, add_resource() returns 1 on success, even though its callers
> only check for negative values. Instead, propagate the insert_resource()
> result from add_resource() to align with standard kernel return-value
> conventions (0 on success, negative errno on failure).
> 
> Use %pR to print the full resource range while at it.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Thanks, queued for v7.2.


- Paul