RE: [PATCH 15/17] arm64: dts: exynos7885: add specific compatibles to several blocks

Alim Akhtar
2023-11-11T01:44:14Z

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, November 8, 2023 4:14 PM
> Exynos7885 reuses several devices from older designs, thus historically we
> kept the old (block's) compatible only. This works fine and there is no bug
> here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to Exynos7885 in front of all old-SoC-like
> compatibles. This will also help reviews of new code using existing DTS as
> template. No functional impact on Linux drivers behavior.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> arch/arm64/boot/dts/exynos/exynos7885.dtsi | 45 ++++++++++++++--------
> 1 file changed, 30 insertions(+), 15 deletions(-)
>
(...)