RE: [PATCH 00/17] dt-bindings: samsung: add specific compatibles for existing SoC

Alim Akhtar
2023-11-08T17:17:55Z

Hi Krzysztof

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, November 8, 2023 4:13 PM
> To: David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>;
> Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard
> <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>;
> Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Alim Akhtar <alim.akhtar@samsung.com>; Andi
> Shyti <andi.shyti@kernel.org>; Jonathan Cameron <jic23@kernel.org>; Lars-
> Peter Clausen <lars@metafoo.de>; Lee Jones <lee@kernel.org>; Ulf
> Hansson <ulf.hansson@linaro.org>; Tomasz Figa <tomasz.figa@gmail.com>;
> Sylwester Nawrocki <s.nawrocki@samsung.com>; Linus Walleij
> <linus.walleij@linaro.org>; Thierry Reding <thierry.reding@gmail.com>; Uwe
> Kleine-König <u.kleine-koenig@pengutronix.de>; Alessandro Zummo
> <a.zummo@towertech.it>; Alexandre Belloni
> <alexandre.belloni@bootlin.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Jiri Slaby <jirislaby@kernel.org>; Liam
> Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>;
> Jaehoon Chung <jh80.chung@samsung.com>; Sam Protsenko
> <semen.protsenko@linaro.org>; dri-devel@lists.freedesktop.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> i2c@vger.kernel.org; linux-iio@vger.kernel.org; linux-mmc@vger.kernel.org;
> linux-gpio@vger.kernel.org; linux-pwm@vger.kernel.org; linux-
> rtc@vger.kernel.org; linux-serial@vger.kernel.org; alsa-devel@alsa-
> project.org; linux-sound@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 00/17] dt-bindings: samsung: add specific compatibles for
> existing SoC
>
> Hi,
>
> Merging
> =======
> I propose to take entire patchset through my tree (Samsung SoC), because:
> 1. Next cycle two new SoCs will be coming (Google GS101 and
> ExynosAutov920), so
> they will touch the same lines in some of the DT bindings (not all, though).
> It is reasonable for me to take the bindings for the new SoCs, to have clean
> `make dtbs_check` on the new DTS.
> 2. Having it together helps me to have clean `make dtbs_check` within my
> tree
> on the existing DTS.
> 3. No drivers are affected by this change.
> 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect
> follow up patchsets.
>
Sure, make sense.

> If folks agree, please kindly Ack the patches.
>
> Description
> ===========
> Samsung Exynos SoCs reuse several devices from older designs, thus
> historically we kept the old (block's) compatible only. This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
> This will also help reviews of new code using existing DTS as template. No
> functional impact on Linux drivers behavior.
>
> Future
> ======
> If reasonable, I will do similar work for Tesla FSD and ARMv7/ARM32 Exynos
> bindings and DTS.
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (17):
> dt-bindings: hwinfo: samsung,exynos-chipid: add specific compatibles
> for existing SoC
> dt-bindings: i2c: exynos5: add specific compatibles for existing SoC
> dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for
> existing SoC
> dt-bindings: mmc: samsung,exynos-dw-mshc: add specific compatibles for
> existing SoC
> dt-bindings: pinctrl: samsung: add specific compatibles for existing
> SoC
> dt-bindings: rtc: s3c-rtc: add specific compatibles for existing SoC
> dt-bindings: serial: samsung: add specific compatibles for existing
> SoC
> dt-bindings: samsung: exynos-pmu: add specific compatibles for
> existing SoC
> dt-bindings: gpu: arm,mali-midgard: add specific compatibles for
> existing Exynos SoC
> dt-bindings: iio: samsung,exynos-adc: add specific compatibles for
> existing SoC
> ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing
> SoC
> dt-bindings: pwm: samsung: add specific compatibles for existing SoC
> arm64: dts: exynos5433: add specific compatibles to several blocks
> arm64: dts: exynos7: add specific compatibles to several blocks
> arm64: dts: exynos7885: add specific compatibles to several blocks
> arm64: dts: exynos850: add specific compatibles to several blocks
> arm64: dts: exynosautov9: add specific compatibles to several blocks
>
> .../bindings/gpu/arm,mali-midgard.yaml | 5 ++
> .../hwinfo/samsung,exynos-chipid.yaml | 17 +++++-
> .../devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++-
> .../bindings/i2c/samsung,s3c2410-i2c.yaml | 22 ++++---
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++----
> .../mfd/samsung,exynos5433-lpass.yaml | 2 +-
> .../bindings/mmc/samsung,exynos-dw-mshc.yaml | 25 +++++---
> .../samsung,pinctrl-wakeup-interrupt.yaml | 24 +++++---
> .../bindings/pinctrl/samsung,pinctrl.yaml | 3 +-
> .../devicetree/bindings/pwm/pwm-samsung.yaml | 2 +
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 5 ++
> .../bindings/serial/samsung_uart.yaml | 14 ++++-
> .../bindings/soc/samsung/exynos-pmu.yaml | 6 ++
> .../bindings/soc/samsung/exynos-usi.yaml | 2 +-
> .../bindings/sound/samsung-i2s.yaml | 19 +++---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 60 ++++++++++++-------
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 18 +++---
> arch/arm64/boot/dts/exynos/exynos7885.dtsi | 45 +++++++++-----
> arch/arm64/boot/dts/exynos/exynos850.dtsi | 34 ++++++-----
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 6 +-
> 20 files changed, 233 insertions(+), 115 deletions(-)
>
> --
> 2.34.1