The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Kanak Shilledar <Kanak.Shilledar@axis.com>
To: "dlechner@baylibre.com" <dlechner@baylibre.com>,
	"nuno.sa@analog.com" <nuno.sa@analog.com>,
	"Jean-Baptiste.Maneyrol@tdk.com" <Jean-Baptiste.Maneyrol@tdk.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"andy@kernel.org" <andy@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	Henrik Grimler <Henrik.Grimler@axis.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Kernel <Kernel@axis.com>
Subject: Re: [PATCH v2 0/3] Add driver for Invensense ICM42370P accelerometer
Date: Mon, 24 Aug 2026 09:38:25 +0000	[thread overview]
Message-ID: <05bd4082e24ab94e43cb86d4981e0b9f63ac0036.camel@axis.com> (raw)
In-Reply-To: <BE1P281MB1426653200EC50B0266FE345CEA42@BE1P281MB1426.DEUP281.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 1929 bytes --]

Hi Jean-Baptiste,

On Thu, 2026-08-20 at 15:19 +0000, Jean-Baptiste Maneyrol wrote:
> > 
> > ________________________________________
> > From: Kanak Shilledar <kanak.shilledar@axis.com>
> > Sent: Thursday, August 13, 2026 14:26
> > To: Jonathan Cameron; David Lechner; Nuno Sá; Andy Shevchenko; Rob
> > Herring; Krzysztof Kozlowski; Conor Dooley; Henrik Grimler; Jean-
> > Baptiste Maneyrol
> > Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@axis.com; Kanak Shilledar
> > Subject: [PATCH v2 0/3] Add driver for Invensense ICM42370P
> > accelerometer
> > 
> > Invensense ICM42370P is a high performance MEMS MotionTracking 3-
> > axis accelerometer. It supports I2C, I3C and SPI protocols. It has
> > a 2. 25kB FIFO and two programmable interrupts with support for
> 
> Hello Kanak,
> 
> ICM-42370-P is completely similar to ICM-42607, except that it is
> accelerometer
> only. There is no need to write a completely new driver, you can add
> support
> of ICM-42370-P inside the existing inv_icm42607 driver.
> 
> inv_icm42607 driver is lacking a lot of functionalities, like buffer
> support.
> It explains why there is no support for MREG registers.
> 
> I recommend you add first basic support of ICM-42370-P inside
> existing inv_icm42607
> driver, and then add new functionalities like buffer support in this
> driver.
> There is really no need to write a new driver here. For MREG
> registers support, you
> can have a look inside inv_icm45600 that is using the same mechanism.
> 
> Thanks,
> JB

Thanks for going through the code. I didn't notice the ICM42607 in the
mailing list. I will add support for ICM42370 to that driver instead of
creating a new driver. I will have a patchset for basic support and
then incremental patches for implementing more features (like buffer).

Thanks and Regards,
Kanak Shilledar


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2026-08-24  9:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 12:26 [PATCH v2 0/3] Add driver for Invensense ICM42370P accelerometer Kanak Shilledar
2026-08-13 12:26 ` [PATCH v2 1/3] dt-bindings: Add InvenSense ICM-42370-p accelerometer Kanak Shilledar
2026-08-18  7:56   ` Krzysztof Kozlowski
2026-08-13 12:26 ` [PATCH v2 2/3] iio: accel: Add support for ICM42370P Kanak Shilledar
2026-08-16  2:59   ` Jonathan Cameron
2026-08-24  9:33     ` Kanak Shilledar
2026-08-13 12:26 ` [PATCH v2 3/3] iio: accel: icm42370: Add FIFO buffer functionality Kanak Shilledar
2026-08-16  3:12   ` Jonathan Cameron
2026-08-17  9:48   ` Joshua Crofts
2026-08-17  7:19 ` [PATCH v2 0/3] Add driver for Invensense ICM42370P accelerometer Andy Shevchenko
2026-08-20 14:02   ` Kanak Shilledar
2026-08-20 15:19 ` Jean-Baptiste Maneyrol
2026-08-24  9:38   ` Kanak Shilledar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05bd4082e24ab94e43cb86d4981e0b9f63ac0036.camel@axis.com \
    --to=kanak.shilledar@axis.com \
    --cc=Henrik.Grimler@axis.com \
    --cc=Jean-Baptiste.Maneyrol@tdk.com \
    --cc=Kernel@axis.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox