From: Paulo Alcantara <pc@manguebit.com>
To: Anastasia Belova <abelova@astralinux.ru>,
Steve French <sfrench@samba.org>
Cc: Anastasia Belova <abelova@astralinux.ru>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Jeff Layton <jlayton@kernel.org>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org,
Ekaterina Esina <eesina@astralinux.ru>
Subject: Re: [PATCH] cifs: spnego: add ';' in HOST_KEY_LEN
Date: Mon, 13 Nov 2023 15:11:37 -0300 [thread overview]
Message-ID: <05bfafca49fbed96ea500c25a0606205.pc@manguebit.com> (raw)
In-Reply-To: <20231113145232.12448-1-abelova@astralinux.ru>
Anastasia Belova <abelova@astralinux.ru> writes:
> "host=" should start with ';' (as in cifs_get_spnego_key)
> So its length should be 6.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 7c9c3760b3a5 ("[CIFS] add constants for string lengths of keynames in SPNEGO upcall string")
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> Co-developed-by: Ekaterina Esina <eesina@astralinux.ru>
> Signed-off-by: Ekaterina Esina <eesina@astralinux.ru>
> ---
> fs/smb/client/cifs_spnego.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
next prev parent reply other threads:[~2023-11-13 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 14:52 [PATCH] cifs: spnego: add ';' in HOST_KEY_LEN Anastasia Belova
2023-11-13 18:11 ` Paulo Alcantara [this message]
2023-11-13 22:23 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05bfafca49fbed96ea500c25a0606205.pc@manguebit.com \
--to=pc@manguebit.com \
--cc=abelova@astralinux.ru \
--cc=eesina@astralinux.ru \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=lvc-project@linuxtesting.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox