From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gary Yang <gary.yang@cixtech.com>,
linus.walleij@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com
Subject: Re: [PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1
Date: Wed, 27 Aug 2025 10:23:21 +0200 [thread overview]
Message-ID: <05c468dd-526d-4367-8e24-98647d5232fd@kernel.org> (raw)
In-Reply-To: <20250827024222.588082-4-gary.yang@cixtech.com>
On 27/08/2025 04:42, Gary Yang wrote:
> };
> };
> +
> + iomuxc: pinctrl@4170000 {
> + compatible = "cix,sky1-iomuxc";
> + reg = <0x0 0x04170000 0x0 0x1000>;
> + };
> +
> + iomuxc_s5: pinctrl@16007000 {
Are you sure you follow DTS coding style for ordering of nodes? Looks
like you just keep adding things to the end...
> + compatible = "cix,sky1-iomuxc-s5";
> + reg = <0x0 0x16007000 0x0 0x1000>;
> + };
> };
>
> timer {
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-27 8:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 2:42 [PATCH 0/3] Add pinctrl support for Sky1 Gary Yang
2025-08-27 2:42 ` [PATCH 1/3] pinctrl: cix: Add pin-controller support for sky1 Gary Yang
2025-08-27 9:07 ` Krzysztof Kozlowski
2025-08-28 6:44 ` 回复: " Gary Yang
2025-08-28 6:49 ` Krzysztof Kozlowski
2025-08-28 8:32 ` 回复: " Gary Yang
2025-08-28 18:00 ` Krzysztof Kozlowski
2025-08-29 4:33 ` 回复: " Gary Yang
2025-08-29 6:21 ` Krzysztof Kozlowski
2025-08-29 10:18 ` 回复: " Gary Yang
2025-08-29 10:35 ` Krzysztof Kozlowski
2025-08-28 17:51 ` Linus Walleij
2025-08-28 18:02 ` Krzysztof Kozlowski
2025-08-28 21:03 ` Linus Walleij
2025-08-27 2:42 ` [PATCH 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl Gary Yang
2025-08-27 8:22 ` Krzysztof Kozlowski
2025-08-28 5:37 ` 回复: " Gary Yang
2025-08-28 6:52 ` Krzysztof Kozlowski
2025-08-28 8:58 ` 回复: " Gary Yang
2025-08-28 18:04 ` Krzysztof Kozlowski
2025-08-28 18:19 ` Linus Walleij
2025-08-30 13:20 ` Gary Yang
2025-09-01 12:55 ` Linus Walleij
2025-09-02 2:08 ` 回复: " Gary Yang
2025-08-28 7:25 ` Krzysztof Kozlowski
2025-08-28 18:27 ` Linus Walleij
2025-08-27 2:42 ` [PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1 Gary Yang
2025-08-27 8:23 ` Krzysztof Kozlowski [this message]
2025-08-28 6:14 ` 回复: " Gary Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c468dd-526d-4367-8e24-98647d5232fd@kernel.org \
--to=krzk@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gary.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).