RE: [PATCH 2/3] dmaengine: pl330: Add DMAADDH instruction

Pankaj Dubey
2025-02-10T07:53:21Z

> From: Aatif Mushtaq <aatif4.m@samsung.com>
> Sent: Monday, February 10, 2025 11:49 AM
> To: vkoul@kernel.org; dmaengine@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: pankaj.dubey@samsung.com; aswani.reddy@samsung.com; Aatif Mushtaq
> <aatif4.m@samsung.com>
> Subject: [PATCH 2/3] dmaengine: pl330: Add DMAADDH instruction
>
> Add support for emitting DMAADDH instruction.
> Add halfword instruction adds an immediate 16-bit value to the source
> address register or destination address register for the DMA channel
> thread. This enables the DMAC to support 2D DMA operations.
>
> Signed-off-by: Aatif Mushtaq <aatif4.m@samsung.com>
> ---

Looks good to me.
Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>