From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D46E630E834 for ; Mon, 4 May 2026 20:48:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777927702; cv=none; b=amKvXGP14m0sPZ9ePXvvJD0kmFtkE0Em1RO2pV6X8LS3U1/SanPpGrOjEQEMzoiiJ/zDFZTAke1Pjhe7kLx7/crCGvuLNUkfVxCAgoqkEhf7OidU2IROoLhX/GH6+0426kQTQfLaml7/cC9vd+R4IiaqdgrFQ4VgxoYftV3Qb+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777927702; c=relaxed/simple; bh=lHRbQRvhCefu2MS7D67kLrFGL6wNRu/ft9VmKJYEsRg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Th0ncY1TXmjofVbc4jPArdQly0dz31a23JMImSwqtEU9j/bxnUegEk5DOFMNP/Tlr0UNLkXopTazI88KMP0ArLL/CKaVJVEKp5gra+zi+HSzWEE8Z/cPWG0IU+4EG/nodfJMsB/Q4USeKbmF7xNd9Ekewjrc5epwSgxJN9sjhZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LW7YusUO; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LW7YusUO" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-444826c16ffso4368336f8f.1 for ; Mon, 04 May 2026 13:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777927698; x=1778532498; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jF8Q6RoPGmOljbJrevjIunF771/iJgvq5ngDUmVs95E=; b=LW7YusUOcrdFOeB1dfN2yI679/4Oz2ya60WlDz3z3axJrQ1llIgcf6HbBlZTfE7Q83 AUEGaOuYQLtf+GzbulfPRyunCLxnKF2Xbt51xtKNHJsuCAzcuJ5ZuZGTlT2XSj5bMIvp IsOQPPGBgKz+qxD0eI2aSYj082dUL93qx52ixpgLL8HI8DVOrf24pk0VoCxjQN08XVKq jj6rwJmroSiDEakwSwOT5aeO35f+L3q7ZEub6zlzXuatFq+UTTXgH24KVXTNz1kcLNr0 kE8EPLaiWkvPDWEQ+AaaiLzs8ZbwOtopLn11ytCw7+Dci7EUklIm79THY1Satn93B/m/ kSLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777927698; x=1778532498; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jF8Q6RoPGmOljbJrevjIunF771/iJgvq5ngDUmVs95E=; b=IssE7HFCYMbO4iT6b4wDUgd3lDs1rDJ9OuA+Q/m48S1VBsUEe+C/J68LFsdTQh0BrN CX+OQYDNrm6KNuhgPqDksmGHp6GwlmmmkF0jPXkAI4FmEqUgNWKsEeSpDW4vNG3gj+kp 1UGZ9pG/0HLiJ9BcIuDIzDuQPOT24oKS8L7aKvMj9nG1D6YlBMEKgdiUOJf13Lghkrdy 1uNYP0WeZ2TQ/n1Ji1ZJPNBHbV6ZmoL63ArXRWVFc3JvOFJvAMhRz+W2KXIEkJailZfR 3kVlU7W9owseKGi97O1LDe7RMPBeViMGqHj+BPJWelQts2EDKJZep5qxPOO6hDu8qmxo i8vw== X-Forwarded-Encrypted: i=1; AFNElJ+4+N85389P7uyBURejsZOcX7r+4/0TpuLda0QB0klVpqTUmEJ7UAxPBiHzJbD9jVBPAu0YP89hYHESjpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxlU6mzfdu2tVhBd/kJ6UC559zBvSNVrjsDBDvB6l+S0XfnlyuJ U8iQgaQ2p1XIvISxPjlE54EH7b7r9WRDwPxOIjyqy9rCV+5/kkVFNNt1 X-Gm-Gg: AeBDiesSkyZsr7ge7hc7vgpR5zF0/EK5aw9kqKdlnShpQ/UV7lezooKZODaGlPKYP+W X+YdoeJW3tUcUwtDtsYRAQsd0/k4Kq0NJ/NeawmjdYf8/iwakWcorPZWLJxl2jlBEdHRBHvOVTa L//PEn7GovLe730QMKDbJ+FSoGAF0Agbvzw2AiiZ7ZAhm2TBFc18athFINlu9G/cHLxOnVvGE19 SjH3rGdHMPyVUb1AQ/u6zhxaeB5ppy+CZmCi84Kk+kXHVk5yaMEFEvC/3aBHh+JL1zg8Asqsb94 Dz1GmyDWVNa71GtbQjk6CtH+WnV3wLKml7hWpTZWOftDg9bXUz3cZqSKPxLbexHhv9qznA4AZja 6KxUmQ7JrlYY3tEqQbJ9UbFDnmqYq/OcRSM+/MyKEFLlBa7/JbapZrK5YFCZyiJi4a2QdZ+LXTM yDG6bqwSZen/daPgsIU7EY3yiY/difyx1Q2x5PSEl66cb5UFXQobk2zUayy7qlCNOvcnOAJbxcB x5qC7ghxpaQLm9dQH5U X-Received: by 2002:a05:6000:2586:b0:43d:7b7b:ab76 with SMTP id ffacd0b85a97d-45003fc719dmr750576f8f.10.1777927698004; Mon, 04 May 2026 13:48:18 -0700 (PDT) Received: from ?IPV6:2001:861:3385:e20:f99c:d6cf:27e6:2b03? ([2001:861:3385:e20:f99c:d6cf:27e6:2b03]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4502865baddsm38791f8f.3.2026.05.04.13.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 13:48:17 -0700 (PDT) Message-ID: <05dd01f4-186b-4358-b90c-36dde16036c7@gmail.com> Date: Mon, 4 May 2026 22:47:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] drm/exynos: remove bridge when component_add fails To: Osama Abdelkader , luca.ceresoli@bootlin.com, Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , Andrzej Hajda , Hoegeun Kwon , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20260423200622.325076-1-osama.abdelkader@gmail.com> <20260423200622.325076-2-osama.abdelkader@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Rapha=C3=ABl_Gallais-Pou?= In-Reply-To: <20260423200622.325076-2-osama.abdelkader@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/23/26 22:06, Osama Abdelkader wrote: > Use devm_drm_bridge_add() so the bridge is released if probe fails after > registration, and drop the manual drm_bridge_remove() in remove(). > > Check the return value of devm_drm_bridge_add(). > > Signed-off-by: Osama Abdelkader > Fixes: 576d72fbfb45 ("drm/exynos: mic: add a bridge at probe") > Cc: stable@vger.kernel.org > --- > v3: add Fixes and Cc tags > v2: devm_drm_bridge_add instead of drm_bridge_add + goto remove_bridge > --- Hi, Reviewed-by: Raphaël Gallais-Pou Best regards, Raphaël