From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF4F12D7DC8 for ; Wed, 29 Apr 2026 14:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777471206; cv=none; b=ouDJn7gNRpsdKxWJ1QSvZ8nS3RcbvusuZtvv61xcnNsH8+bLcLB03KqK/qrB1+SIFYeE4XoUxSQUmZIRSJbwt7vBsB4mCQtz8brwY63+GtNOSD2OkJbUANXZLgIbXLCT3vOWMt1/i+ynD0Y8OKMzKTb4p3drw+QSLtmwY3xmeUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777471206; c=relaxed/simple; bh=uybU3a3N0n0+jby1CmvCwk1L1SefcxFqIYnY1BYddAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ddJ7JnkT4EKJZwGMSZSj6A/38OKkgIu6+YtsftP/EceSiV4Sg9PgsFPfezH0Fi+Vx0PrbyTgweaZnVzCjUsKCrBJsngOQ8Y+XHgG1VZ8XOaKad1Cj8bENlhJNwnb0zgPoY3yceisj6hJCin1VV3hqLNCpR+L1ewGgX/4x0TwDP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gLXqekvm; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gLXqekvm" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488b0046078so113925325e9.1 for ; Wed, 29 Apr 2026 07:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777471203; x=1778076003; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pXYxfb1OnKvjy9v+vQDtCcuNHO3JiDi1MdrPDxdzPQ4=; b=gLXqekvmXRhzuQCRX5EzzoB2mkngNLXk6DATaC6PiEfzxbcIlCGmAPYgLnSIuWlbs0 y93n7fM5eUCAOfpgSI7hKDI5dpPgy7N1jZE5x85ouYdj1bSoG0q6Cc+QQv4zJ0r6Msud 8Kanm0feySuOE9Xu65FT3Iqr1EFzPCR+Z/+UBVnrswloKlyLLrs/amsgHl3k6lnM6/RG yQllTxMXS7QJx/wWrMcbo4wDk0mX5K4vgDMlht9WFHJEwbsKGOj4O8EYl9QV4PFVjGdZ g2DwlN2vxX814tJtzmbzNWopvdJMQUNJ66uZ/A7dms45v6ZXLPGDXtjq8hg5qZQwrqmC vYxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777471203; x=1778076003; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pXYxfb1OnKvjy9v+vQDtCcuNHO3JiDi1MdrPDxdzPQ4=; b=ETEIDdxtX7QjpLk4oVYrQvkKQiBbdcyOU8ZqlXAOQw2GRecXDE67vtkYp0djAY0j3J RloyX6KgSwtdy1hzOgm2JXICMFVRFmhz6211QA/sRmzan/0wd9UTEHe4ueTOiWjNQ+5B Ix+dQPpzfJytovwQdHAxVIPOZU2ur52loffoFptuDTi293dId9Vj7iVgD3Wro6gSG4jU 7mVo9qCfX4Atq7liDL5wk+pkCJbGlfY2dh5/TZV373FTFzrZLYn6eQM0s77IfbjcG58Z TUei6OLi4Tt5bno3BXtaFzXUeMFUjgEvgsN8bUcH/KjQ0McqNQACqFgfW1MxD5i4Jl4C uiPg== X-Forwarded-Encrypted: i=1; AFNElJ+o2PBn5YUuxq2pJovYmQDVpfimcMwQ2YN4V3+ovwT+jGEAhO2B8Xm21GN3GduiSGreJwyZEA8EyRz2nLg=@vger.kernel.org X-Gm-Message-State: AOJu0YwDtX+C1RRTAFtJQSHYP3e08Nq5rulsef8KmyyYfm+r4FX48Zm/ JtZLUXjQqAIOWRQfgbfRN4UqE5hTeemo766cI57z5WIT9A7gTdHjsjbi X-Gm-Gg: AeBDieuLLmd3b3TWwiHQMxjTw9qObYJHZsV1Wv9a++XxKLpTbT/T8AyL/WvVGiIq2/X GZF3yAVlO2ctcFxDyFhYQ7UA8e451WSZbd9nB1flJuCTyl3D2db0T2UJunCZ4SQrymHYhpdLpjz jkiNz6IK8r3sMEnBZBkeXa5N8d3J2a+/GcFWR0ZFDmLSHOOXVYETdJdIBQuwjGFbWA85H5Moe43 iNrG8yHeB42H+opOu58uIo0375OYwsxMk8n7hp4ldczmj9Du4tVzHcect5Y2+I9aIM1qVQ1AU16 FiZig1Q3m14g6NkVD8CSIWkuubEaOkHtsycrXK5gjFhw/uzL+/66J98ui7pBQjsZHco8PRrYOj6 +zEjzyN4GlKRJUkTdHfKwVVjnGiYEbDpLKAO38kTAA9i80cdecEITcIT5lMNu21i8GDGhcLmgjk /CUaziCfyWet4ftoXFkBB4idrk3qgEf1uZJJLZxwR1Nl5gpy2F2z+HSNlbxP+GU9bDo50ra5TyD Q== X-Received: by 2002:a05:600c:c048:b0:48a:6268:18a9 with SMTP id 5b1f17b1804b1-48a782dd8e3mr77937175e9.13.1777471202791; Wed, 29 Apr 2026 07:00:02 -0700 (PDT) Received: from ?IPV6:2a00:f502:160:68fe:a26c:adcb:8da8:2? ([2a00:f502:160:68fe:a26c:adcb:8da8:2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b4216eecsm5409919f8f.9.2026.04.29.07.00.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 07:00:02 -0700 (PDT) Message-ID: <05df6383-5325-4f88-9638-22bc2d7a768d@gmail.com> Date: Wed, 29 Apr 2026 17:00:00 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 07/11] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled To: Konrad Dybcio , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260427-msm8939-venus-rfc-v3-0-288195bb7917@gmail.com> <9kBbj8Jr-f6eqC6XfnJPf3gKQD-3WfzXgzl4KEVKhRZlW2_GftgFBsijqUgEvGcgmeFqPwtVquMmibHUMaR_sQ==@protonmail.internalid> <20260427-msm8939-venus-rfc-v3-7-288195bb7917@gmail.com> <0ee6bf23-17a3-4a7c-93d2-276e97cc3a14@kernel.org> <1120b76e-3c98-4f32-821f-baab667dfc38@oss.qualcomm.com> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: <1120b76e-3c98-4f32-821f-baab667dfc38@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/29/26 12:18 PM, Konrad Dybcio wrote: > On 4/29/26 6:14 AM, Bryan O'Donoghue wrote: >> On 27/04/2026 18:58, Erikas Bitovtas wrote: >>> Since in downstream kernel VENUS_CORE0_GDSC and VENUS_CORE1_GDSC have a >>> device tree property "qcom,supports-hw-trigger", add a HW_CTRL flag >>> to these GDSCs to indicate that they are hardware controlled. >>> >>> Venus core clock cannot be enabled if Venus core GDSCs are switched off. >>> But since they are hardware controlled, they can be switched off at >>> any moment. Vote for the Venus core clock to enable it later when GDSCs >>> get turned on. >>> >>> Signed-off-by: Erikas Bitovtas >>> --- >>>   drivers/clk/qcom/gcc-msm8939.c | 4 ++++ >>>   1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c >>> index 45193b3d714b..420997b00ae0 100644 >>> --- a/drivers/clk/qcom/gcc-msm8939.c >>> +++ b/drivers/clk/qcom/gcc-msm8939.c >>> @@ -3664,6 +3664,7 @@ static struct clk_branch gcc_venus0_vcodec0_clk = { >>> >>>   static struct clk_branch gcc_venus0_core0_vcodec0_clk = { >>>       .halt_reg = 0x4c02c, >>> +    .halt_check = BRANCH_HALT_SKIP, >>>       .clkr = { >>>           .enable_reg = 0x4c02c, >>>           .enable_mask = BIT(0), >>> @@ -3681,6 +3682,7 @@ static struct clk_branch gcc_venus0_core0_vcodec0_clk = { >>> >>>   static struct clk_branch gcc_venus0_core1_vcodec0_clk = { >>>       .halt_reg = 0x4c034, >>> +    .halt_check = BRANCH_HALT_SKIP, >>>       .clkr = { >>>           .enable_reg = 0x4c034, >>>           .enable_mask = BIT(0), >>> @@ -3753,6 +3755,7 @@ static struct gdsc venus_core0_gdsc = { >>>       .pd = { >>>           .name = "venus_core0", >>>       }, >>> +    .flags = HW_CTRL, >>>       .pwrsts = PWRSTS_OFF_ON, >>>   }; >>> >>> @@ -3761,6 +3764,7 @@ static struct gdsc venus_core1_gdsc = { >>>       .pd = { >>>           .name = "venus_core1", >>>       }, >>> +    .flags = HW_CTRL, >>>       .pwrsts = PWRSTS_OFF_ON, >>>   }; >>> >>> >>> -- >>> 2.54.0 >>> >> >> The downstream opts to put the GDSC under hw control, which is not the same thing as it being under hw control, its up to you to put it under hw control. >> >> So you might want to be more conservative especially given you have a problem getting the encoder and decoder to run simultaneously - I might try parking this patch and then see what happens. > > i.e., Bryan is asking you to replace HW_CTRL with HW_CTRL_TRIGGER > I tried to revert the patch and replace HW_CTRL with HW_CTRL_TRIGGER - both result in power collapse fails.> Konrad