From: Charles Chiou <ch1102chiou@gmail.com>
To: Colin King <colin.king@canonical.com>,
Charles <charles.chiou@tw.promise.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Promise_Linux@promise.com
Subject: Re: [PATCH] scsi: stex: make S6flag static
Date: Wed, 26 Apr 2017 10:40:52 +0800 [thread overview]
Message-ID: <05e23578-0bc9-ebcc-28cd-22b8e6a06f00@gmail.com> (raw)
In-Reply-To: <20170425173619.11955-1-colin.king@canonical.com>
Looks good to me.
Thanks for the improvement.
On 4/26/2017 1:36 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> This module specific flag can be made static as it does
> not need to be in global scope.
>
> Reviewed-by: Charles Chiou <charles.chiou@tw.promise.com>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/stex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index 0751561b59da..9b20643ab49d 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -363,7 +363,7 @@ struct st_card_info {
> u16 sts_count;
> };
>
> -int S6flag;
> +static int S6flag;
> static int stex_halt(struct notifier_block *nb, ulong event, void *buf);
> static struct notifier_block stex_notifier = {
> stex_halt, NULL, 0
>
next prev parent reply other threads:[~2017-04-26 2:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 17:36 [PATCH] scsi: stex: make S6flag static Colin King
2017-04-26 2:40 ` Charles Chiou [this message]
2017-04-26 22:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05e23578-0bc9-ebcc-28cd-22b8e6a06f00@gmail.com \
--to=ch1102chiou@gmail.com \
--cc=Promise_Linux@promise.com \
--cc=charles.chiou@tw.promise.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox