From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74CA7435AAC for ; Mon, 6 Jul 2026 22:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783377159; cv=none; b=UFHLsWk4qDA2SckVxutAhucpq8Tzbj5J+U/SL9YE7HP3OymxYg7m0Nkedo20lgnzEh73cblj0U+9Ab9i1oKHSvTSV7rDhXaJCi/tmQ+vTTpnu5aoiR3//sPz0T3DVdNNrU1q7nwAXhIEUsHDGMA4Ua7ozJvMqvem1288aXJX6vI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783377159; c=relaxed/simple; bh=qOrM4sw46CtOSY6MbIlGeIi8vjVlDXaJDTKbaYWzzZg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qdKKVGH+HByv8Cho6ChfVLZz6so0woWf3EXuoAEHVQWLgu20U5ypA54eVhubcd5RshTBbeYzhJrn/r/bJwn9UKGj1voI9v+L8Cplfts0EHu4Y1KDSV76myEqEMpVIjzwEFX2zSQvXvm3zOQPUAN6DFo0iH9QAYuVdcymVQCqx1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MyJg+Jag; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MyJg+Jag" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783377156; x=1814913156; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=qOrM4sw46CtOSY6MbIlGeIi8vjVlDXaJDTKbaYWzzZg=; b=MyJg+JagIWQ/HgVf+LDLE5AlU+SNvWm+sPwz9ZZd+SDlH7ASEXUxi8Ho zEMtE0wcH5NiB4o3s931EEtV746JZzvUlsGQktj/aMXDbnbfNs8Ve2Qvi b8oFfdlD4waP33KYxUHAFzbSv1P2D7jvndJ44I3Emu9bjXvSU6CBfDz/C du8blxAE6Z19tSiGe+PmlFoJnEFCmLPOI9BkAW31D6kEsBdxp7QdcRY5B cMrmvG0MRVZFhyvolLLPVaPK0KPDHXxHnzUIDRAPLTa4RfCiXC/zDPGg7 s1RaPQ1jjp5wJyrXVszYm48cpwlcbzuBWsWTa1fOOd37O7T+nTbTBD21y g==; X-CSE-ConnectionGUID: IEtH4hQrRByt7hJuIvhPvg== X-CSE-MsgGUID: gMWB5V01S3WFbeep9V1X8g== X-IronPort-AV: E=McAfee;i="6800,10657,11839"; a="87700789" X-IronPort-AV: E=Sophos;i="6.25,151,1779174000"; d="scan'208";a="87700789" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2026 15:32:36 -0700 X-CSE-ConnectionGUID: 0JT2CG9AQvyKFfFgICUafg== X-CSE-MsgGUID: 1bRP+e2NTa29gDhtFLACQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,151,1779174000"; d="scan'208";a="278179415" Received: from sghuge-mobl2.amr.corp.intel.com (HELO [10.125.110.202]) ([10.125.110.202]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2026 15:32:35 -0700 Message-ID: <05e4d5aa-ece4-4f43-89d2-23471f1edbbd@intel.com> Date: Mon, 6 Jul 2026 15:32:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvdimm: nfit: remove redundant NULL check before vfree() To: mdshahid03@gmail.com, Dan Williams , Vishal Verma , Alison Schofield , Ira Weiny Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260703144851.80309-1-mdshahid03@gmail.com> Content-Language: en-US From: Dave Jiang In-Reply-To: <20260703144851.80309-1-mdshahid03@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/3/26 7:48 AM, mdshahid03@gmail.com wrote: > From: Mohammad Shahid > > vfree() safely handles NULL pointers, so the explicit NULL check > before calling vfree() is unnecessary. > > This issue was reported by ifnullfree.cocci. > > Signed-off-by: Mohammad Shahid Reviewed-by: Dave Jiang > --- > tools/testing/nvdimm/test/nfit.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c > index f87e9f251d13..009fe107b0d7 100644 > --- a/tools/testing/nvdimm/test/nfit.c > +++ b/tools/testing/nvdimm/test/nfit.c > @@ -1644,8 +1644,7 @@ static void *__test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma, > err: > if (*dma && size >= DIMM_SIZE) > gen_pool_free(nfit_pool, *dma, size); > - if (buf) > - vfree(buf); > + vfree(buf); > kfree(nfit_res); > return NULL; > }