public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: <markus.stockhausen@gmx.de>
To: "'Ahmed Naseef'" <naseefkm@gmail.com>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: AW: [PATCH] mtd: nand: realtek-ecc: relax OOB size check to minimum
Date: Fri, 6 Feb 2026 19:26:56 +0100	[thread overview]
Message-ID: <05ea01dc9796$2d228d80$8767a880$@gmx.de> (raw)
In-Reply-To: <aYXrYC06slPu1EUJ@DESKTOP-TIT0J8O.localdomain>

> Von: Ahmed Naseef <naseefkm@gmail.com> 
> An: markus.stockhausen@gmx.de
> Betreff: Re: [PATCH] mtd: nand: realtek-ecc: relax OOB size check to minimum
> ...
> > > Signed-off-by: Ahmed Naseef <naseefkm@gmail.com>
> > > Suggested-by: Markus Stockhausen <markus.stockhausen@gmx.de>
> > 
> > IIRC this should be the other way round.
> > 
> Could you clarify what you meant by "the other way round" — do you
> mean the ordering of the Suggested-by/Signed-off-by tags, or the
> attribution itself?

The one who had the patch in his/her hands last, must be on the bottom 
of the list. Chronological order so to say.

> Regarding the comment about the two known devices — I was planning
> to update it to something like:

    * It can run for arbitrary NAND flash chips with different block and OOB sizes. Currently there
    * are a few known devices in the wild that make use of this ECC engine
    * (Linksys LGS328C, LGS352C & Netlink HG323DAC). To keep compatibility with vendor firmware,
    * new modes can only be added when new data layouts have been analyzed. For now allow BCH6 on
    * flash with 2048 byte blocks and at least 64 bytes oob. Some vendors make use of
    * 128 bytes OOB NAND chips (e.g. Macronix MX35LF1G24AD) but only use BCH6 and thus the first
    * 64 bytes of the OOB area. In this case the engine leaves any extra bytes unused.

Small adaptions fromm y side in the comment above. Check for spelling 
mistakes and line lengths. With this good to go from my side.

Markus


      reply	other threads:[~2026-02-06 18:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 11:11 [PATCH] mtd: nand: realtek-ecc: relax OOB size check to minimum markus.stockhausen
2026-02-06 13:23 ` Ahmed Naseef
2026-02-06 18:26   ` markus.stockhausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='05ea01dc9796$2d228d80$8767a880$@gmx.de' \
    --to=markus.stockhausen@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=naseefkm@gmail.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox