Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

Tom Saeger
2023-04-18T19:29:26Z

On Tue, Apr 18, 2023 at 01:24:12PM -0400, Waiman Long wrote:
>
> On 4/18/23 11:08, Naresh Kamboju wrote:
> > On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > This is the start of the stable review cycle for the 5.10.178 release.
> > > There are 124 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> > Following build errors noticed on 5.15 and 5.10.,
> >
> >
> > > Waiman Long <longman@redhat.com>
> > > cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
> > kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> > kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
> > (first use in this function); did you mean 'cgroup_put'?
> > 2941 | lockdep_assert_held(&cgroup_mutex);
> > | ^~~~~~~~~~~~
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > Suspected commit,
> > cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> > commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
>
> Oh, cgroup_mutex needs the recent commit 354ed59744295 ("mm: multi-gen LRU:
> kill switch") to make it available in include/linux/cgroup.h. I did my
> testing with a debug Kconfig and so didn't catch that. This line can be
> safely removed.
>

I can confirm removing just this line fixed 5.15 x86_64 build for me.
Thanks!

--Tom