public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Bumwoo Lee" <bw365.lee@samsung.com>
To: "'Chanwoo Choi'" <cwchoi00@gmail.com>,
	"'Andy Shevchenko'" <andriy.shevchenko@linux.intel.com>,
	<linux-kernel@vger.kernel.org>
Cc: "'MyungJoo Ham'" <myungjoo.ham@samsung.com>,
	"'Chanwoo Choi'" <cw00.choi@samsung.com>
Subject: RE: [PATCH v1 00/14] extcon: Core cleanups and documentation fixes
Date: Thu, 6 Apr 2023 09:04:03 +0900	[thread overview]
Message-ID: <05ee01d9681b$4c444ad0$e4cce070$@samsung.com> (raw)
In-Reply-To: <9c9ca17a-7211-633d-7072-44992ab6852e@gmail.com>

Hi

> -----Original Message-----
> From: Chanwoo Choi <cwchoi00@gmail.com>
> Sent: Thursday, April 6, 2023 8:17 AM
> To: Bumwoo Lee <bw365.lee@samsung.com>; 'Andy Shevchenko'
> <andriy.shevchenko@linux.intel.com>; linux-kernel@vger.kernel.org
> Cc: 'MyungJoo Ham' <myungjoo.ham@samsung.com>; 'Chanwoo Choi'
> <cw00.choi@samsung.com>
> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> fixes
> 
> Hi,
> 
> On 23. 3. 31. 09:48, Bumwoo Lee wrote:
> > Hi Andy Shevchenko
> >> -----Original Message-----
> >> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Sent: Thursday, March 30, 2023 7:12 PM
> >> To: Bumwoo Lee <bw365.lee@samsung.com>; linux-kernel@vger.kernel.org
> >> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
> >> <cw00.choi@samsung.com>
> >> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> >> fixes
> >>
> >> On Wed, Mar 22, 2023 at 04:39:51PM +0200, Andy Shevchenko wrote:
> >>> A few fixes to the documentation and some cleanups against extcon
> >>> core module.
> >>
> >> Anything I should do with the series?
> >> Any comments on it?
> >>
> >> --
> >> With Best Regards,
> >> Andy Shevchenko
> >>
> >
> > Looks fine to me.
> >
> > Acked-by: Bumwoo Lee <bw365.lee@samsung.com>
> >
> > MR. Chanwoo, Would you please take a look at this patch series.
> >
> 
> Actually, Acked tag will be replied by Maintainer or the driver owner.
> If you want to review the mailing list patch, I think that Reviewed-by tag
> is proper.
> 

OK.
Thank you for your detail guidance. I will follow this guidance on next time.

> Unfortunately, I could not see the any review comment from you even if
> this patchset have the some review contents. Also you didn't review the
> any patches of extcon before.
> 
> I'm always welcome for many reviewers in order to improve the linux kernel.
> But, in this case, I'm not sure that you are reviewing this patchset.
> 
> So that I'm sorry that I cannot take your acked-tag.
> 

I agree your comment.
Thank you~

> --
> Best Regards,
> Samsung Electronics
> Chanwoo Choi



  reply	other threads:[~2023-04-06  0:05 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 14:39 [PATCH v1 00/14] extcon: Core cleanups and documentation fixes Andy Shevchenko
2023-03-22 14:39 ` [PATCH v1 01/14] extcon: Fix kernel doc of property fields to avoid warnings Andy Shevchenko
2023-04-03 13:50   ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 02/14] extcon: Fix kernel doc of property capability " Andy Shevchenko
2023-04-03 13:51   ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 03/14] extcon: Use DECLARE_BITMAP() to declare bit arrays Andy Shevchenko
2023-04-03 14:04   ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 04/14] extcon: use sysfs_emit() to instead of sprintf() Andy Shevchenko
2023-04-03 14:10   ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 05/14] extcon: Amend kernel documentation of struct extcon_dev Andy Shevchenko
2023-04-03 14:10   ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 06/14] extcon: Allow name to be assigned outside of the framework Andy Shevchenko
2023-04-03 13:56   ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 07/14] extcon: Use unique number for the extcon device ID Andy Shevchenko
2023-04-03 14:52   ` Chanwoo Choi
2023-04-05 15:03     ` Andy Shevchenko
2023-03-22 14:39 ` [PATCH v1 08/14] extcon: Switch to use kasprintf_strarray() Andy Shevchenko
2023-04-03 14:58   ` Chanwoo Choi
2023-04-05  8:16     ` Andy Shevchenko
2023-04-05 15:05       ` Andy Shevchenko
2023-03-22 14:40 ` [PATCH v1 09/14] extcon: Use device_match_of_node() helper Andy Shevchenko
2023-04-03 14:14   ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 10/14] extcon: use dev_of_node(dev) instead of dev->of_node Andy Shevchenko
2023-04-03 14:17   ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 11/14] extcon: Remove dup device name in the message and unneeded error check Andy Shevchenko
2023-04-03 14:59   ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 12/14] extcon: Use sizeof(*pointer) instead of sizeof(type) Andy Shevchenko
2023-04-03 14:32   ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 13/14] extcon: Drop unneeded assignments Andy Shevchenko
2023-04-03 15:06   ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 14/14] extcon: Use positive conditional in ternary operator Andy Shevchenko
2023-04-03 14:38   ` Chanwoo Choi
2023-04-05  8:18     ` Andy Shevchenko
2023-03-30 10:11 ` [PATCH v1 00/14] extcon: Core cleanups and documentation fixes Andy Shevchenko
2023-03-31  0:48   ` Bumwoo Lee
2023-04-05 23:17     ` Chanwoo Choi
2023-04-06  0:04       ` Bumwoo Lee [this message]
2023-04-06 10:49       ` 'Andy Shevchenko'
2023-04-03 13:58 ` Chanwoo Choi
2023-04-05  8:12   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='05ee01d9681b$4c444ad0$e4cce070$@samsung.com' \
    --to=bw365.lee@samsung.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=cw00.choi@samsung.com \
    --cc=cwchoi00@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox