Re: [PATCH 2/3] dt-bindings: mfd: Add Realtek ISO system controller

Krzysztof Kozlowski
2025-11-13T19:41:55Z

On 11/11/2025 13:19, Eleanor Lin [林祐君] wrote:
> Hi Krzysztof,
>
> Sorry for the delay in responding to you.
>
>> On 05/11/2025 11:44, Yu-Chun Lin wrote:
>>> Add DT binding schema for Realtek system controller.
>>>
>>> Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
>>> ---
>>> .../bindings/mfd/realtek,iso-system.yaml | 65
>> +++++++++++++++++++
>>> 1 file changed, 65 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
>>> b/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
>>> new file mode 100644
>>> index 000000000000..6fbdedd3ee5b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mfd/realtek,iso-system.yaml
>>> @@ -0,0 +1,65 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/mfd/realtek,iso-system.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Realtek ISO System Controller
>>> +
>>> +description: |
>>
>>
>> Do not need '|' unless you need to preserve formatting.
>>
>
> I will remove it in V2.
>
>>> + The Realtek ISO System Controller is a register area that contains
>>> + miscellaneous system registers for the SoC and serves as a parent
>>> + node for other functions.
>>> +
>>> +maintainers:
>>> + - James Tai <james.tai@realtek.com>
>>> + - Yu-Chun Lin <eleanor.lin@realtek.com>
>>> +
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - enum:
>>> + - realtek,iso-system
>>
>> No clue what is "iso system", neither commit msg, nor title nor description
>> explain me that. Please add first bindings for the iso soc or if this is not soc,
>> then use only soc-specific compatibles (see writing bindings doc).
>>
>
> I will rename 'realtek,misc' for clarity.

How "misc" clarifies a lot? In what way this helps anyone to understand:
1. What is this hardware?
2. What device it is?
3. How do you fulfill requirements from writing-bindings?

Best regards,
Krzysztof