From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A0179C4; Thu, 17 Apr 2025 05:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744866874; cv=none; b=KSu0v9hg/zUm/3cA78UGGIKUDdCn7NGadvhoGncPRHSmQxXRvV3d4a4Ijx1LNF6Zs4Cc/do/YiszmNuNtivWMCqwPoXuo+ex6+qW4t3y5dURhiN51kGy1O6S6c+qsYhvrQh65QJVphtHvy9SNKDf1n1+q8qfd5PweKwGg1bCQuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744866874; c=relaxed/simple; bh=cxS3VnSkmgg7XP0hUuThSmPSabdPMl112SqOb4z6NJ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dFTZCSQI7tQ/PElB/h5eZutUp0GaACSUfQbFmhHV3bKvTIB2QoDTJB5ZFV1O5gPTpCPM9sltJGgRtG9qb9+i3TGGQZvdFc8hgXK2RTvYW30cAV2E6n1Ef2KRYWyTny3wwZAT1Vj2TlWsAqXbR64stgKCiXahNlgI7wOquu/pngY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gqnA+cBN; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gqnA+cBN" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-acb5ec407b1so48492166b.1; Wed, 16 Apr 2025 22:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744866871; x=1745471671; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=/6VVGbk7/10nDXV6MbjXzf9QqxxSVAmsbxmL+ya7Ong=; b=gqnA+cBN9YUOLN68niAUiFqioqO7iIwFIGmgWSSqO4J+18FN5etaC6FS5a25smMILm sb08Sh4BJCGAPNdcYRSoXR+YqGXxHcFVkRk08AaseM31xztk0peUglZsSvpolcIsbMXh 1sL/OqDe3ND9O4g98HLj4Whm9HEYrysTqmEgllkIge+/Wi4DQFUONTp2+iQazKga66nF sjVA2lEm+n2dENjZiSLP8VD/2VTTYNearHsN4QlC709tEaTX+L8D8z5K6QXpvHo1mU2t OS1xMQHoR7Mr8bEyav87EIs/rQwWt6ulM1M6c6SD116GmQ+kW1i3JLQnyluMWW7bJHf6 HCAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744866871; x=1745471671; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/6VVGbk7/10nDXV6MbjXzf9QqxxSVAmsbxmL+ya7Ong=; b=ZruNELMI+o228t5g3WazOl/d+wmzUDH2YRnkg6mge1C7dAg1d7nJidy/PhPk1vCOyt Oqup5/TQGYddwmAHdt+TJuSy/uwX9xf0Fhd5F9nr5W1ETdwX2xO2Onhce/+6UKKS/+BG XWNAAuX2mZ9tV0yK1/eZNE4BtVXx5nkOoHMuAg4nIil4eathkSXE2XnY0KV7Kss9z2id TXK4fu3ceMAdFtyl/kfpvOWY62Sg6rGK/61hYJVz5AyJI73d3sTkU+Tf5hA7JEg0/Gnt V/gTz7PIVkKj6QcTfipS252RHoAYwhasl0nUkEjJidqEVion5FgVOGRAjGa2QzwK7xB0 L1Jg== X-Forwarded-Encrypted: i=1; AJvYcCUCOljrzO+Bdk9orq9OCQudqYUZHeXp5zPRIp7TjSE9F13X9voo0TvkhhZYcSYdVHYTrBj/jvxJzd//9sDKZw==@vger.kernel.org, AJvYcCUfOlOrXmqziPvzmuDaJS7BtOjOT+25xRBfZiksLw20oYFc5L0IfgI+ishyB9H4KAQiHrMH0+Bs/VW80Q==@vger.kernel.org, AJvYcCUk8zbmjC//7yu2cxhzfEPO02ydlcNy9qfaI3djDjGu768gBGye4r43NitvaKYX1byrB/ifkNBcxYtInrmz@vger.kernel.org X-Gm-Message-State: AOJu0YytQ61wjMAZetYy48E25sHssWWYStXjVciuljQxQB3gNrIUIPc4 4RgRv7QM5ZwURyMfdIRkGwvafn4H0LSX4pnWmIsln5QE2ZURffJ0 X-Gm-Gg: ASbGncucNnDEwLpxjyuvbep66IpE4Ylg1gNp8+HjZ6yX5nY4f+JPMW9OsEBCdno9gMJ s5geDzXkmOHL3T7A4zEbp0ttM5dfTwPHLQlAQQDlAMVWPZp0oiqTmgMhB3CLYnhyYPLOZ5DUt4i riqIFpzhrZ3cb1HDMNM14ubXzijoXK5AYiFM66nNQfU/u5A3LI8HJfzUU0XGde/eXs2YOOIHPr/ DEwNh02JSh564arhQC8GnCeU2LEMyBKABhO3aaIRNLMkOwu3RcKQZAnRSv7jm6Ds9ht+/q0iKvc pXAB7q+OYftCJbfaI/21i0g2FdbgcUvtpvAfRVLa+yTGfhdHTb9xDYBoYrKpFvkeXQ== X-Google-Smtp-Source: AGHT+IGjoVZT2KhQx6/gxqpaGVfcjmGD3TxtHf+gaeBWoPU0zgqTPKr4b5wv8b2GZJFvcegcgg5rMQ== X-Received: by 2002:a17:906:7311:b0:ac2:9841:3085 with SMTP id a640c23a62f3a-acb429e40b9mr331666266b.30.1744866870346; Wed, 16 Apr 2025 22:14:30 -0700 (PDT) Received: from [192.168.2.22] (85-70-151-113.rcd.o2.cz. [85.70.151.113]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb3d32ec83sm228122766b.162.2025.04.16.22.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Apr 2025 22:14:29 -0700 (PDT) Message-ID: <060f3d14-e669-4485-98d1-fb89f8cef79b@gmail.com> Date: Thu, 17 Apr 2025 07:14:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [regression 6.1.y] Regression from 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") with pci-passthrough for both KVM VMs and booting in xen DomU To: Salvatore Bonaccorso , Alex Williamson Cc: David Howells , Christoph Hellwig , David Hildenbrand , Lorenzo Stoakes , Andrew Morton , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , Sasha Levin , Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@lists.linux.dev, "stable@vger.kernel.org Bernd Rinn" , =?UTF-8?B?S2FycmkgSMOkbcOkbMOkaW5lbg==?= , Cameron Davidson , Markus References: <20250416142645.4392a644.alex.williamson@redhat.com> Content-Language: en-US From: Milan Broz Autocrypt: addr=gmazyland@gmail.com; keydata= xsFNBE94p38BEADZRET8y1gVxlfDk44/XwBbFjC7eM6EanyCuivUPMmPwYDo9qRey0JdOGhW hAZeutGGxsKliozmeTL25Z6wWICu2oeY+ZfbgJQYHFeQ01NVwoYy57hhytZw/6IMLFRcIaWS Hd7oNdneQg6mVJcGdA/BOX68uo3RKSHj6Q8GoQ54F/NpCotzVcP1ORpVJ5ptyG0x6OZm5Esn 61pKE979wcHsz7EzcDYl+3MS63gZm+O3D1u80bUMmBUlxyEiC5jo5ksTFheA8m/5CAPQtxzY vgezYlLLS3nkxaq2ERK5DhvMv0NktXSutfWQsOI5WLjG7UWStwAnO2W+CVZLcnZV0K6OKDaF bCj4ovg5HV0FyQZknN2O5QbxesNlNWkMOJAnnX6c/zowO7jq8GCpa3oJl3xxmwFbCZtH4z3f EVw0wAFc2JlnufR4dhaax9fhNoUJ4OSVTi9zqstxhEyywkazakEvAYwOlC5+1FKoc9UIvApA GvgcTJGTOp7MuHptHGwWvGZEaJqcsqoy7rsYPxtDQ7bJuJJblzGIUxWAl8qsUsF8M4ISxBkf fcUYiR0wh1luUhXFo2rRTKT+Ic/nJDE66Ee4Ecn9+BPlNODhlEG1vk62rhiYSnyzy5MAUhUl stDxuEjYK+NGd2aYH0VANZalqlUZFTEdOdA6NYROxkYZVsVtXQARAQABzSBNaWxhbiBCcm96 IDxnbWF6eWxhbmRAZ21haWwuY29tPsLBlQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AWIQQqKRgkP95GZI0GhvnZsFd72T6Y/AUCYaUUZgUJJPhv5wAKCRDZsFd72T6Y/D5N D/438pkYd5NyycQ2Gu8YAjF57Od2GfeiftCDBOMXzh1XxIx7gLosLHvzCZ0SaRYPVF/Nr/X9 sreJVrMkwd1ILNdCQB1rLBhhKzwYFztmOYvdCG9LRrBVJPgtaYqO/0493CzXwQ7FfkEc4OVB uhBs4YwFu+kmhh0NngcP4jaaaIziHw/rQ9vLiAi28p1WeVTzOjtBt8QisTidS2VkZ+/iAgqB 9zz2UPkE1UXBAPU4iEsGCVXGWRz99IULsTNjP4K3p8ZpdZ6ovy7X6EN3lYhbpmXYLzZ3RXst PEojSvqpkSQsjUksR5VBE0GnaY4B8ZlM3Ng2o7vcxbToQOsOkbVGn+59rpBKgiRadRFuT+2D x80VrwWBccaph+VOfll9/4FVv+SBQ1wSPOUHl11TWVpdMFKtQgA5/HHldVqrcEssWJb9/tew 9pqxTDn6RHV/pfzKCspiiLVkI66BF802cpyboLBBSvcDuLHbOBHrpC+IXCZ7mgkCrgMlZMql wFWBjAu8Zlc5tQJPgE9eeQAQrfZRcLgux88PtxhVihA1OsMNoqYapgMzMTubLUMYCCsjrHZe nzw5uTcjig0RHz9ilMJlvVbhwVVLmmmf4p/R37QYaqm1RycLpvkUZUzSz2NCyTcZp9nM6ooR GhpDQWmUdH1Jz9T6E9//KIhI6xt4//P15ZfiIs7BTQRPeKd/ARAA3oR1fJ/D3GvnoInVqydD U9LGnMQaVSwQe+fjBy5/ILwo3pUZSVHdaKeVoa84gLO9g6JLToTo+ooMSBtsCkGHb//oiGTU 7KdLTLiFh6kmL6my11eiK53o1BI1CVwWMJ8jxbMBPet6exUubBzceBFbmqq3lVz4RZ2D1zKV njxB0/KjdbI53anIv7Ko1k+MwaKMTzO/O6vBmI71oGQkKO6WpcyzVjLIip9PEpDUYJRCrhKg hBeMPwe+AntP9Om4N/3AWF6icarGImnFvTYswR2Q+C6AoiAbqI4WmXOuzJLKiImwZrSYnSfQ 7qtdDGXWYr/N1+C+bgI8O6NuAg2cjFHE96xwJVhyaMzyROUZgm4qngaBvBvCQIhKzit61oBe I/drZ/d5JolzlKdZZrcmofmiCQRa+57OM3Fbl8ykFazN1ASyCex2UrftX5oHmhaeeRlGVaTV iEbAvU4PP4RnNKwaWQivsFhqQrfFFhvFV9CRSvsR6qu5eiFI6c8CjB49gBcKKAJ9a8gkyWs8 sg4PYY7L15XdRn8kOf/tg98UCM1vSBV2moEJA0f98/Z48LQXNb7dgvVRtH6owARspsV6nJyD vktsLTyMW5BW9q4NC1rgQC8GQXjrQ+iyQLNwy5ESe2MzGKkHogxKg4Pvi1wZh9Snr+RyB0Rq rIrzbXhyi47+7wcAEQEAAcLBfAQYAQgAJgIbDBYhBCopGCQ/3kZkjQaG+dmwV3vZPpj8BQJh pRSXBQkk+HAYAAoJENmwV3vZPpj8BPMP/iZV+XROOhs/MsKd7ngQeFgETkmt8YVhb2Rg3Vgp AQe9cn6aw9jk3CnB0ecNBdoyyt33t3vGNau6iCwlRfaTdXg9qtIyctuCQSewY2YMk5AS8Mmb XoGvjH1Z/irrVsoSz+N7HFPKIlAy8D/aRwS1CHm9saPQiGoeR/zThciVYncRG/U9J6sV8XH9 OEPnQQR4w/V1bYI9Sk+suGcSFN7pMRMsSslOma429A3bEbZ7Ikt9WTJnUY9XfL5ZqQnjLeRl 8243OTfuHSth26upjZIQ2esccZMYpQg0/MOlHvuFuFu6MFL/gZDNzH8jAcBrNd/6ABKsecYT nBInKH2TONc0kC65oAhrSSBNLudTuPHce/YBCsUCAEMwgJTybdpMQh9NkS68WxQtXxU6neoQ U7kEJGGFsc7/yXiQXuVvJUkK/Xs04X6j0l1f/6KLoNQ9ep/2In596B0BcvvaKv7gdDt1Trgg vlB+GpT+iFRLvhCBe5kAERREfRfmWJq1bHod/ulrp/VLGAaZlOBTgsCzufWF5SOLbZkmV2b5 xy2F/AU3oQUZncCvFMTWpBC+gO/o3kZCyyGCaQdQe4jS/FUJqR1suVwNMzcOJOP/LMQwujE/ Ch7XLM35VICo9qqhih4OvLHUAWzC5dNSipL+rSGHvWBdfXDhbezJIl6sp7/1rJfS8qPs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/16/25 11:50 PM, Salvatore Bonaccorso wrote: > Hi Alex, > > On Wed, Apr 16, 2025 at 02:26:45PM -0600, Alex Williamson wrote: >> On Tue, 15 Apr 2025 20:59:19 +0200 >> Salvatore Bonaccorso wrote: >> >>> Hi >>> >>> [Apologies if this has been reported already but I have not found an >>> already filled corresponding report] >>> >>> After updating from the 6.1.129 based version to 6.1.133, various >>> users have reported that their VMs do not boot anymore up (both KVM >>> and under Xen) if pci-passthrough is involved. The reports are at: >>> >>> https://bugs.debian.org/1102889 >>> https://bugs.debian.org/1102914 >>> https://bugs.debian.org/1103153 >>> >>> Milan Broz bisected the issues and found that the commit introducing >>> the problems can be tracked down to backport of c8070b787519 ("mm: >>> Don't pin ZERO_PAGE in pin_user_pages()") from 6.5-rc1 which got >>> backported as 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in >>> pin_user_pages()") in 6.1.130. See https://bugs.debian.org/1102914#60 >>> >>> #regzbot introduced: 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 >>> >>> 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 is the first bad commit >>> commit 476c1dfefab8b98ae9c3e3ad283c2ac10d30c774 >>> Author: David Howells >>> Date: Fri May 26 22:41:40 2023 +0100 >>> >>> mm: Don't pin ZERO_PAGE in pin_user_pages() >>> >>> [ Upstream commit c8070b78751955e59b42457b974bea4a4fe00187 ] >> >> It's a bad backport, I've debugged and posted the fix for stable here: >> >> https://lore.kernel.org/all/20250416202441.3911142-1-alex.williamson@redhat.com/ > > Thank you, that worked (replying here as well mainly to fix my mistake > in the CC to stable@vger.kernel.org, which got truncated to > table@vger.kernel.org in my initial submission). I can also confirm the fix works, thanks for the quick response! Tested-by: Milan Broz Milan