From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbbCaGyM (ORCPT ); Tue, 31 Mar 2015 02:54:12 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:22634 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbbCaGyJ (ORCPT ); Tue, 31 Mar 2015 02:54:09 -0400 X-AuditID: cbfee690-f79ab6d0000046f7-e9-551a448d6dd5 From: Kukjin Kim To: "'Javier Martinez Canillas'" , "'Chanwoo Choi'" Cc: "'Krzysztof Kozlowski'" , "'Kukjin Kim'" , "'Alessandro Zummo'" , devicetree@vger.kernel.org, "'Linux Kernel'" , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, "'Alexandre Belloni'" , "'Kyungmin Park'" References: <1427728773-29065-1-git-send-email-k.kozlowski@samsung.com> <1427728773-29065-3-git-send-email-k.kozlowski@samsung.com> <5519DE76.4080803@samsung.com> In-reply-to: Subject: RE: [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc Date: Tue, 31 Mar 2015 15:54:05 +0900 Message-id: <063901d06b7f$7a72d8f0$6f588ad0$@kernel.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQIk4Nvu8axclWW6YjZqnQ2UNXzwPAK7xpotAu+zX90BgyuXRJxTx/Ug Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsWyRsSkRbfXRSrU4OEJA4slF6+yW3RcW8xk cf3Lc1aL+UfOsVpc+z2DzeL1C0OL/sevmS3ONr1ht9j0+BqrxeVdc9gsZpzfx2Sxv7OD0YHH 4+/sVmaPJ5suMnrsmXiSzWPTqk42j81L6j36tqxi9Jg+7yeTx+dNcgEcUVw2Kak5mWWpRfp2 CVwZO2ZuYy/YKVnRs/8JSwPjR6EuRg4OCQETiedn6roYOYFMMYkL99azdTFycQgJLGWU6L7a yQaRMJH4suEXE0RiEaPE3xf3WUESQgLvGSUe7i0HGcQmoCzR2KQPEhYW0JJYuKWJBcQWEYiT mDflDNhQZoElzBIP2mayQwx6yyixY+JtRpAqToFgiUfL+hghusMl3s9vZgMZyiKgKrHseypI mFfAQmLv2SdMELagxI/J91hASpgF1CWmTMkFCTMLyEtsXvOWGeJmBYkdZ18zQtzgJnFh3QFW iBoRiX0v3jGCnCAhsIVD4u6jR2CHsggISHybfIgFEiiyEpsOQM2RlDi44gbLBEbJWUg2z0LY PAvJ5llINixgZFnFKJpakFxQnJReZKJXnJhbXJqXrpecn7uJEZgcTv97NmEH470D1ocYBTgY lXh4K+5IhgqxJpYVV+YeYjQFOmgis5Rocj4wBeWVxBsamxlZmJqYGhuZW5opifO+lvoZLCSQ nliSmp2aWpBaFF9UmpNafIiRiYNTqoGRM4Nh9tEAw8xzbTrfPvTwMD5cVJesNv/J5DVbp3j+ L+u0644+J/fQhun289mn/DRWN6VX2U3QulsbY+XJ8maHsWxfRvZnzzcMF72+5oabGWi8tmle 0tDE9+y5xzvVQ9PFpXecnji9r9tEY1vQvopjW9cnd0Q8tLt/JrrL63tBc5DXtfsMC12VWIoz Eg21mIuKEwFY5qeZCQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIKsWRmVeSWpSXmKPExsVy+t9jAd1eF6lQg/YGbYslF6+yW3RcW8xk cf3Lc1aL+UfOsVpc+z2DzeL1C0OL/sevmS3ONr1ht9j0+BqrxeVdc9gsZpzfx2Sxv7OD0YHH 4+/sVmaPJ5suMnrsmXiSzWPTqk42j81L6j36tqxi9Jg+7yeTx+dNcgEcUQ2MNhmpiSmpRQqp ecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlA1yoplCXmlAKFAhKLi5X0 7TBNCA1x07WAaYzQ9Q0JgusxMkADCesYM3bM3MZesFOyomf/E5YGxo9CXYycHBICJhJfNvxi grDFJC7cW8/WxcjFISSwiFHi74v7rCAJIYH3jBIP95Z3MXJwsAkoSzQ26YOEhQW0JBZuaWIB sUUE4iTmTTkD1ssssIRZ4kHbTHaIQW8ZJXZMvM0IUsUpECzxaFkfI0R3uMT7+c1sIENZBFQl ln1PBQnzClhI7D37hAnCFpT4MfkeC0gJs4C6xJQpuSBhZgF5ic1r3jJD3KwgsePsa0aIG9wk Lqw7wApRIyKx78U7xgmMwrOQTJqFMGkWkkmzkHQsYGRZxSiaWpBcUJyUnmuoV5yYW1yal66X nJ+7iRGcfJ5J7WBc2WBxiFGAg1GJh/fCPclQIdbEsuLK3EOMEhzMSiK8ez4ChXhTEiurUovy 44tKc1KLDzGaAr05kVlKNDkfmBjzSuINjU3MjCyNzCyMTMzNlcR5lezbQoQE0hNLUrNTUwtS i2D6mDg4pRoYc7aZn63MKnqb7PB15m3m3s7+qZX3zjEtfbohJDZ2o/2Ok5GSmc+WTD3BJ7d9 v3nqNo0UqZdPFoQxr30/2bksaqph/eJo55qqRXV8FpbXl2y6+2XN3hV5K+9NmOXToHY6Xmbr qilP7jqEV8gU895dzDW1ij/e/cXaIPdJWuefT66I5TfQKyi3UGIpzkg01GIuKk4EAFEPqdxU AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Javier Martinez Canillas wrote: > > On Tue, Mar 31, 2015 at 1:38 AM, Chanwoo Choi wrote: > > On 03/31/2015 12:19 AM, Krzysztof Kozlowski wrote: > >> Mark "samsung,exynos3250-rtc" compatible as deprecated because it > >> duplicates the "samsung,s3c6410-rtc". Use "samsung,s3c6410-rtc" on > >> Exynos3250 and Exynos4415 boards. > >> > >> Signed-off-by: Krzysztof Kozlowski > >> --- > >> Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 3 ++- > >> arch/arm/boot/dts/exynos3250.dtsi | 2 +- > >> arch/arm/boot/dts/exynos4415.dtsi | 2 +- > >> 3 files changed, 4 insertions(+), 3 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > >> index ab757b84daa7..ac2fcd6ff4b8 100644 > >> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > >> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > >> @@ -6,7 +6,8 @@ Required properties: > >> * "samsung,s3c2416-rtc" - for controllers compatible with s3c2416 rtc. > >> * "samsung,s3c2443-rtc" - for controllers compatible with s3c2443 rtc. > >> * "samsung,s3c6410-rtc" - for controllers compatible with s3c6410 rtc. > >> - * "samsung,exynos3250-rtc" - for controllers compatible with exynos3250 rtc. > >> + * "samsung,exynos3250-rtc" - (deprecated) for controllers compatible with > >> + exynos3250 rtc (use "samsung,s3c6410-rtc"). > >> - reg: physical base address of the controller and length of memory mapped > >> region. > >> - interrupts: Two interrupt numbers to the cpu should be specified. First > >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > >> index e3bfb11c6ef8..8d58b550e925 100644 > >> --- a/arch/arm/boot/dts/exynos3250.dtsi > >> +++ b/arch/arm/boot/dts/exynos3250.dtsi > >> @@ -189,7 +189,7 @@ > >> }; > >> > >> rtc: rtc@10070000 { > >> - compatible = "samsung,exynos3250-rtc"; > >> + compatible = "samsung,s3c6410-rtc"; > >> reg = <0x10070000 0x100>; > >> interrupts = <0 73 0>, <0 74 0>; > >> interrupt-parent = <&pmu_system_controller>; > >> diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi > >> index 5caea996e090..186cb8465683 100644 > >> --- a/arch/arm/boot/dts/exynos4415.dtsi > >> +++ b/arch/arm/boot/dts/exynos4415.dtsi > >> @@ -177,7 +177,7 @@ > >> }; > >> > >> rtc: rtc@10070000 { > >> - compatible = "samsung,exynos3250-rtc"; > >> + compatible = "samsung,s3c6410-rtc"; > >> reg = <0x10070000 0x100>; > >> interrupts = <0 73 0>, <0 74 0>; > >> status = "disabled"; > >> > > > > Looks good to me. > > > > Reviewed-by: Chanwoo Choi > > > > Thanks, > > Chanwoo Choi > > -- > > Looks good to me also. > > Reviewed-by: Javier Martinez Canillas > Thanks, applied. - Kukjin