From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759022AbcIQAKc (ORCPT ); Fri, 16 Sep 2016 20:10:32 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51377 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754382AbcIQAKY (ORCPT ); Fri, 16 Sep 2016 20:10:24 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 0C9DD617BF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Subject: Re: [PATCH] ARM: dts: msm8974: Add definitions for QCE & cryptobam To: Stanimir Varbanov , Iaroslav Gridin , andy.gross@linaro.org References: <20160830153740.13275-1-voker57@gmail.com> <32148db3-74b8-c81f-9688-b286d9516b9d@mm-sol.com> Cc: david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Stephen Boyd Message-ID: <06427c6c-cfbc-60b6-2646-70134fdbef5a@codeaurora.org> Date: Fri, 16 Sep 2016 17:10:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <32148db3-74b8-c81f-9688-b286d9516b9d@mm-sol.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/2016 06:09 AM, Stanimir Varbanov wrote: > Hi Iaroslav, > > On 08/30/2016 06:37 PM, Iaroslav Gridin wrote: >> From: Voker57 >> >> Add device tree definitions for Qualcomm Cryptography engine and its BAM >> Signed-off-by: Iaroslav Gridin >> --- >> arch/arm/boot/dts/qcom-msm8974.dtsi | 42 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi >> index 561d4d1..c0da739 100644 >> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi >> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi >> @@ -287,6 +287,48 @@ >> reg = <0xf9011000 0x1000>; >> }; >> >> + cryptobam: dma@fd444000 { >> + compatible = "qcom,bam-v1.4.0"; >> + reg = <0xfd444000 0x15000>; >> + interrupts = <0 236 0>; > should be > > interrupts = ; Please don't use IRQ_NONE. This one looks to be IRQ_TYPE_EDGE_RISING if I'm not mistaken. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project