From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF2372165EA for ; Thu, 23 Apr 2026 19:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776972194; cv=none; b=txoUnjfNJ1iEeumiitSBgs/Qi/I/E5lZxQrO6PphKoBjK9Qh2EFIV7fm0PlHjngDkY2lBgEo7I61ljkW/hAhmq7Lrx1qY7QllIo5nLT5VF1qKalo1jppo1xi1JztnKLkWrBmQkwc4LBfMPKPb6EKz4IDH14/BbrAl9gMdU9dAm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776972194; c=relaxed/simple; bh=UJbZV/Bn9GKnU8ZhrGpz91SwhraLH8FknNu9AnV+LBQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RyDuKok+AEoo/mznElWuDAhDti9q5/rudTXW0wBH//PGJrMenSMDq6kJYusWyNldPS7G0mdDKxTTsnhCJKfNp+Da4OsavjE/JDxqEFBdcqSQqiL+vB7DzFK/dmSQ3X1fZSBUjwYE7WC4fBZLD8NcA1eD/8MqqMacNPLxi1jt0ek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=u1JyEJ76; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u1JyEJ76" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso7486303eec.1 for ; Thu, 23 Apr 2026 12:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776972192; x=1777576992; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KpgheG35eXYQ8GLWRj5xPRmyPNvWWR7Dhs0tlVfh9Ts=; b=u1JyEJ76LuEfYCQs6Aw5SnVJWnnRFUNilob//uGQGyk5xH8AqCbBFJzIgXfE33IDmJ zn1He6D+JU2Ao1f2oHM3BPgS1gGqciY6hVkjxY9fa+yqR21Fg++3fze1tC0Ok5hhJtsJ idycThk41Pt1/GBqP93bR6i7cR9eBislrma0cEpLkiOYWE7aacnUgYu1whUuQ6KAZQsc hpqXFTSxaDZFRPEPzMg7bVMLLimXJshHFktz3lf3oIF7KQWhpup54P6BGydV1vEMeDEp sGSW+9DXXo6PNrEa+26xUhjg8NKYkqr7Y9SywLH4kS1Knnv1wnOXYkpDgLHN55pZVLWu 7lew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776972192; x=1777576992; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KpgheG35eXYQ8GLWRj5xPRmyPNvWWR7Dhs0tlVfh9Ts=; b=lrXgmJqw4ysXLzK9I349TcMQrAbFTbEJnyAm2uqjDR/9BFjcqmPWTQQAyjob0MjZGT mKNCUG3DhrHBZ+XAHQ9tDac2i35zFogJpIR5JhquNgg18Is/tjlY5oE+uYvpDieYlN7H Lg9t91DYGPjl3GQT+/G4lYCVlg1TBrhoFWji49FH27swVKDskWHgzknVRd6pLHqaS2sC G+gJOC20gHlLQpkgHUGDGN9QLUEktHv7wxlkAB3Qo833wRougg6bTbrpUYtYnO1QiQ6e +s9V1NfCEwYxT5Ngpo6w37cwrifA3sMrI89JXMt1Bw9K1vXFOLNpOs3fBar3Xq11U2Zx fHAw== X-Forwarded-Encrypted: i=1; AFNElJ9X77fbbAhCwmHFTnbyj0IUeX+l+XllKAtw9fXSiQCjaXPJqqNLfnpNwNE/ywbhPDeqCphpPySEtkcLQk0=@vger.kernel.org X-Gm-Message-State: AOJu0YwokA5YZIBqw3Neznsb1UTN4Hc/kt+Q7oMpDOago4ik2CSF6Bx/ t20ylE2SZS3S32I1SxVXButiCdVVbJm3b3Asi1X2Vp5FE6buP8WxZ2mgWtx+Anmubw== X-Gm-Gg: AeBDiev5/n7IjjCSqVspbUm6aDUh2mZ0ajXK3phIRhPtklq/kR25y7M3AyCWISW1UIY Q6/OXTaAA4fwHOnvKFYqdl/f+pCggYeGOWTsyb5bqkcRMIr5tQyzByM61K+A2Yf73boMPICnQt6 EhTZmKmVPIWWIv1/2wJbq8dAEXVgkW3vMae6n7kN4ECnVE/aB6AYXyLrFBilC58RrMTNcFIulo5 mHevtkJFPaVdh8sx2gmzR5CU3Eco9yTyeLMNB53OKu5nCGPDrdjUKxzdeAiUBdPEcpK95QlavNF ofpTHKW4DwbdY6NIJFewYf+am7FxDJ/GsfyZz1ThNS/x9UitcJ/atc/rXOYJSENnM01Th09x2WQ wlgTpxe6LeMtD8Du02ctl3nyiB5a2HrQ/eYh4GtqOOTaViK6Q2xq0XsYvkr6VuW4MJMmygWRMCh p2lnScDU21Mzd/Fd2K3uRYouBVYt+nPp968Ch4SvOaUlMS5UfL2WUp789Glj1NJe7wjhg4/mLq4 zQVnic95r/9HVRkKfdLnk3zU7o2s8/CJE2/usVZ/zkPZ6Q= X-Received: by 2002:a05:7300:220d:b0:2ce:25be:c8e8 with SMTP id 5a478bee46e88-2e477c9bb2dmr15432034eec.17.1776972191260; Thu, 23 Apr 2026 12:23:11 -0700 (PDT) Received: from ?IPV6:2a00:79e0:2e7c:8:5cd3:e624:64db:3649? ([2a00:79e0:2e7c:8:5cd3:e624:64db:3649]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e539fa244csm28207739eec.2.2026.04.23.12.23.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 12:23:10 -0700 (PDT) Message-ID: <0643586e-e665-4592-b941-2868fca84322@google.com> Date: Thu, 23 Apr 2026 12:23:09 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: typec: tcpm: replace strcpy with strscpy To: Maxwell Doose , badhri@google.com, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260419213638.38291-2-m32285159@gmail.com> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: <20260419213638.38291-2-m32285159@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Maxwell, On 4/19/26 2:36 PM, Maxwell Doose wrote: > The function strcpy() is deprecated as it can be used in buffer overflow > attacks. This patch replaces strcpy() with strscpy() to improve > security and stability. > > Signed-off-by: Maxwell Doose > --- > drivers/usb/typec/tcpm/tcpm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 8e0e14a2704e..69574c5e79e1 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -725,7 +725,7 @@ static void _tcpm_log(struct tcpm_port *port, const char *fmt, va_list args) > > if (tcpm_log_full(port)) { > port->logbuffer_head = max(port->logbuffer_head - 1, 0); > - strcpy(tmpbuffer, "overflow"); > + strscpy(tmpbuffer, "overflow", sizeof(tmpbuffer)) > } > > if (port->logbuffer_head < 0 || > @@ -841,10 +841,10 @@ static void tcpm_log_source_caps(struct tcpm_port *port) > pdo_spr_avs_apdo_15v_to_20v_max_current_ma(pdo), > pdo_spr_avs_apdo_src_peak_current(pdo)); > else > - strcpy(msg, "undefined APDO"); > + strscpy(msg, "undefined APDO", sizeof(msg)); > break; > default: > - strcpy(msg, "undefined"); > + strscpy(msg, "undefined", sizeof(msg)); > break; > } > tcpm_log(port, " PDO %d: type %d, %s", This has already been fixed as part of [1]. [1] https://patch.msgid.link/20260310094434.3639602-5-aichao@kylinos.cn BR, Amit