* [RFC PATCH] usb: reduce kernel log spam on driver registration @ 2022-08-25 17:03 ` Ard Biesheuvel 2022-08-25 17:23 ` Alim Akhtar ` (3 more replies) 0 siblings, 4 replies; 8+ messages in thread From: Ard Biesheuvel @ 2022-08-25 17:03 UTC (permalink / raw) To: linux-kernel Cc: Ard Biesheuvel, Alan Stern, Greg Kroah-Hartman, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, Krzysztof Kozlowski, Alim Akhtar, Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair, Patrice Chotard, Vladimir Zapolskiy, linux-usb, linux-arm-kernel, linux-samsung-soc, linux-omap Drivers are typically supposed to be quiet unless they are actually probed, but for some reason, USB host controllers seem to be exempt from this rule, and happily broadcast their existence into the kernel log at boot even if the hardware in question is nowhere to be found. Let's fix that, and remove these pr_info() calls. Cc: Alan Stern <stern@rowland.harvard.edu> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Nicolas Ferre <nicolas.ferre@microchip.com> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Claudiu Beznea <claudiu.beznea@microchip.com> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Alim Akhtar <alim.akhtar@samsung.com> Cc: Avi Fishman <avifishman70@gmail.com> Cc: Tomer Maimon <tmaimon77@gmail.com> Cc: Tali Perry <tali.perry1@gmail.com> Cc: Patrick Venture <venture@google.com> Cc: Nancy Yuen <yuenn@google.com> Cc: Benjamin Fair <benjaminfair@google.com> Cc: Patrice Chotard <patrice.chotard@foss.st.com> Cc: Vladimir Zapolskiy <vz@mleia.com> Cc: linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-omap@vger.kernel.org Signed-off-by: Ard Biesheuvel <ardb@kernel.org> --- drivers/usb/host/ehci-atmel.c | 1 - drivers/usb/host/ehci-exynos.c | 1 - drivers/usb/host/ehci-fsl.c | 2 -- drivers/usb/host/ehci-hcd.c | 1 - drivers/usb/host/ehci-npcm7xx.c | 2 -- drivers/usb/host/ehci-omap.c | 2 -- drivers/usb/host/ehci-orion.c | 2 -- drivers/usb/host/ehci-pci.c | 2 -- drivers/usb/host/ehci-platform.c | 2 -- drivers/usb/host/ehci-spear.c | 2 -- drivers/usb/host/ehci-st.c | 2 -- drivers/usb/host/fotg210-hcd.c | 1 - drivers/usb/host/ohci-at91.c | 1 - drivers/usb/host/ohci-da8xx.c | 1 - drivers/usb/host/ohci-exynos.c | 1 - drivers/usb/host/ohci-hcd.c | 1 - drivers/usb/host/ohci-nxp.c | 2 -- drivers/usb/host/ohci-omap.c | 2 -- drivers/usb/host/ohci-pci.c | 2 -- drivers/usb/host/ohci-platform.c | 2 -- drivers/usb/host/ohci-pxa27x.c | 2 -- drivers/usb/host/ohci-s3c2410.c | 1 - drivers/usb/host/ohci-spear.c | 2 -- drivers/usb/host/ohci-st.c | 2 -- 24 files changed, 39 deletions(-) diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c index 05d41fd65f25..0e995019c1df 100644 --- a/drivers/usb/host/ehci-atmel.c +++ b/drivers/usb/host/ehci-atmel.c @@ -239,7 +239,6 @@ static int __init ehci_atmel_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); ehci_init_driver(&ehci_atmel_hc_driver, &ehci_atmel_drv_overrides); return platform_driver_register(&ehci_atmel_driver); } diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 1a9b7572e17f..a65e365e3a04 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -347,7 +347,6 @@ static int __init ehci_exynos_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); ehci_init_driver(&exynos_ehci_hc_driver, &exynos_overrides); return platform_driver_register(&exynos_ehci_driver); } diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index 896c0d107f72..9cea785934e5 100644 --- a/drivers/usb/host/ehci-fsl.c +++ b/drivers/usb/host/ehci-fsl.c @@ -722,8 +722,6 @@ static int __init ehci_fsl_init(void) if (usb_disabled()) return -ENODEV; - pr_info(DRV_NAME ": " DRIVER_DESC "\n"); - ehci_init_driver(&fsl_ehci_hc_driver, &ehci_fsl_overrides); fsl_ehci_hc_driver.product_desc = diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 684164fa9716..a1930db0da1c 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -1351,7 +1351,6 @@ static int __init ehci_hcd_init(void) if (usb_disabled()) return -ENODEV; - printk(KERN_INFO "%s: " DRIVER_DESC "\n", hcd_name); set_bit(USB_EHCI_LOADED, &usb_hcds_loaded); if (test_bit(USB_UHCI_LOADED, &usb_hcds_loaded) || test_bit(USB_OHCI_LOADED, &usb_hcds_loaded)) diff --git a/drivers/usb/host/ehci-npcm7xx.c b/drivers/usb/host/ehci-npcm7xx.c index 6b5a7a873e01..4321ac6b11cc 100644 --- a/drivers/usb/host/ehci-npcm7xx.c +++ b/drivers/usb/host/ehci-npcm7xx.c @@ -191,8 +191,6 @@ static int __init ehci_npcm7xx_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ehci_init_driver(&ehci_npcm7xx_hc_driver, NULL); return platform_driver_register(&npcm7xx_ehci_hcd_driver); } diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index 8c45bc17a580..7dd984722a7f 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c @@ -284,8 +284,6 @@ static int __init ehci_omap_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ehci_init_driver(&ehci_omap_hc_driver, &ehci_omap_overrides); return platform_driver_register(&ehci_hcd_omap_driver); } diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c index 3626758b3e2a..2c8b1e6f1fff 100644 --- a/drivers/usb/host/ehci-orion.c +++ b/drivers/usb/host/ehci-orion.c @@ -361,8 +361,6 @@ static int __init ehci_orion_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ehci_init_driver(&ehci_orion_hc_driver, &orion_overrides); return platform_driver_register(&ehci_orion_driver); } diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c index 9937c5a7efc2..9581952d999a 100644 --- a/drivers/usb/host/ehci-pci.c +++ b/drivers/usb/host/ehci-pci.c @@ -423,8 +423,6 @@ static int __init ehci_pci_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ehci_init_driver(&ehci_pci_hc_driver, &pci_overrides); /* Entries for the PCI suspend/resume callbacks are special */ diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c index 6924f0316e9a..50491eea9409 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c @@ -529,8 +529,6 @@ static int __init ehci_platform_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ehci_init_driver(&ehci_platform_hc_driver, &platform_overrides); return platform_driver_register(&ehci_platform_driver); } diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c index 3694e450a11a..13369289d9cc 100644 --- a/drivers/usb/host/ehci-spear.c +++ b/drivers/usb/host/ehci-spear.c @@ -167,8 +167,6 @@ static int __init ehci_spear_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ehci_init_driver(&ehci_spear_hc_driver, &spear_overrides); return platform_driver_register(&spear_ehci_hcd_driver); } diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c index f74433aac948..1086078133f8 100644 --- a/drivers/usb/host/ehci-st.c +++ b/drivers/usb/host/ehci-st.c @@ -346,8 +346,6 @@ static int __init ehci_platform_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ehci_init_driver(&ehci_platform_hc_driver, &platform_overrides); return platform_driver_register(&ehci_platform_driver); } diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index f8c111e08a0d..3d1dbcf4c073 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb/host/fotg210-hcd.c @@ -5692,7 +5692,6 @@ static int __init fotg210_hcd_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); set_bit(USB_EHCI_LOADED, &usb_hcds_loaded); if (test_bit(USB_UHCI_LOADED, &usb_hcds_loaded) || test_bit(USB_OHCI_LOADED, &usb_hcds_loaded)) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 98326465e2dc..adf0998f0299 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -699,7 +699,6 @@ static int __init ohci_at91_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); ohci_init_driver(&ohci_at91_hc_driver, &ohci_at91_drv_overrides); /* diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index 1371b0c249ec..d4818e8d652b 100644 --- a/drivers/usb/host/ohci-da8xx.c +++ b/drivers/usb/host/ohci-da8xx.c @@ -551,7 +551,6 @@ static int __init ohci_da8xx_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", DRV_NAME); ohci_init_driver(&ohci_da8xx_hc_driver, &da8xx_overrides); /* diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 5f5e8a64c8e2..a060be6ae274 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -310,7 +310,6 @@ static int __init ohci_exynos_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); ohci_init_driver(&exynos_ohci_hc_driver, &exynos_overrides); return platform_driver_register(&exynos_ohci_driver); } diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index c4c821c2288c..0457dd9f6c19 100644 --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c @@ -1276,7 +1276,6 @@ static int __init ohci_hcd_mod_init(void) if (usb_disabled()) return -ENODEV; - printk(KERN_INFO "%s: " DRIVER_DESC "\n", hcd_name); pr_debug ("%s: block sizes: ed %zd td %zd\n", hcd_name, sizeof (struct ed), sizeof (struct td)); set_bit(USB_OHCI_LOADED, &usb_hcds_loaded); diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c index 106a6bcefb08..5b32e683e367 100644 --- a/drivers/usb/host/ohci-nxp.c +++ b/drivers/usb/host/ohci-nxp.c @@ -275,8 +275,6 @@ static int __init ohci_nxp_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ohci_init_driver(&ohci_nxp_hc_driver, NULL); return platform_driver_register(&ohci_hcd_nxp_driver); } diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c index f5bc9c8bdc9a..cb29701df911 100644 --- a/drivers/usb/host/ohci-omap.c +++ b/drivers/usb/host/ohci-omap.c @@ -423,8 +423,6 @@ static int __init ohci_omap_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ohci_init_driver(&ohci_omap_hc_driver, &omap_overrides); return platform_driver_register(&ohci_hcd_omap_driver); } diff --git a/drivers/usb/host/ohci-pci.c b/drivers/usb/host/ohci-pci.c index 41efe927d8f3..a146b2d3ef0b 100644 --- a/drivers/usb/host/ohci-pci.c +++ b/drivers/usb/host/ohci-pci.c @@ -306,8 +306,6 @@ static int __init ohci_pci_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ohci_init_driver(&ohci_pci_hc_driver, &pci_overrides); #ifdef CONFIG_PM diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c index 0adae6265127..6d56b52966c7 100644 --- a/drivers/usb/host/ohci-platform.c +++ b/drivers/usb/host/ohci-platform.c @@ -346,8 +346,6 @@ static int __init ohci_platform_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ohci_init_driver(&ohci_platform_hc_driver, &platform_overrides); return platform_driver_register(&ohci_platform_driver); } diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c index ab4f610a0140..f2504b884e92 100644 --- a/drivers/usb/host/ohci-pxa27x.c +++ b/drivers/usb/host/ohci-pxa27x.c @@ -608,8 +608,6 @@ static int __init ohci_pxa27x_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ohci_init_driver(&ohci_pxa27x_hc_driver, &pxa27x_overrides); ohci_pxa27x_hc_driver.hub_control = pxa27x_ohci_hub_control; diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb/host/ohci-s3c2410.c index 12264c048601..7207c7a3cf49 100644 --- a/drivers/usb/host/ohci-s3c2410.c +++ b/drivers/usb/host/ohci-s3c2410.c @@ -474,7 +474,6 @@ static int __init ohci_s3c2410_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); ohci_init_driver(&ohci_s3c2410_hc_driver, NULL); /* diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c index 9b81f420656d..71a3f18fe1be 100644 --- a/drivers/usb/host/ohci-spear.c +++ b/drivers/usb/host/ohci-spear.c @@ -179,8 +179,6 @@ static int __init ohci_spear_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ohci_init_driver(&ohci_spear_hc_driver, &spear_overrides); return platform_driver_register(&spear_ohci_hcd_driver); } diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c index ac796ccd93ef..2e542a344aae 100644 --- a/drivers/usb/host/ohci-st.c +++ b/drivers/usb/host/ohci-st.c @@ -324,8 +324,6 @@ static int __init ohci_platform_init(void) if (usb_disabled()) return -ENODEV; - pr_info("%s: " DRIVER_DESC "\n", hcd_name); - ohci_init_driver(&ohci_platform_hc_driver, &platform_overrides); return platform_driver_register(&ohci_platform_driver); } -- 2.35.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [RFC PATCH] usb: reduce kernel log spam on driver registration 2022-08-25 17:03 ` [RFC PATCH] usb: reduce kernel log spam on driver registration Ard Biesheuvel @ 2022-08-25 17:23 ` Alim Akhtar 2022-08-25 18:10 ` Russell King (Oracle) 2022-08-25 19:11 ` Alan Stern ` (2 subsequent siblings) 3 siblings, 1 reply; 8+ messages in thread From: Alim Akhtar @ 2022-08-25 17:23 UTC (permalink / raw) To: 'Ard Biesheuvel', linux-kernel Cc: 'Alan Stern', 'Greg Kroah-Hartman', 'Nicolas Ferre', 'Alexandre Belloni', 'Claudiu Beznea', 'Krzysztof Kozlowski', 'Avi Fishman', 'Tomer Maimon', 'Tali Perry', 'Patrick Venture', 'Nancy Yuen', 'Benjamin Fair', 'Patrice Chotard', 'Vladimir Zapolskiy', linux-usb, linux-arm-kernel, linux-samsung-soc, linux-omap >-----Original Message----- >From: Ard Biesheuvel [mailto:ardb@kernel.org] >Sent: Thursday, August 25, 2022 10:33 PM >To: linux-kernel@vger.kernel.org >Cc: Ard Biesheuvel <ardb@kernel.org>; Alan Stern ><stern@rowland.harvard.edu>; Greg Kroah-Hartman ><gregkh@linuxfoundation.org>; Nicolas Ferre ><nicolas.ferre@microchip.com>; Alexandre Belloni ><alexandre.belloni@bootlin.com>; Claudiu Beznea ><claudiu.beznea@microchip.com>; Krzysztof Kozlowski ><krzysztof.kozlowski@linaro.org>; Alim Akhtar <alim.akhtar@samsung.com>; >Avi Fishman <avifishman70@gmail.com>; Tomer Maimon ><tmaimon77@gmail.com>; Tali Perry <tali.perry1@gmail.com>; Patrick >Venture <venture@google.com>; Nancy Yuen <yuenn@google.com>; >Benjamin Fair <benjaminfair@google.com>; Patrice Chotard ><patrice.chotard@foss.st.com>; Vladimir Zapolskiy <vz@mleia.com>; linux- >usb@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- >soc@vger.kernel.org; linux-omap@vger.kernel.org >Subject: [RFC PATCH] usb: reduce kernel log spam on driver registration > >Drivers are typically supposed to be quiet unless they are actually probed, but >for some reason, USB host controllers seem to be exempt from this rule, and >happily broadcast their existence into the kernel log at boot even if the >hardware in question is nowhere to be found. > >Let's fix that, and remove these pr_info() calls. > How about just change pr_info() to pr_debug() instead? >Cc: Alan Stern <stern@rowland.harvard.edu> >Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >Cc: Nicolas Ferre <nicolas.ferre@microchip.com> >Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> >Cc: Claudiu Beznea <claudiu.beznea@microchip.com> >Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >Cc: Alim Akhtar <alim.akhtar@samsung.com> >Cc: Avi Fishman <avifishman70@gmail.com> >Cc: Tomer Maimon <tmaimon77@gmail.com> >Cc: Tali Perry <tali.perry1@gmail.com> >Cc: Patrick Venture <venture@google.com> >Cc: Nancy Yuen <yuenn@google.com> >Cc: Benjamin Fair <benjaminfair@google.com> >Cc: Patrice Chotard <patrice.chotard@foss.st.com> >Cc: Vladimir Zapolskiy <vz@mleia.com> >Cc: linux-usb@vger.kernel.org >Cc: linux-arm-kernel@lists.infradead.org >Cc: linux-kernel@vger.kernel.org >Cc: linux-samsung-soc@vger.kernel.org >Cc: linux-omap@vger.kernel.org >Signed-off-by: Ard Biesheuvel <ardb@kernel.org> >--- > drivers/usb/host/ehci-atmel.c | 1 - > drivers/usb/host/ehci-exynos.c | 1 - > drivers/usb/host/ehci-fsl.c | 2 -- > drivers/usb/host/ehci-hcd.c | 1 - > drivers/usb/host/ehci-npcm7xx.c | 2 -- > drivers/usb/host/ehci-omap.c | 2 -- > drivers/usb/host/ehci-orion.c | 2 -- > drivers/usb/host/ehci-pci.c | 2 -- > drivers/usb/host/ehci-platform.c | 2 -- > drivers/usb/host/ehci-spear.c | 2 -- > drivers/usb/host/ehci-st.c | 2 -- > drivers/usb/host/fotg210-hcd.c | 1 - > drivers/usb/host/ohci-at91.c | 1 - > drivers/usb/host/ohci-da8xx.c | 1 - > drivers/usb/host/ohci-exynos.c | 1 - > drivers/usb/host/ohci-hcd.c | 1 - > drivers/usb/host/ohci-nxp.c | 2 -- > drivers/usb/host/ohci-omap.c | 2 -- > drivers/usb/host/ohci-pci.c | 2 -- > drivers/usb/host/ohci-platform.c | 2 -- > drivers/usb/host/ohci-pxa27x.c | 2 -- > drivers/usb/host/ohci-s3c2410.c | 1 - > drivers/usb/host/ohci-spear.c | 2 -- > drivers/usb/host/ohci-st.c | 2 -- > 24 files changed, 39 deletions(-) > >diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c >index 05d41fd65f25..0e995019c1df 100644 >--- a/drivers/usb/host/ehci-atmel.c >+++ b/drivers/usb/host/ehci-atmel.c >@@ -239,7 +239,6 @@ static int __init ehci_atmel_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); > ehci_init_driver(&ehci_atmel_hc_driver, >&ehci_atmel_drv_overrides); > return platform_driver_register(&ehci_atmel_driver); > } >diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c >index 1a9b7572e17f..a65e365e3a04 100644 >--- a/drivers/usb/host/ehci-exynos.c >+++ b/drivers/usb/host/ehci-exynos.c >@@ -347,7 +347,6 @@ static int __init ehci_exynos_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); > ehci_init_driver(&exynos_ehci_hc_driver, &exynos_overrides); > return platform_driver_register(&exynos_ehci_driver); > } >diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index >896c0d107f72..9cea785934e5 100644 >--- a/drivers/usb/host/ehci-fsl.c >+++ b/drivers/usb/host/ehci-fsl.c >@@ -722,8 +722,6 @@ static int __init ehci_fsl_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info(DRV_NAME ": " DRIVER_DESC "\n"); >- > ehci_init_driver(&fsl_ehci_hc_driver, &ehci_fsl_overrides); > > fsl_ehci_hc_driver.product_desc = >diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index >684164fa9716..a1930db0da1c 100644 >--- a/drivers/usb/host/ehci-hcd.c >+++ b/drivers/usb/host/ehci-hcd.c >@@ -1351,7 +1351,6 @@ static int __init ehci_hcd_init(void) > if (usb_disabled()) > return -ENODEV; > >- printk(KERN_INFO "%s: " DRIVER_DESC "\n", hcd_name); > set_bit(USB_EHCI_LOADED, &usb_hcds_loaded); > if (test_bit(USB_UHCI_LOADED, &usb_hcds_loaded) || > test_bit(USB_OHCI_LOADED, &usb_hcds_loaded)) >diff --git a/drivers/usb/host/ehci-npcm7xx.c b/drivers/usb/host/ehci- >npcm7xx.c index 6b5a7a873e01..4321ac6b11cc 100644 >--- a/drivers/usb/host/ehci-npcm7xx.c >+++ b/drivers/usb/host/ehci-npcm7xx.c >@@ -191,8 +191,6 @@ static int __init ehci_npcm7xx_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ehci_init_driver(&ehci_npcm7xx_hc_driver, NULL); > return platform_driver_register(&npcm7xx_ehci_hcd_driver); > } >diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c >index 8c45bc17a580..7dd984722a7f 100644 >--- a/drivers/usb/host/ehci-omap.c >+++ b/drivers/usb/host/ehci-omap.c >@@ -284,8 +284,6 @@ static int __init ehci_omap_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ehci_init_driver(&ehci_omap_hc_driver, &ehci_omap_overrides); > return platform_driver_register(&ehci_hcd_omap_driver); > } >diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c >index 3626758b3e2a..2c8b1e6f1fff 100644 >--- a/drivers/usb/host/ehci-orion.c >+++ b/drivers/usb/host/ehci-orion.c >@@ -361,8 +361,6 @@ static int __init ehci_orion_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ehci_init_driver(&ehci_orion_hc_driver, &orion_overrides); > return platform_driver_register(&ehci_orion_driver); > } >diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c index >9937c5a7efc2..9581952d999a 100644 >--- a/drivers/usb/host/ehci-pci.c >+++ b/drivers/usb/host/ehci-pci.c >@@ -423,8 +423,6 @@ static int __init ehci_pci_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ehci_init_driver(&ehci_pci_hc_driver, &pci_overrides); > > /* Entries for the PCI suspend/resume callbacks are special */ diff --git >a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c >index 6924f0316e9a..50491eea9409 100644 >--- a/drivers/usb/host/ehci-platform.c >+++ b/drivers/usb/host/ehci-platform.c >@@ -529,8 +529,6 @@ static int __init ehci_platform_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ehci_init_driver(&ehci_platform_hc_driver, &platform_overrides); > return platform_driver_register(&ehci_platform_driver); > } >diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c >index 3694e450a11a..13369289d9cc 100644 >--- a/drivers/usb/host/ehci-spear.c >+++ b/drivers/usb/host/ehci-spear.c >@@ -167,8 +167,6 @@ static int __init ehci_spear_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ehci_init_driver(&ehci_spear_hc_driver, &spear_overrides); > return platform_driver_register(&spear_ehci_hcd_driver); > } >diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c index >f74433aac948..1086078133f8 100644 >--- a/drivers/usb/host/ehci-st.c >+++ b/drivers/usb/host/ehci-st.c >@@ -346,8 +346,6 @@ static int __init ehci_platform_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ehci_init_driver(&ehci_platform_hc_driver, &platform_overrides); > return platform_driver_register(&ehci_platform_driver); > } >diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c >index f8c111e08a0d..3d1dbcf4c073 100644 >--- a/drivers/usb/host/fotg210-hcd.c >+++ b/drivers/usb/host/fotg210-hcd.c >@@ -5692,7 +5692,6 @@ static int __init fotg210_hcd_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); > set_bit(USB_EHCI_LOADED, &usb_hcds_loaded); > if (test_bit(USB_UHCI_LOADED, &usb_hcds_loaded) || > test_bit(USB_OHCI_LOADED, &usb_hcds_loaded)) >diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index >98326465e2dc..adf0998f0299 100644 >--- a/drivers/usb/host/ohci-at91.c >+++ b/drivers/usb/host/ohci-at91.c >@@ -699,7 +699,6 @@ static int __init ohci_at91_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); > ohci_init_driver(&ohci_at91_hc_driver, &ohci_at91_drv_overrides); > > /* >diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c >index 1371b0c249ec..d4818e8d652b 100644 >--- a/drivers/usb/host/ohci-da8xx.c >+++ b/drivers/usb/host/ohci-da8xx.c >@@ -551,7 +551,6 @@ static int __init ohci_da8xx_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", DRV_NAME); > ohci_init_driver(&ohci_da8xx_hc_driver, &da8xx_overrides); > > /* >diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c >index 5f5e8a64c8e2..a060be6ae274 100644 >--- a/drivers/usb/host/ohci-exynos.c >+++ b/drivers/usb/host/ohci-exynos.c >@@ -310,7 +310,6 @@ static int __init ohci_exynos_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); > ohci_init_driver(&exynos_ohci_hc_driver, &exynos_overrides); > return platform_driver_register(&exynos_ohci_driver); > } >diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index >c4c821c2288c..0457dd9f6c19 100644 >--- a/drivers/usb/host/ohci-hcd.c >+++ b/drivers/usb/host/ohci-hcd.c >@@ -1276,7 +1276,6 @@ static int __init ohci_hcd_mod_init(void) > if (usb_disabled()) > return -ENODEV; > >- printk(KERN_INFO "%s: " DRIVER_DESC "\n", hcd_name); > pr_debug ("%s: block sizes: ed %zd td %zd\n", hcd_name, > sizeof (struct ed), sizeof (struct td)); > set_bit(USB_OHCI_LOADED, &usb_hcds_loaded); diff --git >a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c index >106a6bcefb08..5b32e683e367 100644 >--- a/drivers/usb/host/ohci-nxp.c >+++ b/drivers/usb/host/ohci-nxp.c >@@ -275,8 +275,6 @@ static int __init ohci_nxp_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ohci_init_driver(&ohci_nxp_hc_driver, NULL); > return platform_driver_register(&ohci_hcd_nxp_driver); > } >diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c >index f5bc9c8bdc9a..cb29701df911 100644 >--- a/drivers/usb/host/ohci-omap.c >+++ b/drivers/usb/host/ohci-omap.c >@@ -423,8 +423,6 @@ static int __init ohci_omap_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ohci_init_driver(&ohci_omap_hc_driver, &omap_overrides); > return platform_driver_register(&ohci_hcd_omap_driver); > } >diff --git a/drivers/usb/host/ohci-pci.c b/drivers/usb/host/ohci-pci.c index >41efe927d8f3..a146b2d3ef0b 100644 >--- a/drivers/usb/host/ohci-pci.c >+++ b/drivers/usb/host/ohci-pci.c >@@ -306,8 +306,6 @@ static int __init ohci_pci_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ohci_init_driver(&ohci_pci_hc_driver, &pci_overrides); > > #ifdef CONFIG_PM >diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci- >platform.c >index 0adae6265127..6d56b52966c7 100644 >--- a/drivers/usb/host/ohci-platform.c >+++ b/drivers/usb/host/ohci-platform.c >@@ -346,8 +346,6 @@ static int __init ohci_platform_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ohci_init_driver(&ohci_platform_hc_driver, &platform_overrides); > return platform_driver_register(&ohci_platform_driver); > } >diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c >index ab4f610a0140..f2504b884e92 100644 >--- a/drivers/usb/host/ohci-pxa27x.c >+++ b/drivers/usb/host/ohci-pxa27x.c >@@ -608,8 +608,6 @@ static int __init ohci_pxa27x_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ohci_init_driver(&ohci_pxa27x_hc_driver, &pxa27x_overrides); > ohci_pxa27x_hc_driver.hub_control = pxa27x_ohci_hub_control; > >diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb/host/ohci-s3c2410.c >index 12264c048601..7207c7a3cf49 100644 >--- a/drivers/usb/host/ohci-s3c2410.c >+++ b/drivers/usb/host/ohci-s3c2410.c >@@ -474,7 +474,6 @@ static int __init ohci_s3c2410_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); > ohci_init_driver(&ohci_s3c2410_hc_driver, NULL); > > /* >diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c >index 9b81f420656d..71a3f18fe1be 100644 >--- a/drivers/usb/host/ohci-spear.c >+++ b/drivers/usb/host/ohci-spear.c >@@ -179,8 +179,6 @@ static int __init ohci_spear_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ohci_init_driver(&ohci_spear_hc_driver, &spear_overrides); > return platform_driver_register(&spear_ohci_hcd_driver); > } >diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c index >ac796ccd93ef..2e542a344aae 100644 >--- a/drivers/usb/host/ohci-st.c >+++ b/drivers/usb/host/ohci-st.c >@@ -324,8 +324,6 @@ static int __init ohci_platform_init(void) > if (usb_disabled()) > return -ENODEV; > >- pr_info("%s: " DRIVER_DESC "\n", hcd_name); >- > ohci_init_driver(&ohci_platform_hc_driver, &platform_overrides); > return platform_driver_register(&ohci_platform_driver); > } >-- >2.35.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] usb: reduce kernel log spam on driver registration 2022-08-25 17:23 ` Alim Akhtar @ 2022-08-25 18:10 ` Russell King (Oracle) 2022-08-25 22:13 ` Elliott, Robert (Servers) 2022-08-26 4:01 ` Alim Akhtar 0 siblings, 2 replies; 8+ messages in thread From: Russell King (Oracle) @ 2022-08-25 18:10 UTC (permalink / raw) To: Alim Akhtar Cc: 'Ard Biesheuvel', linux-kernel, 'Alexandre Belloni', linux-samsung-soc, 'Tomer Maimon', linux-omap, 'Avi Fishman', 'Greg Kroah-Hartman', linux-usb, 'Tali Perry', 'Nancy Yuen', 'Krzysztof Kozlowski', 'Alan Stern', 'Patrice Chotard', 'Patrick Venture', 'Vladimir Zapolskiy', 'Claudiu Beznea', linux-arm-kernel, 'Benjamin Fair' On Thu, Aug 25, 2022 at 10:53:44PM +0530, Alim Akhtar wrote: > >Drivers are typically supposed to be quiet unless they are actually probed, > but > >for some reason, USB host controllers seem to be exempt from this rule, and > >happily broadcast their existence into the kernel log at boot even if the > >hardware in question is nowhere to be found. > > > >Let's fix that, and remove these pr_info() calls. > > > How about just change pr_info() to pr_debug() instead? Do the messages serve a useful purpose that the initcall_debug kernel parameter (that doesn't require #define DEBUG to be set while compiling and thus can be used with any kernel) doesn't provide? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RFC PATCH] usb: reduce kernel log spam on driver registration 2022-08-25 18:10 ` Russell King (Oracle) @ 2022-08-25 22:13 ` Elliott, Robert (Servers) 2022-08-26 4:01 ` Alim Akhtar 1 sibling, 0 replies; 8+ messages in thread From: Elliott, Robert (Servers) @ 2022-08-25 22:13 UTC (permalink / raw) To: Russell King, Alim Akhtar Cc: 'Ard Biesheuvel', linux-kernel@vger.kernel.org, 'Alexandre Belloni', linux-samsung-soc@vger.kernel.org, 'Tomer Maimon', linux-omap@vger.kernel.org, 'Avi Fishman', 'Greg Kroah-Hartman', linux-usb@vger.kernel.org, 'Tali Perry', 'Nancy Yuen', 'Krzysztof Kozlowski', 'Alan Stern', 'Patrice Chotard', 'Patrick Venture', 'Vladimir Zapolskiy', 'Claudiu Beznea', linux-arm-kernel@lists.infradead.org, 'Benjamin Fair' > -----Original Message----- > From: Russell King <linux@armlinux.org.uk> > Sent: Thursday, August 25, 2022 1:10 PM > To: Alim Akhtar <alim.akhtar@samsung.com> > Subject: Re: [RFC PATCH] usb: reduce kernel log spam on driver registration > > On Thu, Aug 25, 2022 at 10:53:44PM +0530, Alim Akhtar wrote: ... > > Ard: > > >Drivers are typically supposed to be quiet unless they are actually > > >probed, but for some reason, USB host controllers seem to be exempt > > >from this rule, and happily broadcast their existence into the kernel > > >log at boot even if the hardware in question is nowhere to be found. > > > > > >Let's fix that, and remove these pr_info() calls. > > > > > How about just change pr_info() to pr_debug() instead? > > Do the messages serve a useful purpose that the initcall_debug kernel > parameter (that doesn't require #define DEBUG to be set while compiling > and thus can be used with any kernel) doesn't provide? Some code uses "printk(KERN DEBUG" to avoid pr_debug's complexity when CONFIG_DYNAMIC_DEBUG is enabled (requiring adding strings like echi_hcd.dyndbg on the kernel command line). You can preserve the pr_fmt, if any, like this: printk(KERN_DEBUG pr_fmt("message\n", args )); However, I agree with Ard's suggestion to drop these module loading prints altogether. These modules do print more lines if they find hardware. Example with ehci and xhci finding hardware but ohci and uhci not finding hardware: [ 20.568240] calling ehci_hcd_init+0x0/0xe2 @ 1 [ 20.568242] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver [ 20.574810] initcall ehci_hcd_init+0x0/0xe2 returned 0 after 6568 usecs Patch removes that Driver line. [ 20.574811] calling ehci_pci_init+0x0/0x69 @ 1 [ 20.574813] ehci-pci: EHCI PCI platform driver [ 20.579544] ehci-pci 0000:01:00.4: EHCI Host Controller [ 20.584867] ehci-pci 0000:01:00.4: new USB bus registered, assigned bus number 1 [ 20.592356] ehci-pci 0000:01:00.4: irq 58, io mem 0xd9b9c000 [ 20.604560] ehci-pci 0000:01:00.4: USB 2.0 started, EHCI 1.00 [ 20.618684] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 20.625947] usb usb1: Product: EHCI Host Controller [ 20.630849] usb usb1: Manufacturer: Linux 6.0.0-rc1+ ehci_hcd [ 20.636626] usb usb1: SerialNumber: 0000:01:00.4 [ 20.641367] hub 1-0:1.0: USB hub found [ 20.645143] hub 1-0:1.0: 8 ports detected [ 20.649429] initcall ehci_pci_init+0x0/0x69 returned 0 after 74616 usecs Patch removes that "platform driver" line. [ 20.649433] calling ohci_hcd_mod_init+0x0/0x7c @ 1 [ 20.649435] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver [ 20.655659] initcall ohci_hcd_mod_init+0x0/0x7c returned 0 after 6223 usecs Patch removes that Driver line. [ 20.655661] calling ohci_pci_init+0x0/0x69 @ 1 [ 20.655662] ohci-pci: OHCI PCI platform driver [ 20.660155] initcall ohci_pci_init+0x0/0x69 returned 0 after 4492 usecs Patch removes that Driver line. [ 20.660157] calling uhci_hcd_init+0x0/0x10a @ 1 [ 20.660158] uhci_hcd: USB Universal Host Controller Interface driver [ 20.666589] initcall uhci_hcd_init+0x0/0x10a returned 0 after 6431 usecs The patch is missing that uhci_hcd driver line. printk(KERN_INFO "uhci_hcd: " DRIVER_DESC "%s\n", ignore_oc ? ", overcurrent ignored" : ""); That does sometimes print one of its module parameter values, but I don't know if that deserves an exception. [ 20.666591] calling xhci_hcd_init+0x0/0x28 @ 1 [ 20.666595] initcall xhci_hcd_init+0x0/0x28 returned 0 after 2 usecs [ 20.666596] calling xhci_pci_init+0x0/0x4e @ 1 [ 20.666711] xhci_hcd 0000:00:14.0: xHCI Host Controller [ 20.672050] xhci_hcd 0000:00:14.0: new USB bus registered, assigned bus number 2 [ 20.680584] xhci_hcd 0000:00:14.0: hcc params 0x200077c1 hci version 0x100 quirks 0x0000000000009810 [ 20.689996] xhci_hcd 0000:00:14.0: xHCI Host Controller [ 20.695319] xhci_hcd 0000:00:14.0: new USB bus registered, assigned bus number 3 [ 20.702759] xhci_hcd 0000:00:14.0: Host supports USB 3.0 SuperSpeed [ 20.729559] usb usb2: Manufacturer: Linux 6.0.0-rc1+ xhci-hcd [ 20.768845] usb usb3: Manufacturer: Linux 6.0.0-rc1+ xhci-hcd [ 20.787580] initcall xhci_pci_init+0x0/0x4e returned 0 after 120982 usecs The xhci modules already don't have those prints. The patch is also missing u132_hcd_init: printk(KERN_INFO "driver %s\n", hcd_name); ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [RFC PATCH] usb: reduce kernel log spam on driver registration 2022-08-25 18:10 ` Russell King (Oracle) 2022-08-25 22:13 ` Elliott, Robert (Servers) @ 2022-08-26 4:01 ` Alim Akhtar 1 sibling, 0 replies; 8+ messages in thread From: Alim Akhtar @ 2022-08-26 4:01 UTC (permalink / raw) To: 'Russell King (Oracle)' Cc: 'Ard Biesheuvel', linux-kernel, 'Alexandre Belloni', linux-samsung-soc, 'Tomer Maimon', linux-omap, 'Avi Fishman', 'Greg Kroah-Hartman', linux-usb, 'Tali Perry', 'Nancy Yuen', 'Krzysztof Kozlowski', 'Alan Stern', 'Patrice Chotard', 'Patrick Venture', 'Vladimir Zapolskiy', 'Claudiu Beznea', linux-arm-kernel, 'Benjamin Fair' >-----Original Message----- >From: Russell King (Oracle) [mailto:linux@armlinux.org.uk] >Sent: Thursday, August 25, 2022 11:40 PM >To: Alim Akhtar <alim.akhtar@samsung.com> >Cc: 'Ard Biesheuvel' <ardb@kernel.org>; linux-kernel@vger.kernel.org; >'Alexandre Belloni' <alexandre.belloni@bootlin.com>; linux-samsung- >soc@vger.kernel.org; 'Tomer Maimon' <tmaimon77@gmail.com>; linux- >omap@vger.kernel.org; 'Avi Fishman' <avifishman70@gmail.com>; 'Greg >Kroah-Hartman' <gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org; >'Tali Perry' <tali.perry1@gmail.com>; 'Nancy Yuen' <yuenn@google.com>; >'Krzysztof Kozlowski' <krzysztof.kozlowski@linaro.org>; 'Alan Stern' ><stern@rowland.harvard.edu>; 'Patrice Chotard' ><patrice.chotard@foss.st.com>; 'Patrick Venture' <venture@google.com>; >'Vladimir Zapolskiy' <vz@mleia.com>; 'Claudiu Beznea' ><claudiu.beznea@microchip.com>; linux-arm-kernel@lists.infradead.org; >'Benjamin Fair' <benjaminfair@google.com> >Subject: Re: [RFC PATCH] usb: reduce kernel log spam on driver registration > >On Thu, Aug 25, 2022 at 10:53:44PM +0530, Alim Akhtar wrote: >> >Drivers are typically supposed to be quiet unless they are actually >> >probed, >> but >> >for some reason, USB host controllers seem to be exempt from this >> >rule, and happily broadcast their existence into the kernel log at >> >boot even if the hardware in question is nowhere to be found. >> > >> >Let's fix that, and remove these pr_info() calls. >> > >> How about just change pr_info() to pr_debug() instead? > >Do the messages serve a useful purpose that the initcall_debug kernel >parameter (that doesn't require #define DEBUG to be set while compiling and >thus can be used with any kernel) doesn't provide? > Ah, right, initcall_debug will do the job. So removing pr_info() from init call looks good. Thanks. Hi Ard Feel free to add Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> >-- >RMK's Patch system: https://protect2.fireeye.com/v1/url?k=3b37dc19- >5abcc93c-3b365756-74fe485cbff6-6a25f0b5c8476bae&q=1&e=752dac9b-cfef- >4919-8665- >8a220aac5d96&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2Fp >atches%2F >FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] usb: reduce kernel log spam on driver registration 2022-08-25 17:03 ` [RFC PATCH] usb: reduce kernel log spam on driver registration Ard Biesheuvel 2022-08-25 17:23 ` Alim Akhtar @ 2022-08-25 19:11 ` Alan Stern 2022-08-25 19:59 ` Rob Herring 2022-08-26 5:57 ` Krzysztof Kozlowski 3 siblings, 0 replies; 8+ messages in thread From: Alan Stern @ 2022-08-25 19:11 UTC (permalink / raw) To: Ard Biesheuvel Cc: linux-kernel, Greg Kroah-Hartman, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, Krzysztof Kozlowski, Alim Akhtar, Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair, Patrice Chotard, Vladimir Zapolskiy, linux-usb, linux-arm-kernel, linux-samsung-soc, linux-omap On Thu, Aug 25, 2022 at 07:03:27PM +0200, Ard Biesheuvel wrote: > Drivers are typically supposed to be quiet unless they are actually > probed, but for some reason, USB host controllers seem to be exempt from > this rule, and happily broadcast their existence into the kernel log at > boot even if the hardware in question is nowhere to be found. > > Let's fix that, and remove these pr_info() calls. > > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Alim Akhtar <alim.akhtar@samsung.com> > Cc: Avi Fishman <avifishman70@gmail.com> > Cc: Tomer Maimon <tmaimon77@gmail.com> > Cc: Tali Perry <tali.perry1@gmail.com> > Cc: Patrick Venture <venture@google.com> > Cc: Nancy Yuen <yuenn@google.com> > Cc: Benjamin Fair <benjaminfair@google.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: Vladimir Zapolskiy <vz@mleia.com> > Cc: linux-usb@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > --- Acked-by: Alan Stern <stern@rowland.harvard.edu> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] usb: reduce kernel log spam on driver registration 2022-08-25 17:03 ` [RFC PATCH] usb: reduce kernel log spam on driver registration Ard Biesheuvel 2022-08-25 17:23 ` Alim Akhtar 2022-08-25 19:11 ` Alan Stern @ 2022-08-25 19:59 ` Rob Herring 2022-08-26 5:57 ` Krzysztof Kozlowski 3 siblings, 0 replies; 8+ messages in thread From: Rob Herring @ 2022-08-25 19:59 UTC (permalink / raw) To: Ard Biesheuvel Cc: linux-kernel@vger.kernel.org, Alexandre Belloni, linux-samsung-soc, Vladimir Zapolskiy, Tomer Maimon, linux-omap, Avi Fishman, Greg Kroah-Hartman, Linux USB List, Nancy Yuen, Krzysztof Kozlowski, Alan Stern, Patrice Chotard, Alim Akhtar, Patrick Venture, Tali Perry, Claudiu Beznea, linux-arm-kernel, Benjamin Fair On Thu, Aug 25, 2022 at 12:04 PM Ard Biesheuvel <ardb@kernel.org> wrote: > > Drivers are typically supposed to be quiet unless they are actually > probed, but for some reason, USB host controllers seem to be exempt from > this rule, and happily broadcast their existence into the kernel log at > boot even if the hardware in question is nowhere to be found. > > Let's fix that, and remove these pr_info() calls. > > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Alim Akhtar <alim.akhtar@samsung.com> > Cc: Avi Fishman <avifishman70@gmail.com> > Cc: Tomer Maimon <tmaimon77@gmail.com> > Cc: Tali Perry <tali.perry1@gmail.com> > Cc: Patrick Venture <venture@google.com> > Cc: Nancy Yuen <yuenn@google.com> > Cc: Benjamin Fair <benjaminfair@google.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: Vladimir Zapolskiy <vz@mleia.com> > Cc: linux-usb@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > --- > drivers/usb/host/ehci-atmel.c | 1 - > drivers/usb/host/ehci-exynos.c | 1 - > drivers/usb/host/ehci-fsl.c | 2 -- > drivers/usb/host/ehci-hcd.c | 1 - > drivers/usb/host/ehci-npcm7xx.c | 2 -- > drivers/usb/host/ehci-omap.c | 2 -- > drivers/usb/host/ehci-orion.c | 2 -- > drivers/usb/host/ehci-pci.c | 2 -- > drivers/usb/host/ehci-platform.c | 2 -- > drivers/usb/host/ehci-spear.c | 2 -- > drivers/usb/host/ehci-st.c | 2 -- > drivers/usb/host/fotg210-hcd.c | 1 - > drivers/usb/host/ohci-at91.c | 1 - > drivers/usb/host/ohci-da8xx.c | 1 - > drivers/usb/host/ohci-exynos.c | 1 - > drivers/usb/host/ohci-hcd.c | 1 - > drivers/usb/host/ohci-nxp.c | 2 -- > drivers/usb/host/ohci-omap.c | 2 -- > drivers/usb/host/ohci-pci.c | 2 -- > drivers/usb/host/ohci-platform.c | 2 -- > drivers/usb/host/ohci-pxa27x.c | 2 -- > drivers/usb/host/ohci-s3c2410.c | 1 - > drivers/usb/host/ohci-spear.c | 2 -- > drivers/usb/host/ohci-st.c | 2 -- > 24 files changed, 39 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org> I've had the same patch sitting around since 3.15... Rob ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] usb: reduce kernel log spam on driver registration 2022-08-25 17:03 ` [RFC PATCH] usb: reduce kernel log spam on driver registration Ard Biesheuvel ` (2 preceding siblings ...) 2022-08-25 19:59 ` Rob Herring @ 2022-08-26 5:57 ` Krzysztof Kozlowski 3 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-08-26 5:57 UTC (permalink / raw) To: Ard Biesheuvel, linux-kernel Cc: Alan Stern, Greg Kroah-Hartman, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, Alim Akhtar, Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair, Patrice Chotard, Vladimir Zapolskiy, linux-usb, linux-arm-kernel, linux-samsung-soc, linux-omap On 25/08/2022 20:03, Ard Biesheuvel wrote: > Drivers are typically supposed to be quiet unless they are actually > probed, but for some reason, USB host controllers seem to be exempt from > this rule, and happily broadcast their existence into the kernel log at > boot even if the hardware in question is nowhere to be found. > > Let's fix that, and remove these pr_info() calls. > > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Alim Akhtar <alim.akhtar@samsung.com> > Cc: Avi Fishman <avifishman70@gmail.com> > Cc: Tomer Maimon <tmaimon77@gmail.com> > Cc: Tali Perry <tali.perry1@gmail.com> > Cc: Patrick Venture <venture@google.com> > Cc: Nancy Yuen <yuenn@google.com> > Cc: Benjamin Fair <benjaminfair@google.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: Vladimir Zapolskiy <vz@mleia.com> > Cc: linux-usb@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > --- > drivers/usb/host/ehci-atmel.c | 1 - > drivers/usb/host/ehci-exynos.c | 1 - > drivers/usb/host/ehci-fsl.c | 2 -- > drivers/usb/host/ehci-hcd.c | 1 - > drivers/usb/host/ehci-npcm7xx.c | 2 -- > drivers/usb/host/ehci-omap.c | 2 -- > drivers/usb/host/ehci-orion.c | 2 -- > drivers/usb/host/ehci-pci.c | 2 -- > drivers/usb/host/ehci-platform.c | 2 -- > drivers/usb/host/ehci-spear.c | 2 -- > drivers/usb/host/ehci-st.c | 2 -- > drivers/usb/host/fotg210-hcd.c | 1 - > drivers/usb/host/ohci-at91.c | 1 - > drivers/usb/host/ohci-da8xx.c | 1 - > drivers/usb/host/ohci-exynos.c | 1 - > drivers/usb/host/ohci-hcd.c | 1 - > drivers/usb/host/ohci-nxp.c | 2 -- > drivers/usb/host/ohci-omap.c | 2 -- > drivers/usb/host/ohci-pci.c | 2 -- > drivers/usb/host/ohci-platform.c | 2 -- > drivers/usb/host/ohci-pxa27x.c | 2 -- > drivers/usb/host/ohci-s3c2410.c | 1 - > drivers/usb/host/ohci-spear.c | 2 -- > drivers/usb/host/ohci-st.c | 2 -- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-08-26 5:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20220825170354epcas5p28a5f1a4b13507b5c40ca235560a6ba56@epcas5p2.samsung.com>
2022-08-25 17:03 ` [RFC PATCH] usb: reduce kernel log spam on driver registration Ard Biesheuvel
2022-08-25 17:23 ` Alim Akhtar
2022-08-25 18:10 ` Russell King (Oracle)
2022-08-25 22:13 ` Elliott, Robert (Servers)
2022-08-26 4:01 ` Alim Akhtar
2022-08-25 19:11 ` Alan Stern
2022-08-25 19:59 ` Rob Herring
2022-08-26 5:57 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox