From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
Marcelo Schmitt <marcelo.schmitt@analog.com>,
linux-iio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, jic23@kernel.org,
lars@metafoo.de, Michael.Hennerich@analog.com, corbet@lwn.net,
marcelo.schmitt1@gmail.com
Subject: Re: [PATCH v1 1/4] iio: adc: ad4000: Add support for SPI offload
Date: Sun, 16 Mar 2025 13:32:12 +0300 [thread overview]
Message-ID: <0658073a-059b-417a-aafc-c83651e922cf@stanley.mountain> (raw)
In-Reply-To: <301fc83a961c4a2ef2ac980d0baa83d9d89a88c5.1741970538.git.marcelo.schmitt@analog.com>
Hi Marcelo,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Marcelo-Schmitt/iio-adc-ad4000-Add-support-for-SPI-offload/20250315-012316
base: af94f401e26f686f7391ce79b38a6129417c22dc
patch link: https://lore.kernel.org/r/301fc83a961c4a2ef2ac980d0baa83d9d89a88c5.1741970538.git.marcelo.schmitt%40analog.com
patch subject: [PATCH v1 1/4] iio: adc: ad4000: Add support for SPI offload
config: parisc-randconfig-r072-20250316 (https://download.01.org/0day-ci/archive/20250316/202503161513.yeRBTxjg-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202503161513.yeRBTxjg-lkp@intel.com/
New smatch warnings:
drivers/iio/adc/ad4000.c:862 ad4000_spi_offload_setup() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +862 drivers/iio/adc/ad4000.c
e74205e82803041 Marcelo Schmitt 2025-03-14 846 static int ad4000_spi_offload_setup(struct iio_dev *indio_dev,
e74205e82803041 Marcelo Schmitt 2025-03-14 847 struct ad4000_state *st)
e74205e82803041 Marcelo Schmitt 2025-03-14 848 {
e74205e82803041 Marcelo Schmitt 2025-03-14 849 struct spi_device *spi = st->spi;
e74205e82803041 Marcelo Schmitt 2025-03-14 850 struct device *dev = &spi->dev;
e74205e82803041 Marcelo Schmitt 2025-03-14 851 struct dma_chan *rx_dma;
e74205e82803041 Marcelo Schmitt 2025-03-14 852 int ret;
e74205e82803041 Marcelo Schmitt 2025-03-14 853
e74205e82803041 Marcelo Schmitt 2025-03-14 854 st->offload_trigger = devm_spi_offload_trigger_get(dev, st->offload,
e74205e82803041 Marcelo Schmitt 2025-03-14 855 SPI_OFFLOAD_TRIGGER_PERIODIC);
e74205e82803041 Marcelo Schmitt 2025-03-14 856 if (IS_ERR(st->offload_trigger))
e74205e82803041 Marcelo Schmitt 2025-03-14 857 return dev_err_probe(dev, PTR_ERR(st->offload_trigger),
e74205e82803041 Marcelo Schmitt 2025-03-14 858 "Failed to get offload trigger\n");
e74205e82803041 Marcelo Schmitt 2025-03-14 859
e74205e82803041 Marcelo Schmitt 2025-03-14 860 ret = ad4000_set_sampling_freq(st, st->max_rate_hz);
e74205e82803041 Marcelo Schmitt 2025-03-14 861 if (ret)
e74205e82803041 Marcelo Schmitt 2025-03-14 @862 return dev_err_probe(dev, PTR_ERR(st->offload_trigger),
s/PTR_ERR(st->offload_trigger)/ret/
e74205e82803041 Marcelo Schmitt 2025-03-14 863 "Failed to set sampling frequency\n");
e74205e82803041 Marcelo Schmitt 2025-03-14 864
e74205e82803041 Marcelo Schmitt 2025-03-14 865 rx_dma = devm_spi_offload_rx_stream_request_dma_chan(dev, st->offload);
e74205e82803041 Marcelo Schmitt 2025-03-14 866 if (IS_ERR(rx_dma))
e74205e82803041 Marcelo Schmitt 2025-03-14 867 return dev_err_probe(dev, PTR_ERR(rx_dma),
e74205e82803041 Marcelo Schmitt 2025-03-14 868 "Failed to get offload RX DMA\n");
e74205e82803041 Marcelo Schmitt 2025-03-14 869
e74205e82803041 Marcelo Schmitt 2025-03-14 870 ret = devm_iio_dmaengine_buffer_setup_with_handle(dev, indio_dev, rx_dma,
e74205e82803041 Marcelo Schmitt 2025-03-14 871 IIO_BUFFER_DIRECTION_IN);
e74205e82803041 Marcelo Schmitt 2025-03-14 872 if (ret)
e74205e82803041 Marcelo Schmitt 2025-03-14 873 return dev_err_probe(dev, ret, "Failed to setup DMA buffer\n");
e74205e82803041 Marcelo Schmitt 2025-03-14 874
e74205e82803041 Marcelo Schmitt 2025-03-14 875 return 0;
e74205e82803041 Marcelo Schmitt 2025-03-14 876 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-03-16 10:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 17:17 [PATCH v1 0/4] iio: adc: ad4000: Add SPI offload support Marcelo Schmitt
2025-03-14 17:18 ` [PATCH v1 1/4] iio: adc: ad4000: Add support for SPI offload Marcelo Schmitt
2025-03-16 10:32 ` Dan Carpenter [this message]
2025-03-17 10:27 ` Jonathan Cameron
2025-03-17 15:31 ` Marcelo Schmitt
2025-03-17 15:46 ` David Lechner
2025-03-17 17:21 ` Marcelo Schmitt
2025-03-17 18:51 ` Jonathan Cameron
2025-03-14 17:18 ` [PATCH v1 2/4] Documentation: iio: ad4000: Add new supported parts Marcelo Schmitt
2025-03-14 17:19 ` [PATCH v1 3/4] Documentation: iio: ad4000: Add IIO Device characteristics section Marcelo Schmitt
2025-03-14 17:19 ` [PATCH v1 4/4] Documentation: iio: ad4000: Describe offload support Marcelo Schmitt
2025-03-17 10:30 ` Jonathan Cameron
2025-03-17 15:33 ` Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0658073a-059b-417a-aafc-c83651e922cf@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=Michael.Hennerich@analog.com \
--cc=corbet@lwn.net \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox