Re: [PATCH 1/6] dt-bindings: display: panel: Add another panel for RG35XX Plus (Rev6)

Krzysztof Kozlowski
2024-11-24T16:05:52Z

On 24/11/2024 17:01, Krzysztof Kozlowski wrote:
> On 24/11/2024 09:02, Hironori KIKUCHI wrote:
>> +++ b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-plus-rev6-panel.yaml
>> @@ -0,0 +1,60 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-plus-rev6-panel.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Anbernic RG35XX series (YLM-LBV0345001H-V2) 3.45" 640x480 24-bit IPS LCD panel
>> +
>> +maintainers:
>> + - Hironori KIKUCHI <kikuchan98@gmail.com>
>> +
>> +allOf:
>> + - $ref: panel-common.yaml#
>> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: anbernic,rg35xx-plus-rev6-panel
>
> Everything is the same here. Add new compatible to existing schema
> respecting compatibility (fallback) or not (no fallback).

BTW, isn't this v2? Where is the changelog and proper versioning of
patches? The changes against previous version are quite unexpected. You
removed specific compatibles and went with wildcard, so this needs
thorough explanation (why standard bindings rules do not apply here).

Anyway next version *will be v3*. Please start using b4 tool.

Best regards,
Krzysztof