Re: [PATCH 5/6] dt-bindings: display: panel: Add a panel for RG CubeXX

Krzysztof Kozlowski
2024-11-24T16:03:10Z

On 24/11/2024 09:02, Hironori KIKUCHI wrote:
> This is a display panel used in the Anbernic RG CubeXX, a handheld
> gaming device from Anbernic. It is 3.95 inches in size (diagonally)
> with a resolution of 720x720.
>
> Signed-off-by: Hironori KIKUCHI <kikuchan98@gmail.com>
> ---
> .../panel/anbernic,rgcubexx-panel.yaml | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/anbernic,rgcubexx-panel.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,rgcubexx-panel.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,rgcubexx-panel.yaml
> new file mode 100644
> index 00000000000..47c5174fad2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/anbernic,rgcubexx-panel.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/anbernic,rgcubexx-panel.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Anbernic RG CubeXX (YLM-LBN0395004H-V1) 3.95" 720x720 24-bit IPS LCD panel
> +
> +maintainers:
> + - Hironori KIKUCHI <kikuchan98@gmail.com>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + const: anbernic,rgcubexx-panel

Same comments, no wildcards, don't duplicate schemas. See how other
files are doing it.

Best regards,
Krzysztof