Re: [PATCH v2] iommu/vt-d: fix system hang on reboot -f

Ethan Zhao
2025-02-27T00:40:38Z

On 2/26/2025 9:04 PM, Jason Gunthorpe wrote:
> On Wed, Feb 26, 2025 at 01:55:28PM +0800, Ethan Zhao wrote:
>>> Provided the system does not respond to those events when this function
>>> is called, it's fine to remove the lock.
>> I agree.
> I think it is running the destruction of the iommu far too late in the
> process. IMHO it should be done after all the drivers have been
> shutdown, before the CPUs go single threaded.

Hmm... so far it is fine, the iommu_shutdown only has a little work to
do, disable the translation, the PMR disabling is just backward compatible,
was deprecated already. if we move it to one position where all CPUs are
cycling, we don't know what kind of user-land tasks left there (i.e. reboot -f
case), it would be hard to full-fill the requirement of Intel VT-d, no ongoing
transaction there on hardware when issue the translation disabling command.

Of course, once you have clear motivation to re-position it. we would like
to work on it.

Thanks,
Ethan

>
> Jason
>