From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Kukjin Kim'" <kgene.kim@samsung.com>,
"'Grant Likely'" <grant.likely@secretlab.ca>,
"'Tushar Behera'" <tushar.behera@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linaro-dev@lists.linaro.org, patches@linaro.org
Subject: RE: [PATCH] gpio/samsung: Move SoC specific codes within macro
Date: Wed, 12 Oct 2011 21:42:32 +0900 [thread overview]
Message-ID: <069501cc88dc$695fa400$3c1eec00$%kim@samsung.com> (raw)
In-Reply-To:
Kukjin Kim wrote:
>
> Grant Likely wrote:
> >
> > On Mon, Oct 03, 2011 at 08:59:19AM +0530, Tushar Behera wrote:
> > > In drivers/gpio/gpio-samsung.c, there are certain structures
> > > and functions which are not getting used if the particular
> > > CPU is not selected. These code segments are moved under CPU
> > > specific macros to remove compilation warnings.
> > >
> > > Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> >
> > Acked-by: Grant Likely <grant.likely@secretlab.ca>
> >
> When I applied, following error was happened with s5p64x0_defconfig.
Others, ok.
>
> ...
> Inconsistent kallsyms data
> This is a bug - please report about it
> Try make KALLSYMS_EXTRA_PASS=1 as a workaround
> make: *** [vmlinux] Error 1
>
> And it seems due to add condition around the 'static unsigned
> s3c24xx_gpio_getcfg_abank()'.
>
> I need to check it in detail and if any problems, let you know.
>
There is no above problem now in my -next. Applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2011-10-12 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 3:29 [PATCH] gpio/samsung: Move SoC specific codes within macro Tushar Behera
2011-10-04 18:38 ` Grant Likely
2011-10-05 1:20 ` Kukjin Kim
2011-10-12 12:42 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='069501cc88dc$695fa400$3c1eec00$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=grant.likely@secretlab.ca \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox