RE: [PATCH net-next v5 00/14] macb usrio/tsu patches

Jiawen Wu
2026-03-30T07:12:17Z

> Hello:
>
> This series was applied to netdev/net-next.git (main)
> by Jakub Kicinski <kuba@kernel.org>:
>
> On Wed, 25 Mar 2026 16:28:04 +0000 you wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> >
> > Hey folks,
> >
> > At the very least, it'd be good of the soc vendor folks could check
> > their platforms and see if their usrio stuff actually lines up with what
> > the driver currently calls "macb_default_usrio". Ours didn't and it was
> > a nasty surprise.
> >
> > [...]
>
> Here is the summary with links:
> - [net-next,v5,01/14] Revert "net: macb: Clean up the .usrio settings in macb_config instances"
> https://git.kernel.org/netdev/net-next/c/8ccf062c6770
> - [net-next,v5,02/14] net: macb: rename macb_default_usrio to at91_default_usrio as not all platforms have mii mode control in
> usrio
> https://git.kernel.org/netdev/net-next/c/a17871778ee2
> - [net-next,v5,03/14] net: macb: split USRIO_HAS_CLKEN capability in two
> https://git.kernel.org/netdev/net-next/c/039f185a0060
> - [net-next,v5,04/14] dt-bindings: net: cdns,macb: replace cdns,refclk-ext with cdns,refclk-source
> https://git.kernel.org/netdev/net-next/c/dfa36d7e860c
> - [net-next,v5,05/14] net: macb: rework usrio refclk selection code
> https://git.kernel.org/netdev/net-next/c/6c5b565d7d41
> - [net-next,v5,06/14] net: macb: np4 doesn't need a usrio pointer
> https://git.kernel.org/netdev/net-next/c/826cbe636e10
> - [net-next,v5,07/14] net: macb: add mpfs specific usrio configuration
> https://git.kernel.org/netdev/net-next/c/c711311d6ba3
> - [net-next,v5,08/14] net: macb: warn on pclk use as a tsu_clk fallback
> https://git.kernel.org/netdev/net-next/c/3fe13d858f83
> - [net-next,v5,09/14] net: macb: clean up tsu clk rate acquisition
> https://git.kernel.org/netdev/net-next/c/b698a1e397ab
> - [net-next,v5,10/14] dt-bindings: net: macb: add property indicating timer adjust mode
> https://git.kernel.org/netdev/net-next/c/09a6164a4f1d
> - [net-next,v5,11/14] net: macb: timer adjust mode is not supported
> https://git.kernel.org/netdev/net-next/c/41adda8764fd
> - [net-next,v5,12/14] net: macb: runtime detect MACB_CAPS_USRIO_DISABLED
> https://git.kernel.org/netdev/net-next/c/47c86c463612
> - [net-next,v5,13/14] net: macb: set MACB_CAPS_USRIO_DISABLED if no usrio config is provided
> https://git.kernel.org/netdev/net-next/c/32fc6a9f6e75
> - [net-next,v5,14/14] net: macb: drop usrio pointer on EyeQ5 config
> https://git.kernel.org/netdev/net-next/c/cd1082a96f9a
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html

Hi,

There are compilation errors after merging this patch set.
I believe the error occurred where the CONFIG_OF is not set.

root@w-MS-7E16:~/net-next# make C=1 W=1
CALL scripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC [M] drivers/net/ethernet/cadence/macb_main.o
drivers/net/ethernet/cadence/macb_main.c:5755:19: error: ‘at91_default_usrio’ undeclared here (not in a function)
5755 | .usrio = &at91_default_usrio,
| ^~~~~~~~~~~~~~~~~~
make[6]: *** [scripts/Makefile.build:289: drivers/net/ethernet/cadence/macb_main.o] Error 1
make[5]: *** [scripts/Makefile.build:548: drivers/net/ethernet/cadence] Error 2
make[4]: *** [scripts/Makefile.build:548: drivers/net/ethernet] Error 2
make[3]: *** [scripts/Makefile.build:548: drivers/net] Error 2
make[2]: *** [scripts/Makefile.build:548: drivers] Error 2
make[1]: *** [/root/net-next/Makefile:2105: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2