From: Stephen Boyd <sboyd@kernel.org>
To: Mohammad Rafi Shaik <quic_mohs@quicinc.com>,
agross@kernel.org, andersson@kernel.org, broonie@kernel.org,
konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
quic_plai@quicinc.com, quic_visr@quicinc.com, robh+dt@kernel.org,
swboyd@chromium.org
Cc: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Subject: Re: [PATCH v9 3/4] clk: qcom: lpassaudiocc-sc7280: Add required gdsc power domain clks in lpass_cc_sc7280_desc strcuture
Date: Fri, 17 Mar 2023 11:43:22 -0700 [thread overview]
Message-ID: <06cc8339e30eb38175e04058b69b41ca.sboyd@kernel.org> (raw)
In-Reply-To: <20230317141622.1926573-4-quic_mohs@quicinc.com>
Just remove strcuture from the subject.
Quoting Mohammad Rafi Shaik (2023-03-17 07:16:21)
> Add the gdsc's in lpass_cc_sc7280_desc strcuture,
s/strcuture/struct/
> When qcom,adsp-pil-mode is enabled, gdsc's required to solve
Just 'GDSCs', because gdsc isn't owning anything.
> dependencies in lpass_audiocc probe.
I think you're saying that we need to register the GDSCs when
qcom,adsp-pil-mode is set in the qcom,sc7280-lpassaoncc node. Otherwise,
we don't get any GDSCs provided by that node when we should always be
providing them.
>
> Fixes: 4ab43d171181 ("clk: qcom: Add lpass clock controller driver for SC7280")
If the above is right, then this fixes tag is wrong. It should really be
Fixes: 0cbcfbe50cbf ("clk: qcom: lpass: Handle the regmap overlap of lpasscc and lpass_aon")
right?
next prev parent reply other threads:[~2023-03-17 18:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 14:16 [PATCH v9 0/4] Add resets for ADSP based audio clock controller driver Mohammad Rafi Shaik
2023-03-17 14:16 ` [PATCH v9 1/4] dt-bindings: clock: qcom,sc7280-lpasscc: Add qcom,adsp-pil-mode property Mohammad Rafi Shaik
2023-03-17 14:16 ` [PATCH v9 2/4] clk: qcom: lpasscc-sc7280: Skip qdsp6ss clock registration Mohammad Rafi Shaik
2023-03-17 18:30 ` Stephen Boyd
2023-03-17 14:16 ` [PATCH v9 3/4] clk: qcom: lpassaudiocc-sc7280: Add required gdsc power domain clks in lpass_cc_sc7280_desc strcuture Mohammad Rafi Shaik
2023-03-17 18:43 ` Stephen Boyd [this message]
2023-03-20 5:46 ` Mohammad Rafi Shaik
2023-03-17 14:16 ` [PATCH v9 4/4] clk: qcom: lpassaudiocc-sc7280: Modify qcom_cc_probe to qcom_cc_probe_by_index Mohammad Rafi Shaik
2023-03-17 18:27 ` Stephen Boyd
2023-03-23 7:45 ` Mohammad Rafi Shaik
2023-03-23 20:46 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06cc8339e30eb38175e04058b69b41ca.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_mohs@quicinc.com \
--cc=quic_plai@quicinc.com \
--cc=quic_visr@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox