public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Keno Fischer <keno@juliacomputing.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"Borislav Petkov" <bp@suse.de>,
	"Andi Kleen" <andi@firstfloor.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Kyle Huey" <khuey@kylehuey.com>,
	"Robert O'Callahan" <robert@ocallahan.org>
Subject: Re: [RFC PATCH] x86/arch_prctl: Add ARCH_SET_XCR0 to mask XCR0 per-thread
Date: Mon, 18 Jun 2018 10:43:37 -0700	[thread overview]
Message-ID: <06f44447-54eb-4644-a905-349cfc82f602@linux.intel.com> (raw)
In-Reply-To: <CABV8kRwhrQ75g9y7v4Mq05CfZ9khhVQCwkp052jcNOvKs6-2Fg@mail.gmail.com>

On 06/18/2018 07:42 AM, Keno Fischer wrote:
>> But, in any case, so how is this supposed to work?
>>
>>         // get features we are disabling into values matching the
>>         // hardware "init state".
>>         __asm__("XRSTOR %reg1,%reg2", ...);
>>         prctl(PRCTL_SET_XCR0, something);
>>
>> ?
> I was primarily thinking of the ptracer use case,
> 
>     ptrace(PTRACE_SETFPXREGS, <recorded regs>)
>     <inject arch_prctl using ptrace>
> 
> in which case there isn't a problem, because the unrecorded regs
> should be in the initial state.

So, to be useful, this interface needs to be called before an
application can run XGETBV or XSAVE for the first time and caches a
"bad" value.  I think that means that it might not be feasible to use
outside of cases where you ptrace() something and inject things before
it has a chance to run any real instructions.

Fundamentally, I think that makes _this_ interface pretty useless in
practice.  The only practical option is to have a _future_ XCR0 value
set by the prctl() and then have it get made active by the kernel at
execve().

IMNHO, if you haven't guessed yet, I think this whole exercise is a dead
end.  Just boot an identical XCR0 VM on your new hardware and do replay
there.  Done.

  parent reply	other threads:[~2018-06-18 17:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-17  0:33 [RFC PATCH] x86/arch_prctl: Add ARCH_SET_XCR0 to mask XCR0 per-thread Keno Fischer
2018-06-17 16:35 ` Andi Kleen
2018-06-17 16:48   ` Keno Fischer
2018-06-17 18:22     ` Keno Fischer
2018-06-18 16:58     ` Andi Kleen
2018-06-18 17:50       ` Keno Fischer
2018-06-19 13:43         ` Andi Kleen
2018-06-18 12:47 ` Dave Hansen
2018-06-18 14:42   ` Keno Fischer
2018-06-18 15:04     ` Dave Hansen
2018-06-18 15:13       ` Keno Fischer
2018-06-18 16:16         ` Dave Hansen
2018-06-18 17:22           ` Keno Fischer
2018-06-18 17:29             ` Dave Hansen
2018-06-18 17:43     ` Dave Hansen [this message]
2018-06-18 18:16       ` Keno Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06f44447-54eb-4644-a905-349cfc82f602@linux.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=keno@juliacomputing.com \
    --cc=khuey@kylehuey.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=robert@ocallahan.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox