From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] vt: keyboard, Fix typo in the doc for vt_get_shift_state()
Date: Wed, 3 Mar 2021 09:40:29 +0100 [thread overview]
Message-ID: <072d4de9-4784-a976-c622-2e43cb4e7702@kernel.org> (raw)
In-Reply-To: <20210303083229.75784-1-andriy.shevchenko@linux.intel.com>
On 03. 03. 21, 9:32, Andy Shevchenko wrote:
> Kernel documentation validator is not happy:
>
> .../keyboard.c:2195: warning: expecting prototype for vt_get_shiftstate(). Prototype was for vt_get_shift_state() instead
>
> This is due to typo, fix it here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/vt/keyboard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
> index 77638629c562..5d2309742718 100644
> --- a/drivers/tty/vt/keyboard.c
> +++ b/drivers/tty/vt/keyboard.c
> @@ -2186,7 +2186,7 @@ void vt_reset_unicode(int console)
> }
>
> /**
> - * vt_get_shiftstate - shift bit state
> + * vt_get_shift_state - shift bit state
> *
> * Report the shift bits from the keyboard state. We have to export
> * this to support some oddities in the vt layer.
>
--
js
prev parent reply other threads:[~2021-03-03 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 8:32 [PATCH v1 1/1] vt: keyboard, Fix typo in the doc for vt_get_shift_state() Andy Shevchenko
2021-03-03 8:40 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=072d4de9-4784-a976-c622-2e43cb4e7702@kernel.org \
--to=jirislaby@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox