From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jinlong Chen <nickyc975@zju.edu.cn>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] blk-mq: improve readability of blk_mq_alloc_request()
Date: Wed, 2 Nov 2022 01:16:08 +0000 [thread overview]
Message-ID: <074cfae7-982d-5273-e63e-8db4fa22db14@nvidia.com> (raw)
In-Reply-To: <20221101173727.GC20690@lst.de>
>> +static struct request *blk_mq_alloc_request_nocache(struct request_queue *q,
>> + blk_opf_t opf, blk_mq_req_flags_t flags)
>
> The name is a bit odd, but I can't think off a better one.
>
>> + struct blk_mq_alloc_data data = {
>> .q = q,
>> .flags = flags,
>> .cmd_flags = opf,
>> .nr_tags = 1,
>> };
>
> And this now has superflous indenation. Overall, while the separate
> helper looks marginally nicer, I'm not really sure it is worth the
> churn.
existing code is fine here than adding this indentation which
is not worth a churn...
-ck
next prev parent reply other threads:[~2022-11-02 1:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 15:11 [PATCH 0/4] some random cleanups for blk-mq.c Jinlong Chen
2022-11-01 15:11 ` [PATCH 1/4] blk-mq: update comment for blk_mq_quiesce_queue_nowait() Jinlong Chen
2022-11-01 17:27 ` Christoph Hellwig
2022-11-02 1:44 ` Jinlong Chen
2022-11-01 15:11 ` [PATCH 2/4] blk-mq: improve error handling in blk_mq_alloc_rq_map() Jinlong Chen
2022-11-01 17:34 ` Christoph Hellwig
2022-11-01 18:18 ` Jens Axboe
2022-11-01 15:11 ` [PATCH 3/4] blk-mq: use if-else instead of goto in blk_mq_alloc_cached_request() Jinlong Chen
2022-11-01 17:35 ` Christoph Hellwig
2022-11-01 15:11 ` [PATCH 4/4] blk-mq: improve readability of blk_mq_alloc_request() Jinlong Chen
2022-11-01 17:37 ` Christoph Hellwig
2022-11-02 1:16 ` Chaitanya Kulkarni [this message]
2022-11-02 2:19 ` Jinlong Chen
2022-11-02 2:25 ` Jens Axboe
2022-11-02 2:39 ` Jinlong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=074cfae7-982d-5273-e63e-8db4fa22db14@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickyc975@zju.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox