From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Neal Gompa <neal@gompa.dev>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rtc: Add Apple SMC RTC
Date: Wed, 13 Aug 2025 08:14:51 +0200 [thread overview]
Message-ID: <074fcd4c-0da8-42c4-a567-64fa7e173894@kernel.org> (raw)
In-Reply-To: <20250812-wip-smc-rtc-v1-1-66a8e96dad60@kernel.org>
On 12/08/2025 20:25, Sven Peter wrote:
> +maintainers:
> + - Sven Peter <sven@kernel.org>
> +
> +properties:
> + compatible:
> + const: apple,smc-rtc
> +
No resources except nvmem? This should be folded into the parent. Don't
create device node to instantiate drivers.
> + nvmem-cells:
> + items:
> + - description: 48bit RTC offset, specified in 32768 (2^15) Hz clock ticks
> +
> + nvmem-cell-names:
> + items:
> + - const: rtc_offset
> +
> +required:
> + - compatible
> + - nvmem-cells
> + - nvmem-cell-names
> +
> +additionalProperties: false
Missing example. If this is part of other device (like MFD), then the
one there should be extended here.
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-13 6:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 18:25 [PATCH 0/3] Apple Silicon SMC RTC driver Sven Peter
2025-08-12 18:25 ` [PATCH 1/3] dt-bindings: rtc: Add Apple SMC RTC Sven Peter
2025-08-12 18:40 ` Mark Kettenis
2025-08-13 6:14 ` Krzysztof Kozlowski [this message]
2025-08-14 21:19 ` Rob Herring
2025-08-16 12:46 ` Sven Peter
2025-08-12 18:25 ` [PATCH 2/3] rtc: Add new rtc-macsmc driver for Apple Silicon Macs Sven Peter
2025-08-12 18:25 ` [PATCH 3/3] arm64: dts: apple: t8103,t600x,t8112: Add SMC RTC node Sven Peter
2025-08-14 13:06 ` [PATCH 0/3] Apple Silicon SMC RTC driver Neal Gompa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=074fcd4c-0da8-42c4-a567-64fa7e173894@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).