From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2059.outbound.protection.outlook.com [40.107.237.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E371A00D1; Fri, 11 Oct 2024 17:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.59 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728666521; cv=fail; b=tK7ELUcJlPet/16jzWem8uLEs+kk/Zt1MqgfZg/4gfmpxcImZXm5ZDOlvBiOCpbvEY8CECoV94SKJsoHzTKCpsSebaHmuTA1vAAbMk54eXPKdmlXA4PBXAKzuXZ/dCsGm77k6bbqilDEdjIkxdVHbPk7u3ulPsot9Tb8KsrytU8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728666521; c=relaxed/simple; bh=y+u6Z3j52hvPW6XJhUvap5236mukY435/HPTu0A4a58=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=c7EiHpD4fP2vi3Fkale541HlPhzGpNQMth1XgKYvz1tLnDbyWu8oJ7Xod1/PNAuoywCT75+U1bTUZSwHAZV+J5c5SwwB91N0guz+awT/ZM2iVpRZTrYsz23t8n0LthuAN9MnMV6FfQge9xc3v6UZKrB+SwSRfXdddYBFBpbCXlg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=JN7qMcHo; arc=fail smtp.client-ip=40.107.237.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="JN7qMcHo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OVTfTekny6wftWKtnsA5FsAixYXv78Tsockuta56AYX6snNDU8ua1P37HBp+/ts7bIeXms8VQFGkedQBdLQPpaIZRfku7cGFwnSHw7BMp8yJS97+KtYI+RPrn7Tns7zA8fzDRVRNkcPU4PFqv5LnwxPsEi/FYOIOZIR5TOuJQXutCe5+bjBmEbZEMUZ6+qPoh/hBiB1CPcwMrMSCvHNxacesEInVdVidgFdW6aat/7SrNMu6RV5TgfTqTNPruMyzvW2FUBCILsRntkY6EqJrmWQDH8MaSzcWeIpf7Q+bcz3sXr9DmcVByGDsg7XqPaVYfKYXS6RCfIt13m+aNjgvwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wY3zSs64REkveZlGOXBWQEhbPiRraOUvAExrjbIc3jo=; b=Z3DmQZJoD7KbA1kZkXbjpQnUI6C7bZ9ygO8gI5JzdKGddjGHXNxKx2UhWKzjkx/Hz5VUjDKvr8WLSoyAAPc96X4YgUjxo2kYKQcnaze16vabTfdoqRCzgzbK5DvCxJGbagIk/MzQMqLCQN3OzcLnbwh1dtqlQ09MRQ4Sz9qhzCiQfRx/bEA87fZuLf/YY3EogmHGrUBkBWpTCX/+Shxem6XjBv7dINzwwof9+/XHAT3YnY8bYpEu9IPycYmsvDxg8vYr6UjNbFTV/Kim02Mn6G+XmkScAuQrzl/GPNXrOSCu/U9s4j0wHAhz+VZgqjR2MXgCbNI1+2PEA2xCliJz6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wY3zSs64REkveZlGOXBWQEhbPiRraOUvAExrjbIc3jo=; b=JN7qMcHovV7OVmjJBatrszulyf0NIWAIEdBxvJSpssk8hNakjAiLWM60iKOcEnulewWglbBXizEFfXXWbqzkceDzi7tt9aPTgc+cNdWNbhemJ/xR/4+9S9fFy72zCO+TsVKJyR5qwy5svWLs0CBdFHCKsgxk0uZkPYUTFxvOszE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SA0PR12MB4447.namprd12.prod.outlook.com (2603:10b6:806:9b::23) by MN6PR12MB8469.namprd12.prod.outlook.com (2603:10b6:208:46e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.20; Fri, 11 Oct 2024 17:08:36 +0000 Received: from SA0PR12MB4447.namprd12.prod.outlook.com ([fe80::b4ba:6991:ab76:86d2]) by SA0PR12MB4447.namprd12.prod.outlook.com ([fe80::b4ba:6991:ab76:86d2%5]) with mapi id 15.20.8048.018; Fri, 11 Oct 2024 17:08:36 +0000 Message-ID: <07b4dd67-9e09-eb0c-86d2-92fa68938129@amd.com> Date: Fri, 11 Oct 2024 12:08:34 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm Content-Language: en-US To: Borislav Petkov , Tom Lendacky Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-coco@lists.linux.dev, Thomas Gleixner , Ingo Molnar , Dave Hansen , Eric Van Tassell , Ashish Kalra , Michael Roth , "H . Peter Anvin" , Peter Zijlstra , Dhaval Giani References: <20241010121455.15795-1-papaluri@amd.com> <20241010121455.15795-2-papaluri@amd.com> <20241011162120.GDZwlQgKTFi22JZ5If@fat_crate.local> <20241011164825.GEZwlW2XggpAMsZ3P9@fat_crate.local> <7df1961f-f120-3914-ef23-9e466cda6248@amd.com> <20241011165912.GAZwlZYDO_kz3HQ_ie@fat_crate.local> From: "Paluri, PavanKumar" In-Reply-To: <20241011165912.GAZwlZYDO_kz3HQ_ie@fat_crate.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA0PR11CA0028.namprd11.prod.outlook.com (2603:10b6:806:d3::33) To SA0PR12MB4447.namprd12.prod.outlook.com (2603:10b6:806:9b::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA0PR12MB4447:EE_|MN6PR12MB8469:EE_ X-MS-Office365-Filtering-Correlation-Id: c3ba474e-4ab7-4c19-99b2-08dcea175833 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OUNXRVFpc1lLUXpiRGJFbGppSHdQTXcwSzZtTzVyQlVLWGtGdys5eHI3dkcy?= =?utf-8?B?aWROZEJyclhnYnhzL3FOSjdsOHJtdHo3UVU4Y0tFNjBZZjdERklKYVdtb2JU?= =?utf-8?B?S0hOZVljbmUzSzRhWlZIclJaRHhnczlsNTZnRFVmNDdaUkprWTBPTVF6bGNm?= =?utf-8?B?czluM2lpMjdMbFpRL3N6Y3BsYldjNmMvZmNselFiNXhiMlhRT1pwZkJZbWZB?= =?utf-8?B?Tm5FdXhtN0h4RDZ0OXhwdGlkeDZ6dUhYeFBZNzNXOHFuTk10em9TR00rZjJW?= =?utf-8?B?Y0dBY2Noenk1Qkh4SHJBM2U4aUdlOUEzeUdPWnd1MDQvZE95QzFKSGRzY01D?= =?utf-8?B?UGhBcldyMndzekVzT1J3anlxRVkwVXYxcTFrUUQ1QXVYcjRFczRRUmJ4U0hr?= =?utf-8?B?WWlSS01PdWw3bDJpNmFxcFd6SGMyOUlmdk1TTVpvWjhLMUgxR0UzazNzZWVz?= =?utf-8?B?SHJhOFY3azBBdHB5NkNNdWRiMm1iOXhaVU5PU1RrYjd1ZC8zaHZWQ0grRXJI?= =?utf-8?B?cDJNbjh4S2FyTGtOREZ6NkQ4M2x0VnhUTGxxcS9sbFBXYXBiakI0Ly9XOG91?= =?utf-8?B?bDRzWUhjaUxRNUNmQ3R4L2h2T0VRQmNNN2JrWU1YOFBTY1pITndHVXBvUGJI?= =?utf-8?B?OVg0b1NjTHVXY3AvYkpzNHlEQjVpelFEMEZ2TUlRZlNUeWtpR3JzdHQyM2Nh?= =?utf-8?B?Vm1SbXJmeXMrOGk4VzFWU1A3ejNnR0hhWmlXd21aVlBOVWZQSGY0MmdGZlo3?= =?utf-8?B?Q0lpajE4UXVQdnFmSW8rVndpbi85bVFnTkwzZlhDK00vU0JYbzBFZWc3RFU2?= =?utf-8?B?alZwKzdhekM4cXI4OFVlZXc0T2FDbWswdTc4Vjc0TXJEa3M0RzhUb291L2V0?= =?utf-8?B?TmUxYkJhUjU5bjNFQ0Y4LzZyMWNDVUo1WGU1N2t1VC9BeDVUTVB5aEpnRFYr?= =?utf-8?B?c3BweUthRmt0Rk52eXA5YzRWcjQ5Z2pGSk9RdmpGeUVreXZDNnNGbEVRTUQ1?= =?utf-8?B?MWJ1SjlzakZ6QUNPYzhmU2pSRWg4azVXcnJMcUFXTS9GQzVmMDJRUGZ1U3FU?= =?utf-8?B?dHJkempnanltWlpZeHZPSkUrY3NnUW5RREZyTHUrMDRLc21HTXFOMGxraStG?= =?utf-8?B?S2cxQWVXNWlQU3V5R204V0pRZTcxd1R5V1RRS0VlVUxCZ3JPK21JaWdNaW5J?= =?utf-8?B?elM3UkE0ZGFGZGZybk81R1FnRlNxOXZneGVuTWRnVW1Oc1pIMVNGRzZkUmx4?= =?utf-8?B?K1ZNT3BTV0xpbldSSEYyN1dCL29WdEpNeHRub3J0eldNS0YrSFNKVklHVGF1?= =?utf-8?B?OG1aUlI1dDVEK0owQXhpbTFxWmRsWit6RVhMblFRclNMV1J2NG9Ma083MGhU?= =?utf-8?B?MzJXZU9KeHV0MzF6RXB5U2ZJa3h4M3Nta2oxQkpWMHo3UTJkTG9wWXhWMmNQ?= =?utf-8?B?RmVqMG41VzJNOGNjVXF2OFR6RkZtaEpDaDJ5ekF5c2NOWnUyNy9RWk95RXM4?= =?utf-8?B?QXdkWXRCR092aTFaeFJIN3poSkQ3eEdvR0RBZ3BteS8xbTlkekVZbVozcWo1?= =?utf-8?B?V3hxRXVvUDNycjd2MGpaK1V3WkxnZHZiWFZ0SHFUbElPVVdKNmlQazJlQSs1?= =?utf-8?B?Y0dsWWFEZjJFY1BSaTFEbzQyMzN6Tzh3Vkovak55Wjd5d2Q5MWV1MjdpcHZx?= =?utf-8?B?ei9MeTl6U3BwSXZZMWY3ZnZDY2F1UHoxMGdBR2VjMGxQV2Z6YkdBT0dnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR12MB4447.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WldaSHcxbXprQU1TcTByTURmaUtrZDh2VEx2Z084ckJLWUR0V0FjbDNLMktS?= =?utf-8?B?VUFqZVRuRTY1YkdQNklQU0daMzlSbDdhVmhmYXcxc3Vrbnh6T1JuR3hzYWdN?= =?utf-8?B?bXAzMUVSbVJZdWcrZU9iVi9mTHFxbklMcEdzclV2OHBUazRYR1pTcVppdld3?= =?utf-8?B?SWFtN0RMYTU0VnYyS3Q4RHVmeFFQVVhvZ2l2engwNFg4N2c3L3VaUFhKMW9K?= =?utf-8?B?RkE4WCtzM0MrWjIrUVhjT0cyeXlvVC9BVXkzNk5ReEV2SDZsbjdJRmtub2VZ?= =?utf-8?B?U3NHNjc0cWZ0TmdoeDdHRkRkOXFBbEtld1FMdDEyd25uTW4va0h3ZlR3SDYz?= =?utf-8?B?Sm1NMEVlNTBwcnNxS043cWRjZGlyMmd2SWlXN1Jlbk00VGcwNE5qMDNqOGhj?= =?utf-8?B?Y0lzS2l4QmpGTGhMZ1RsR25XYUJtR0QxYm00OXg5dVN6ZlducTZjWGF6RnZO?= =?utf-8?B?S1dXMmJIN1ZTN3hlQ1Zxb3VENEFuanhDQnJ2Yk1HMGh6Sm1VbktkVzV5dFYr?= =?utf-8?B?ZWJOMWFjaVlMSlZyNzJYbFZCdThEdHJCcUFPNm0xSmRGengxWG53OWg2eXN0?= =?utf-8?B?MFlqY3htOGcrUHpvNFcwcXRSSWxSaGxCUDF1UldHeXRRQXI1MFg5K2pqbm9F?= =?utf-8?B?SG9Fd1BUdVpyWU9vMXlSbFJhNWFZeTE2V2NuazV4cC9MaEhUVTZCMGwvQlFE?= =?utf-8?B?TENscWQ5RllJSU55NlRGMHhzMjdWOUpsZG8vOWl4Z1ZJazB5THFuR0Urc3ZH?= =?utf-8?B?OHhhVEFwdUdMcnZVRjAwZmVlTmZhbjRINUNQNnlQcitJaDFKNzhvU00xeERN?= =?utf-8?B?VHl6ZHJPQ1poY1FsSUFyaXMxYy85dnJMdTVrTm81aVh5bWd0M0k0UDRKT3dY?= =?utf-8?B?Rmk3dFM2S0xUL3ZPVVlnVFFRdWdZcE9WV0d0Sk1RQ1hXY0w1ZDkwVGdYV2hR?= =?utf-8?B?NWFxcUNWYWtUaUZkaXZxUEh4ZDFmeXc1eUs5N0lndmEzSHZ4MjBwd1pPa2cx?= =?utf-8?B?dUpEaGFVdGhTYlQzNFkrcm5SdDZkR2w3b2xGRWFpRzlXN1cyd2xmZGl6aUFn?= =?utf-8?B?c1Jvb091emxyaWl6MU10Wi8zWWlFUENmR3pkS3Bpb25Qc0JCMkhLc3A5RnFt?= =?utf-8?B?OEVTY01IS2VvZHJLakNybGFJVTFIN0YzdG5mQ1FvN3plUnJzOVZrc0JleERa?= =?utf-8?B?bkFuYUFYZ2hBc2RvcEV6UmdNSm1QUi83bmdiMjdDc2ZMa3JyZ2xyVDBIbmhl?= =?utf-8?B?SWhYVU5mZUR2Y1ZPdmRJdTZsUHJDOTRJemJYN1F5bllkYWN3Q3JsSitXdTRU?= =?utf-8?B?VE0rNFRuVVErcHc3VTdmY2Z6eldiQUhDbXduWXphMHZZNlBoNkpqcnJzbjF0?= =?utf-8?B?ODZIOEJNUDJZM21jc0xReUF2RnM1czJkNWJOd20zNVpKZ25oSVZNSFY5QzZQ?= =?utf-8?B?SGZTK3dWa1R0dSsyQWkwQkVyTU84Mmhld3hWbWo5WEtpQmQ2WEgvdnhSMWp6?= =?utf-8?B?L2ZnYm9SQlhZMWF6UzR4UkEyZ2hxRXREMjhXTHQ3MDNGY3ROV1J1OXc3Z2VI?= =?utf-8?B?S0NJazVZZCtzZjI2Vy9JbHA4a0ZkcUZHYUFFdTlmd2REamRTWC9EWWJTcWsr?= =?utf-8?B?L3JIbXdMNGR4V0VMRWk3a2JhZWpFNVNQVGxYd2xzdUp0OXFsbW10TnNCVG13?= =?utf-8?B?OEVrTlFnaGdkdXg5U1JadDRZc2hFcW5mMUhNdm9SUHdqNHVwZEsrM2t4d1Jy?= =?utf-8?B?RTRwVlZZWVVuOUs5SEZKYzg3RFl3eHlSTGNUbmNrWEFMdmoxRTFXRThocksw?= =?utf-8?B?Y0Rzcmc4R2hUVjZiMzEvNHZrRUlpM0dzSnkvOVB6bFhpWEdveklBcGIzSWJt?= =?utf-8?B?bG9Xd3F6UnJqaWEzbjhSOHVyaEp6TGwzWmZiaGJjUjBtSzVjREpZV3g2dWVW?= =?utf-8?B?QlBzcTByOUtYaVJpNVRYOTFDd1VZTk9vOXpmaU1ZRld0dzFYSU1EZm5iTVBu?= =?utf-8?B?QldpZTZxSmtUMEx3aFZ6QzIva3MxTUFGbkg0Q0hoM0RVamR3TjlibTFzamZT?= =?utf-8?B?d3MvcExyNmtTWGF3ZVJCRWY3MEw2RTFQb2ZtUFlDaSswdmdDbEZ2MzhZcWla?= =?utf-8?Q?Wgz26OwtCpmIseTXUSMUDB74G?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3ba474e-4ab7-4c19-99b2-08dcea175833 X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4447.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2024 17:08:36.6078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k7NIJNvOGSe+jJIrMudjRVmsfvwPmAZ945641r7+PUAVhvhZKPeLTjjMBD+Z31dNivkP2wDQRYdwWqLPg16Yhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8469 Hello Boris, On 10/11/2024 11:59 AM, Borislav Petkov wrote: > On Fri, Oct 11, 2024 at 11:55:14AM -0500, Tom Lendacky wrote: >> Ah, that makes more sense. Looks like he's missing the include for >> linux/cache.h > > "Changelog: > ========= > v5: > ... > * Remove stray header introduced in the previous > versions because of __read_mostly attribute that is now moved into > virt/svm/cmdline.c" > Yes, I am very sorry. I should have done a progressive build, which could have helped me in spotting this issue. This changelog points at removing from arch/x86/include/asm/sev-common.h (where __read_mostly was previously present) and forgot to include this header to where it is now relocated to. I will address this. On building the patchset (1 and 2 together), I do not see the error, so this should have occurred on just building Patch #1. Thanks for the review. Pavan