From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] drm/bridge: Add 'struct device *' field to the drm_bridge structure
Date: Thu, 16 May 2024 20:04:59 +0800 [thread overview]
Message-ID: <07b931d9-b11f-4829-a6c4-d5025fc071b5@linux.dev> (raw)
In-Reply-To: <e955b706-04dd-479f-8327-32771d94f70f@linux.dev>
On 5/16/24 18:40, Sui Jingfeng wrote:
> use 'to_i2c_client(bridge->dev)' to retrieve the pointer
to_i2c_client(bridge->kdev).
Besides, this also means that we don't need to add the fwnode
pointer into struct drm_bridge as member. Relief the conflicts
with other reviewers if the work of switching to fwnode is still
needed. As for majorities cases (1 to 1), of_node and fwnode can
be retrieved with 'struct device *' easily. The aux-bridge.c and
aux-hdp-bridge.c can also be converted too easily.
of_node, fwnode, swnode and device properties are all belong to
the backing device structure itself. It can be more natural to use
device_proterty_read_xxx() APIs after init time, Which in turn
avoid the need to acquire and duplicate all properties another
time in the driver private structure.
We could do the programming around the 'struct device *.', remove
a batch of boilerplate.
next prev parent reply other threads:[~2024-05-16 12:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 15:40 [PATCH 0/2] drm/bridge: Add 'struct device *' field to the drm_bridge structure Sui Jingfeng
2024-05-14 15:40 ` [PATCH 1/2] drm/bridge: Support finding bridge with struct device Sui Jingfeng
2024-05-15 9:39 ` Jani Nikula
2024-05-15 10:17 ` Sui Jingfeng
2024-05-15 10:28 ` Jani Nikula
2024-05-15 10:34 ` Sui Jingfeng
2024-05-15 11:33 ` Jani Nikula
2024-05-14 15:40 ` [PATCH 2/2] drm/bridge: Switch to use drm_bridge_add_with_dev() Sui Jingfeng
2024-05-14 16:22 ` [PATCH 0/2] drm/bridge: Add 'struct device *' field to the drm_bridge structure Maxime Ripard
2024-05-14 16:53 ` Sui Jingfeng
2024-05-15 14:30 ` Maxime Ripard
2024-05-15 14:53 ` Sui Jingfeng
2024-05-15 14:58 ` Maxime Ripard
2024-05-15 15:19 ` Sui Jingfeng
2024-05-16 8:25 ` Maxime Ripard
2024-05-16 10:40 ` Sui Jingfeng
2024-05-16 12:04 ` Sui Jingfeng [this message]
2024-05-19 21:44 ` Dmitry Baryshkov
2024-05-21 8:37 ` Maxime Ripard
2024-05-21 8:34 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07b931d9-b11f-4829-a6c4-d5025fc071b5@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox