From: "Aiqun(Maria) Yu" <aiqun.yu@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>,
Mike Tipton <mike.tipton@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in Kaanapali SoC
Date: Tue, 28 Oct 2025 11:02:07 +0800 [thread overview]
Message-ID: <07c5c404-e2a7-418e-af5f-dc7c4df9f2f6@oss.qualcomm.com> (raw)
In-Reply-To: <57bc950a-a62b-4218-99a0-86c570bba6db@kernel.org>
On 10/23/2025 2:23 PM, Krzysztof Kozlowski wrote:
> On 23/10/2025 06:39, Raviteja Laggyshetty wrote:
>> Document the RPMh Network-On-Chip Interconnect of the Kaanapali platform.
>>
>> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>
>
>
> This cannot be tested, so there is little point in doing real review. We
> already provided guidance - and it is documented in your internal
> guideline document - what to do in such case. Please follow internal
> docs to decouple.
To be more specific:
Please drop header "<dt-bindings/clock/qcom,kaanapali-gcc.h>" and use
ephemeral clocks in the devices example like
<&gcc_aggre_ufs_phy_axi_clk> <&gcc_aggre_usb3_prim_axi_clk>
<&rpmhcc_ipa_clk>.
>
> Best regards,
> Krzysztof
--
Thx and BRs,
Aiqun(Maria) Yu
next prev parent reply other threads:[~2025-10-28 3:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 4:39 [PATCH 0/2] Add interconnect support for Kaanapali SoC Raviteja Laggyshetty
2025-10-23 4:39 ` [PATCH 1/2] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in " Raviteja Laggyshetty
2025-10-23 6:23 ` Krzysztof Kozlowski
2025-10-28 3:02 ` Aiqun(Maria) Yu [this message]
2025-10-23 4:39 ` [PATCH 2/2] interconnect: qcom: add Kaanapali interconnect provider driver Raviteja Laggyshetty
2025-10-23 14:10 ` Dmitry Baryshkov
2025-10-23 6:22 ` [PATCH 0/2] Add interconnect support for Kaanapali SoC Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2025-09-24 23:02 Jingyi Wang
2025-09-24 23:02 ` [PATCH 1/2] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in " Jingyi Wang
2025-09-25 4:39 ` Rob Herring (Arm)
2025-09-25 8:57 ` Eugen Hristev
2025-09-25 12:40 ` Konrad Dybcio
2025-09-30 3:06 ` Raviteja Laggyshetty
2025-09-30 9:57 ` Eugen Hristev
2025-10-21 1:58 ` Raviteja Laggyshetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07c5c404-e2a7-418e-af5f-dc7c4df9f2f6@oss.qualcomm.com \
--to=aiqun.yu@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mike.tipton@oss.qualcomm.com \
--cc=odelu.kukatla@oss.qualcomm.com \
--cc=raviteja.laggyshetty@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox