From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A118C6FA82 for ; Thu, 22 Sep 2022 09:04:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbiIVJER (ORCPT ); Thu, 22 Sep 2022 05:04:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiIVJEP (ORCPT ); Thu, 22 Sep 2022 05:04:15 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3C967B56FA for ; Thu, 22 Sep 2022 02:04:13 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EBF8106F; Thu, 22 Sep 2022 02:04:19 -0700 (PDT) Received: from [10.57.1.91] (unknown [10.57.1.91]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 464263F73D; Thu, 22 Sep 2022 02:04:11 -0700 (PDT) Message-ID: <07d37df2-246e-70ea-4a9f-e33354d8864d@arm.com> Date: Thu, 22 Sep 2022 10:04:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/1] arm64: defconfig: Add Coresight as module Content-Language: en-US To: Mathieu Poirier , Mark Brown Cc: coresight@lists.linaro.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, linux-kernel@vger.kernel.org, Will Deacon References: <20220921140535.152627-1-james.clark@arm.com> <20220921140535.152627-2-james.clark@arm.com> <20220921164622.GA1124503@p14s> From: James Clark In-Reply-To: <20220921164622.GA1124503@p14s> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/2022 17:46, Mathieu Poirier wrote: > On Wed, Sep 21, 2022 at 04:26:59PM +0100, Mark Brown wrote: >> On Wed, Sep 21, 2022 at 03:05:35PM +0100, James Clark wrote: >> >>> +CONFIG_CORESIGHT_CTI=m >>> +CONFIG_CORESIGHT_CTI_INTEGRATION_REGS=y >> > > I agree - integration registers should not be enabled by default. > >> Do we want this turned on by default? According to the >> description it's a bit dangerous and it's exposed via sysfs >> rather than debugfs. > > Should I disable just CONFIG_CORESIGHT_CTI_INTEGRATION_REGS or CONFIG_CORESIGHT_CTI as well? There are other writable registers exposed via sysfs outside of these two options, so I wanted to check if it's just the integration registers that are the issue.