Re: [mm/debug] fa6726c1e7: kernel_BUG_at_include/linux/mm.h

Anshuman Khandual
2020-04-28T02:35:41Z

On 04/28/2020 07:35 AM, Qian Cai wrote:
>
>
>> On Apr 27, 2020, at 9:49 PM, Anshuman Khandual <Anshuman.Khandual@arm.com> wrote:
>>
>> This is an unsupported (enabled via CONFIG_EXPERT) X86 platform (CONFIG_X86_PAE)
>> and is known to fail. The latest (V17) patch had moved the test invocation into
>> a late_initcall() per Linus thus pushing down any possible failures (like this)
>> after early boot. Please ignore this report.
>>
>> Apart from this X86_PAE based config, no other platform failures have reported
>> so far. Assuming that this test robot does have a good platform coverage, the
>> CONFIG_EXPERT method of enabling CONFIG_DEBUG_VM_PGTABLE should help in getting
>> more platform coverage for this test.
>
> This sounds really sloppy. Why can’t we make it impossible to select this combination if nobody is willing to fix it?

Letting CONFIG_DEBUG_VM_PGTABLE enabled via CONFIG_EXPERT for unsupported
platforms i.e without ARCH_HAS_DEBUG_VM_PGTABLE, was a conscious decision
meant to expand it's adaptability and coverage without requiring any code
(i.e Kconfig) change. The easier it is to enable the test on unsupported
platforms right now, more folks are likely to try it out thus increasing
it's probability to get fixed on those platforms. That is a valid enough
reason to have CONFIG_EXPERT based enablement method, IMHO. Also even with
CONFIG_EXPERT set, CONFIG_DEBUG_VM_PGTABLE does not get enabled by default
automatically.