From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934764AbcIGLsH (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 07:48:07 -0400
Received: from mout.web.de ([212.227.15.3]:57158 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753957AbcIGLsF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 07:48:05 -0400
Subject: Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes()
To: Paolo Bonzini <pbonzini@redhat.com>
References: <3b21b2d7-9856-009c-9bd1-3a76a83bc7fc@users.sourceforge.net>
 <CAGXu5jLSsU+daPP=uX+3T02RkTFguG1rtemOF-7Py_Fi=qYP6A@mail.gmail.com>
 <e24dae2d-b55a-d90a-9934-080e6165802b@users.sourceforge.net>
 <f1caa945-b808-f6b5-6047-35c43330431f@redhat.com>
 <f9edcf05-482e-dfbb-b661-c070ee1debf4@users.sourceforge.net>
 <3eea073a-b271-54b7-1eec-e841e0f4bdf9@redhat.com>
Cc: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>, Dave Young <dyoung@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Matt Fleming <matt.fleming@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <07f2cb49-662f-590f-acf6-686f8432015d@users.sourceforge.net>
Date: Wed, 7 Sep 2016 13:45:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <3eea073a-b271-54b7-1eec-e841e0f4bdf9@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:CD+SAbtj0oEfl2M7oOdhFmHtuSdlbeslNzB9decjroIRIaRdotm
 EZKoJDwl+95XddFmnFP2IpIl6ATOXvYhCNJi2GSfkmbnApvq2Bhpd+HdA53fw+xjnav/gFc
 E6krD6GDkhoygOI8E/mXkHVVntnp6acirMt8j49zPZhMulSQY5Q+H1YLVfACxoIBQc+pBiq
 NzAGM1+UnfnLkKUIvTLkA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:xC49R1sIXcU=:+rPoA9X8rVj3HW1E443TFj
 hxMreCWRZhKLYgeUn9hEw8Gco71LYQTFj6fiCuWMpfeQ0p9fiBcMiAgfCcqvxly8LW7TFUKJV
 AWiJDdQrU1gXvi0+VYiAsD1ywkSNWsAr5Hi9TFX67DIANDsLp0Kb5ZLBTpNc136Ri2K1gk+HB
 Q60At/oojVkBsvfTqsydJtTRXTeweMMinb03sXlq/gZdRXzPCj8FiM5StTMI7hb0XIvJcxDkg
 /TCPzi9A4cZFo4QGFzAzYgyzVG0kii0y2YRMzbqAkUsEQq8r7bJWpm3Y0Gj323cjhlvy7ap04
 6OfFrzHK5qwrGlUbEOYfFZ9L8zbXEPlsWimaJNQ96Dn7SOmGMMHX5z+UDsXC5mc53tLWhLzkQ
 zLpFyEkgVRZtwUWE4o2h9FxbcbUpJqQdDT4Nt6TZaLbO3FJDekRRsdBxkxARJaULb3SfG/fb0
 gv/H/SpFypMRllcprn15HUOp/q2tudgIAHJUWqN8/16CPHDLMwST9KuykrstUlPCm0yjeZWSV
 1Fg8Rv04nA8jgCh/8qrcz+CAlI2zWHKLcf6C71Zk36SK/PfYaWGl4Hi7r9OovsS6E3uNWBFQU
 kIV0rrMpj4lmAM+hYeL2ygBZe1Wr2GIdXI1HSHn+rUSGdLUrzWClPnK0PMKC9alP4+EjBEI3d
 wYldejynBkAakOVQQZ5b/FxznVyR3/ZABzlUZgXTVUIIgcoE6uyLTno0VHtdRGH1TPlrE0z1E
 pRJ1duhk8Rus/kUrf+ruUeZ1zmLgjX1v/EzcN9YyZzZYEeiB5r3Zy4dOhbldpL7qCXi3ho70u
 1SU8iG2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Would the following script (for the semantic patch language)
>> be useful enough for further development considerations?
>>
>> usage_of_kmalloc_array1-excerpt2.cocci:
>> @replacement2@
>> expression count, pointer, target;
>> @@
>>  target =
>> -         kmalloc(sizeof(*pointer) * (count)
>> +         kmalloc_array(count, sizeof(*pointer)
>>                         , ...);
> 
> Why don't you include the _exact_ script that you run?

I showed only the "excerpt" above because of the current situation
that this single SmPL rule triggered the software change
which I suggested for the referenced source file.

How do you think about to try a command out like the following
also in your development (or test) environment?

elfring@Sonne:~/Projekte/Linux/next-patched> spatch.opt ~/Projekte/Coccinelle/janitor/usage_of_kmalloc_array1-excerpt2.cocci arch/x86/kernel/ksysfs.c


Regards,
Markus