From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 073B421D3F5 for ; Sat, 11 Jul 2026 22:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783809951; cv=none; b=sQ5V3kFR0IfgA3+UbI29n5FtX02v7Kw335TyMPqL+/OaDtl0r4kHTebNpT3e2ZipFSdq8w4/iZVtLvgUfVfNfYHkOw3h0EZ9Hrq5/jmRUUggpQXZ6S9KsuIFHX41JF7GhnhDG76jyVs+p4bJLi/1LYCMXhaJJ9UgofYiMM3BWtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783809951; c=relaxed/simple; bh=4CQdKFoQlLz1juoPgLWZH/Qe2GtlOUwe6pBmAi57Vz8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=efMdQfPLHkQ7fk3Q1/sAjTxKjIblfX3vM+bzNQJjaevlFxY528002ZWr+KDjvJEuMO+B5wGasWsGxKFMK+Flu9McGZPCvvblGfPKXYM+ptNo+IocoU06p/c/gYJuN+INM8ihgr1NzMV80H8281SuuT+dV9pd7takfyNIUlnrNG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=FJCkHCB4; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="FJCkHCB4" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493ec555a26so14027675e9.0 for ; Sat, 11 Jul 2026 15:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783809947; x=1784414747; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TbHFAwbeJKDJK0vsusjVHYsKb/LRqI4cM06SE7LoHSg=; b=FJCkHCB4s0sGVIw/E5X2bfF4IwEGfLMDg2EdF6SzzsbSgbFxZWw6WuNG3XJ2ZWdRmT LZ+ibI717zDCcslIyfAjY60HnI5h3bxnBuCoCFe64J3TCby11ZhcrjvLbe0VJSquY4FN TnyI4AyIB5toZlMGjVO1fX9KCXabTF2DhgiZUocWpX8vVgC5Nn7V/UAOVLRXWGUEfh68 tnBydoaGMkjJrC+t/aeydTbRnoXTmsda3rfl9+a3at4L56iQdDx/a+BtXe3j2Nma0tv0 suEg+ajhx2+g9E0ofRf3+WBcL/jf6uuFJZphWC6DxYFkK4Fv21cS1IHJ3vzn+HP59SLc PFNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783809947; x=1784414747; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TbHFAwbeJKDJK0vsusjVHYsKb/LRqI4cM06SE7LoHSg=; b=YAxcerKIAJUXP0OiA7QM3gtwFQwGsxk3Hjf+nRgtN0MmQg15O4yP9k77IYKuQxmxfs Sy06wgx6la1iERSFfqbDMU8951xcYh5xmA+Bo6Z0nfCpIQ099rQFuXjRetL6SHFCZ4N7 nNpXIyq7IWT/qBB/qsO6gu0xKTBLH6/5Ejd+FK0Sjoh7NCXHkoHedWygJtjASxBH5iNH rSg8FlvGJjKC55U0SHvixwtWZ4CpRbvLT7Xw98ko/f23U2W8iuBmVlcpSODVbw7R54I5 hPeCAh7Qby3j7RW5KHS1v3G5+FpZtX+U+fN28+IY9EtmVzWZJ+U1LqFTFodtPju1StEs nxDw== X-Forwarded-Encrypted: i=1; AHgh+Rq4Nqsn8hbJwn4TWIEDjvUMFc1BaGM6cd+WwH2J3f2P11jZMf01uU0u08fmVM3Qtb8pXh70T304QtR7Jl4=@vger.kernel.org X-Gm-Message-State: AOJu0YzMCte7j4H8JsPN6toidhJ7MrtObJC5Ls9FA+rR5lBH+4W8mpIj RdYFZXMJ55Kh2vD1e7g12QuABSZ7u5j1EoSFgtpgnsz8HRHCsTu6qU0yTGtiiouIHaQ= X-Gm-Gg: AfdE7ckceVjsCaq+x/82Pkaz4FQ6BaufVCbmWnIgMtNmRxW5gOeJlgz3udnT/nadHKa 3G7q3GVKPNoLMQPUWQUpg4sjte2s0e7fKxPgOV8iGVpOLWdthzVf/JOGcvCI8VaSG1nCik2QrHn XKgvf3u3uRHygn8/zwIs23jR6BrUvyo0KiKgXwrW2K1CaXyC9DgNIzImV4Xo7ngwgEav0ZTkIa9 L+2j/ZcpkcIWJcnuLfQ5N75mRtUxvi3Hi4xzaD5br/NuLFo7IC+zLbmTiEgAtnpzZ7nIgMXPjPg KWS0lMPf49Y0fZWI4NL4u6wz0lXoRE2KrWuyXHLJQ4ZoOE+ssmxf2r5tH9St0+SUYOJLaU4G+AH taM2OvX08TRVJ3cTnrbVc7b2dbImk41W0dnJf6grMrdKVMjllV769JsAjmRrYLh4AlwXlmEAJeJ chOrXHNqZPMIFMggnZ X-Received: by 2002:a05:600c:8285:b0:492:41c9:886b with SMTP id 5b1f17b1804b1-493f87e5a53mr38829965e9.14.1783809947401; Sat, 11 Jul 2026 15:45:47 -0700 (PDT) Received: from [172.16.0.229] ([159.196.52.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6db0eaasm12003342b3a.52.2026.07.11.15.45.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2026 15:45:45 -0700 (PDT) Message-ID: <07f63ae8-bdf2-4e6b-98d1-32dc3e083463@suse.com> Date: Sun, 12 Jul 2026 08:15:40 +0930 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] btrfs: free mapping node on duplicate reloc root insert To: Guanghui Yang <3497809730@qq.com>, Chris Mason , David Sterba Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/7/12 01:11, Guanghui Yang 写道: > __add_reloc_root() allocates a mapping_node before inserting it into > rc->reloc_root_tree. If rb_simple_insert() finds an existing entry, it > returns the existing rb_node and leaves the newly allocated node unlinked. > > The error path then returns -EEXIST without freeing the new node. Since > the node was never inserted into reloc_root_tree, the later cleanup in > put_reloc_control() cannot find it either. > > Free the newly allocated node before returning -EEXIST. > > The callers currently assert that -EEXIST should not happen, so this is a > defensive cleanup for an unexpected duplicate insert path. If the path is > ever reached, the local allocation should still be released. > > Signed-off-by: Guanghui Yang <3497809730@qq.com> Missing fixes tag. In commit ffd7b33944f4 ("btrfs: __add_reloc_root error push-up") there is still the proper kfree(), but now it's not there. There must be a commit removing that kfree(). > --- > fs/btrfs/relocation.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c > index fb85bc8b345c..7e451e587726 100644 > --- a/fs/btrfs/relocation.c > +++ b/fs/btrfs/relocation.c > @@ -588,6 +588,7 @@ static int __add_reloc_root(struct btrfs_root *root, struct reloc_control *rc) > btrfs_err(fs_info, > "Duplicate root found for start=%llu while inserting into relocation tree", > node->bytenr); > + kfree(node); > return -EEXIST; > } >