public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Daniel Wagner <wagi@monom.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-rt-users@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [ANNOUNCE] v5.14-rc4-rt5
Date: Thu, 5 Aug 2021 09:32:44 +0200	[thread overview]
Message-ID: <07fff459-375b-38ef-ec4d-647beb268731@kernel.org> (raw)
In-Reply-To: <20210805070008.nvhzjp56lbx5uwk2@beryllium.lan>

On 8/5/21 9:00 AM, Daniel Wagner wrote:
> On Thu, Aug 05, 2021 at 08:53:53AM +0200, Daniel Wagner wrote:
>> On Thu, Aug 05, 2021 at 08:31:23AM +0200, Daniel Wagner wrote:
>>> Just a heads up. I get these build errors:
>>
>> I suppose this should be:
> 
> and while at it, there are two more compile errors. The first one is
> obvious, the second one is just guessing.
> 
> diff --git a/kernel/futex.c b/kernel/futex.c
> index c05a33a2f865..41e3d63160a7 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -1896,14 +1896,14 @@ static inline void futex_requeue_pi_complete(struct futex_q *q, int locked)
>                 if (locked >= 0) {
>                         /* Requeue succeeded. Set DONE or LOCKED */
>                         WARN_ON_ONCE(old != Q_REQUEUE_PI_IN_PROGRESS &&
> -                                    old != Q_REQUEUE_PI_WAIT)
> +                                    old != Q_REQUEUE_PI_WAIT);
>                         new = Q_REQUEUE_PI_DONE + locked;
>                 } else if (old == Q_REQUEUE_PI_IN_PROGRESS) {
>                         /* Deadlock, no early wakeup interleave */
>                         new = Q_REQUEUE_PI_NONE;
>                 } else {
>                         /* Deadlock, early wakeup interleave. */
> -                       WARN_ON_ONCE(old != Q_REQUEUE_PI_IN_WAIT);
> +                       WARN_ON_ONCE(old != Q_REQUEUE_PI_WAIT);
>                         new = Q_REQUEUE_PI_IGNORE;
>                 }
>         } while (!atomic_try_cmpxchg(&q->requeue_state, &old, new));
> 

same problems, same fixes here.

-- Daniel

  reply	other threads:[~2021-08-05  7:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 16:50 [ANNOUNCE] v5.14-rc4-rt5 Sebastian Andrzej Siewior
2021-08-05  6:31 ` Daniel Wagner
2021-08-05  6:53   ` Daniel Wagner
2021-08-05  7:00     ` Daniel Wagner
2021-08-05  7:32       ` Daniel Bristot de Oliveira [this message]
2021-08-05  9:06         ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07fff459-375b-38ef-ec4d-647beb268731@kernel.org \
    --to=bristot@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=wagi@monom.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox