From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B30E0314B79 for ; Wed, 7 Jan 2026 09:29:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767778162; cv=none; b=VQAbF0BPWjsR+DdgPoK4Xy+uC/rg3M7A2MkGzJMJO9qlujhfg5JgAC8qu4G1hYq+elNgY5vw8SdDVmy5muAL0mQ466tzFUahNE28NYgJzxSxnpzeuxwdbpqBxmzX7Yj+V3Khy2ZEtuKWyXQiAxBq48eaXayu7U1ENdi15RI141c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767778162; c=relaxed/simple; bh=YskUE8ivh/0bvl2ccHBh6Q13s6fd7XMp1/zObXA0Cvc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fsfDfzJpvpBipkdQvuqJMIcpmUmXY0Y1GWb+XkBRi+vNHuEVgRf70i2ynwwjRaEtLJqKfNgHO6TOwh+hDtjAh0tpOrXhPuq6CJ1IPXdoM+bOKYVhStOSc3smjX1dF7NIdEQZFMrv/6FyDluc5jNSat9rCB9jCz7zSAeOof14n84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jIlItCdC; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jIlItCdC" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-6467bed0d2fso1850650d50.0 for ; Wed, 07 Jan 2026 01:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767778158; x=1768382958; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wk512LwmO/uZGHz1Ojwhz3Ek5WphQWvtFTpjZjwnzlQ=; b=jIlItCdCO+29xFklzf+kYmWbmp9vEkdwKe4DgaGTN5PvbI14G7qGJ9fwL/BxrTiVUf hYxurE7YuZivK5W2RabpAX2WpTXF0ajn0kVmzKSpGhTAA0cZov58Okejo7QPUQ/txNrB gPt5EZAYu+PhFi9OPeVJRP6v/Dc8PnsPA53SULfBoSsNprlf8NXMVwxEWSseavRrg/0p Kd7ArR9HUnk8S0GAsbRnQCTD7uC0bOlLlnkn3SMiVNabPr6LesfkN3bR0MUJfJDxckkS uehEHp4k0vWtnd+4asRC3kDGiAhZ/sybWaF+MZs+kX2noA6zaLKzcwwhEeDbg/Tp0rsX oUrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767778158; x=1768382958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wk512LwmO/uZGHz1Ojwhz3Ek5WphQWvtFTpjZjwnzlQ=; b=RTryvMWFQ5guZrl/0iag6QBmkXJUHKuejDdzB+v8ZaEmMPOefY9VqVWzSenjo9T63K fGKfoxKQqIGiST+l9l6yWjhraRisIqJ7VMtUM3EdXi/YlCVq5O9rAXanF+T391LCkr2/ 2f0pGVO5uxR+QqO01PkSl3FNrA69eUiPi8kDjoX7GYqEWzbPwkImnzd0IGXsqWeAZhii v5hVpIfaq8F6infjsfm9HyZWNHD5DAyuPjMtzc138py1eQftzMwMjGOVdn4XoppbsttT l/ib6T7gvHNpwykfIB268LsU1pgzuHc5m8kdwpWYqWxbv8V7okyLPdjd7Ws8KdFYNH9D uKbg== X-Forwarded-Encrypted: i=1; AJvYcCW74StVQ6Y4qa1SRuASKBADVk2bOiLsv7allvPf3xJxaduyXE+UK02FcVdCeVyDOQNqn6T4Kil7JDG6f6c=@vger.kernel.org X-Gm-Message-State: AOJu0YyjwVn1TxILzlHAEcJr3nmBoFWYqLLrpFaewO1/JAbY5MTRV1Fy 4iJ8rY4R7ucaciWmvN9u3m0wHQwymI7OHnWpw74qRH5SacBSnmCG0s6G X-Gm-Gg: AY/fxX6kw/GjvG7a93foBk4crE0TuW/S02T46KnDHCr7LGwZIP1U/tHQdVYXo4TWRl8 LCvSGArsxj+CZgDZhEGeoDj1HYgxv+ddqnOPAU6H/SqyRbMnXodgfy/JwYyQUfMIihieAflKJxm 5hLxoGAPzVNigf+3p2W9BCcEeHn+YWrJWwMvXq9XK3I5xeaj2TjVDOGalmrVGgM1LTT5yTE4I7N ybn/nqWALmjIYolTAIJdsEzle11pZKvQoYj5bpoGoT/EYGL+84gVKtSOvEnI/yyDUvC3B6YTmSO nadPAknHR5ik6Xj2B5dklMuSofhxngz89ctt1lHTRFGu1RC8L8MfH0Q68lptWtUW6aHrELytHhg 994nnJ1qdZAfXTkenEZEzTd14z5+YLdCiowWoTSSoE8zaEwTb+WiBvrkTpcEaR5N8b7ZGQLCcYG 6lbQ3fFZLqiKakb7hdnZABSoHtOzMmM3kPF2RnWA== X-Google-Smtp-Source: AGHT+IGPYSkTJQTXRdeZJNO0Ptp1UF4C4ZvN+4Y+pwY9mfVj1KcuNobxA+hhEKXT47wj8D4Ny+QBYg== X-Received: by 2002:a05:690e:1483:b0:644:60d9:8654 with SMTP id 956f58d0204a3-64716c69eccmr1598952d50.87.1767778157608; Wed, 07 Jan 2026 01:29:17 -0800 (PST) Received: from [192.168.2.226] (104.194.78.75.16clouds.com. [104.194.78.75]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6470d80be64sm1865006d50.6.2026.01.07.01.28.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 01:29:16 -0800 (PST) Message-ID: <080e493a-e4f1-4c97-a3e1-f76f126b5213@gmail.com> Date: Wed, 7 Jan 2026 17:28:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/pgtable: convert pgtable_t to ptdesc pointer To: Mike Rapoport , alexs@kernel.org Cc: Richard Henderson , Matt Turner , Magnus Lindholm , Vineet Gupta , Russell King , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andy Lutomirski , Chris Zankel , Max Filippov , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , "open list:ALPHA PORT" , open list , "open list:SYNOPSYS ARC ARCHITECTURE" , "moderated list:ARM PORT" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:C-SKY ARCHITECTURE" , "open list:QUALCOMM HEXAGON ARCHITECTURE" , "open list:LOONGARCH" , "open list:M68K ARCHITECTURE" , "open list:MIPS" , "open list:OPENRISC ARCHITECTURE" , "open list:PARISC ARCHITECTURE" , "open list:RISC-V ARCHITECTURE" , "open list:SUPERH" , "open list:USER-MODE LINUX (UML)" References: <20260107064642.15771-1-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/1/7 17:05, Mike Rapoport wrote: > On Wed, Jan 07, 2026 at 02:46:35PM +0800,alexs@kernel.org wrote: >> From: Alex Shi >> >> After struct ptdesc introduced, pgtable_t should used it instead of old >> struct page pointer. The only thing in the way for this change is just >> pgtable->lru in pgtable_trans_huge_deposit/withdraw. >> >> Let's convert them into ptdesc and use struct ptdesc* as pgtable_t. >> Thanks testing support from kernel test robot >> >> Signed-off-by: Alex Shi >> --- > ... > >> diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/pgalloc.h >> index a17f01235c29..1a3484c2df4c 100644 >> --- a/arch/arm/include/asm/pgalloc.h >> +++ b/arch/arm/include/asm/pgalloc.h >> @@ -96,12 +96,12 @@ pte_alloc_one(struct mm_struct *mm) >> { >> struct page *pte; >> >> - pte = __pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM); >> + pte = ptdesc_page(__pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM)); > When ptdesc will be separated from struct page, ptdesc_page() would fail if the > allocation failed. This line should be split into something like > > struct ptdesc *ptdesc = __pte_alloc_one(...); > if (!ptesc) > return NULL; > pte = ptdesc_page(ptdesc); > > Right, I will fix this. and sent the 2nd version. Thanks a lot! >> if (!pte) >> return NULL; >> if (!PageHighMem(pte)) >> clean_pte_table(page_address(pte)); >> - return pte; >> + return page_ptdesc(pte); >> } >> >> static inline void __pmd_populate(pmd_t *pmdp, phys_addr_t pte, > -- Sincerely yours, Mike. >