From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751785AbdEBJZN (ORCPT ); Tue, 2 May 2017 05:25:13 -0400 Received: from mout.web.de ([217.72.192.78]:64642 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbdEBJZK (ORCPT ); Tue, 2 May 2017 05:25:10 -0400 Subject: [PATCH 5/9] pinctrl: Adjust five checks for null pointers From: SF Markus Elfring To: linux-gpio@vger.kernel.org, Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <080f6ec0-7796-d802-7b64-8ea9b5488a7a@users.sourceforge.net> Date: Tue, 2 May 2017 11:25:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:68osmP23830Bul7axserQYIeNeKA97vAKaAxOdqFfbP8PbWOcM4 4Uuhf5ujnDWswk1UcUyPGLvyf9+4sXxrdokYGOI95mnvN3IHtvQUXCehcmu0DfW+7NeFcv9 0ENxbVGR+3/8F3UFauRG20/7fcHFf7ZmTh1bfQ3zKc52e7jCpUB3nAJjC0dbR94X0bCkD5o iUhnxOwavgUwJt+vwdhMA== X-UI-Out-Filterresults: notjunk:1;V01:K0:947bsfk6VZ0=:WYWUQMjx3IEDce83ElX5jn f6iAifsv5FODsFPShn7179J7nNImpyqoYCdnzpmjjQgh9AFu0ojBaKd16Ul1crOTeR69aYRp1 bJ1s7X5nLvDBaT+0A2MX3BT+OxYmPv4w/i7apFbaUE8umiOYWgv9tL9DbyRzhCFx9nUpJzG0j 5gm8JUbyffjHhh8sgDFSEFnTTv6zjUYo0Sx4zqAFNOxRpwhCj+qRzImTI/QYugLIIu0ZHd6Fd qXr9Gn6G+j1x5tWgPngEys6kLJgofq19hBR17ogNnhoMZZmtxjU3aH4FbPMe8A3oz4xU/5i47 abSRB1NYuzRhzA2S2ghu52XrQutGcHBmEfOO5KJcUwz596YoGfGTDZW4wqiY7fkx9bt4r9mZh brv7frQcCSHVA1Yi1y8yui2a9dvjgj1Gm5m0RBI7qjug1dWb7VXoa/pQrDNGDaY2+/MHrOltT YTFg1eAM67XKNJcTXF8Kzm5FxsB98fLd0A1OV4az4dHNk0KGUbkVnJMDJhUf9WMMb/kv7ZKsk t1Zbsi4Bd78tk1B24lWgxSYG9EG6S3LcUryFO4i9BwgIdCgNFyQuYEnfPrXxyzc8lVQ695iHV ko/IyBfRElRetjG8TO9I2bZtjkMk5q8d8WwUgQ2RhMcv/rE1YnMT7/dle6PpFuA/PsKzTJ6kR DFJJikqj4arXJ0kRA1edFc83FbD7Bj4gcQ5gzShFKskxYZCLyaEawKDXDU9o1YL6ACrgXopfY KaQ9uJ43gsOiHe7bvF5diDy2ednXSHVoxa0RkSVxnlCW5fKzksF6pq4z6NnRuNJql/LwxNYQu GX5J6hY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 2 May 2017 10:01:57 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinconf.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c index dfa782e19f37..f2168b6e3418 100644 --- a/drivers/pinctrl/pinconf.c +++ b/drivers/pinctrl/pinconf.c @@ -319,7 +319,7 @@ static int pinconf_pins_show(struct seq_file *s, void *what) pin = pctldev->desc->pins[i].number; desc = pin_desc_get(pctldev, pin); /* Skip if we cannot search the pin */ - if (desc == NULL) + if (!desc) continue; seq_printf(s, "pin %d (%s): ", pin, desc->name); @@ -528,7 +528,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file, /* get arg 'device_name' */ token = strsep(&b, " "); - if (token == NULL) + if (!token) return -EINVAL; if (strlen(token) >= MAX_NAME_LEN) return -EINVAL; @@ -536,7 +536,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file, /* get arg 'state_name' */ token = strsep(&b, " "); - if (token == NULL) + if (!token) return -EINVAL; if (strlen(token) >= MAX_NAME_LEN) return -EINVAL; @@ -544,7 +544,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file, /* get arg 'pin_name' */ token = strsep(&b, " "); - if (token == NULL) + if (!token) return -EINVAL; if (strlen(token) >= MAX_NAME_LEN) return -EINVAL; @@ -552,7 +552,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file, /* get new_value of config' */ token = strsep(&b, " "); - if (token == NULL) + if (!token) return -EINVAL; if (strlen(token) >= MAX_NAME_LEN) return -EINVAL; -- 2.12.2