From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Colin King <colin.king@canonical.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Hans de Goede <hdegoede@redhat.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size
Date: Thu, 24 Jan 2019 11:27:13 -0600 [thread overview]
Message-ID: <08226544-958f-cf49-2a39-2a281f792954@linux.intel.com> (raw)
In-Reply-To: <20190124170621.7583-1-colin.king@canonical.com>
> diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
> index fa9c4cf97686..1364e4e601d8 100644
> --- a/sound/soc/intel/boards/bytcht_es8316.c
> +++ b/sound/soc/intel/boards/bytcht_es8316.c
> @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping byt_cht_es8316_gpios[] = {
>
> static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
> {
> - const char * const mic_name[] = { "in1", "in2" };
> + static const char * const mic_name[] = { "in1", "in2" };
> struct byt_cht_es8316_private *priv;
> struct device *dev = &pdev->dev;
> struct snd_soc_acpi_mach *mach;
We have the same code pattern in two other files, so if we care about
this we should fix it across the board(s), no?
bytcht_es8316.c: const char * const mic_name[] = { "in1", "in2" };
bytcr_rt5640.c: const char * const map_name[] = { "dmic1", "dmic2",
"in1", "in3" };
bytcr_rt5651.c: const char * const mic_name[] = { "dmic", "in1",
"in2", "in12" };
next prev parent reply other threads:[~2019-01-24 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 17:06 [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size Colin King
2019-01-24 17:27 ` Pierre-Louis Bossart [this message]
2019-01-24 17:29 ` [alsa-devel] " Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08226544-958f-cf49-2a39-2a281f792954@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox