From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4FECC4360F for ; Fri, 5 Apr 2019 14:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AD5E21726 for ; Fri, 5 Apr 2019 14:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731171AbfDEOt1 (ORCPT ); Fri, 5 Apr 2019 10:49:27 -0400 Received: from mga14.intel.com ([192.55.52.115]:24579 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbfDEOt0 (ORCPT ); Fri, 5 Apr 2019 10:49:26 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 07:49:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,313,1549958400"; d="scan'208";a="220893956" Received: from rbhardw1-mobl.gar.corp.intel.com (HELO [10.252.72.21]) ([10.252.72.21]) by orsmga001.jf.intel.com with ESMTP; 05 Apr 2019 07:49:22 -0700 Subject: Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static To: Andy Shevchenko Cc: Guenter Roeck , Rajneesh Bhardwaj , Vishwanath Somayaji , Darren Hart , Andy Shevchenko , Platform Driver , Linux Kernel Mailing List References: <1553632152-18888-1-git-send-email-linux@roeck-us.net> <4554bd3e-fabb-44aa-fc82-52ec9cbf9b2c@linux.intel.com> From: "Bhardwaj, Rajneesh" Message-ID: <0822b960-be6e-6fcd-fed5-1825d2818b80@linux.intel.com> Date: Fri, 5 Apr 2019 20:19:21 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sending again as i got delivery failure notification from the mailing list for some reason. On 05-Apr-19 8:15 PM, Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 2:47 PM Bhardwaj, Rajneesh > wrote: >> >> On 27-Mar-19 1:59 AM, Guenter Roeck wrote: >>> 0day reports: >>> >>> drivers/platform/x86/intel_pmc_core.c:833:5: sparse: >>> symbol 'quirk_xtal_ignore' was not declared. Should it be static? >> Looks good to me. > Please, give a corresponding tag. > Meanwhile I will apply it to my review and testing queue for robots to > play with, thanks! Sure. Acked-by: Rajneesh Bhardwaj >>> Mark the function static since it is indeed only called locally. >>> >>> Cc: Rajneesh Bhardwaj >>> Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown") >>> Signed-off-by: Guenter Roeck >>> --- >>> drivers/platform/x86/intel_pmc_core.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c >>> index f2c621b55f49..9908d233305e 100644 >>> --- a/drivers/platform/x86/intel_pmc_core.c >>> +++ b/drivers/platform/x86/intel_pmc_core.c >>> @@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = { >>> * the platform BIOS enforces 24Mhx Crystal to shutdown >>> * before PMC can assert SLP_S0#. >>> */ >>> -int quirk_xtal_ignore(const struct dmi_system_id *id) >>> +static int quirk_xtal_ignore(const struct dmi_system_id *id) >>> { >>> struct pmc_dev *pmcdev = &pmc; >>> u32 value; > >