From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 095C047B435 for ; Thu, 30 Apr 2026 18:20:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777573239; cv=none; b=Y0ywZlUIGqNYSY3kWjJeVpePwAN0J27pbL0wFIPO+Er8VOUETj9YIb/JA1O/tsqaJaiFCsXjFB2acqZnownpXfhOa6VdFtXofOCHTHLghzIVvRCPv8qvH2Yl8ef+bTIvUAhSvkTer/m28zBTJxsio+nZ03lrUNkwCWMeVyiHOwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777573239; c=relaxed/simple; bh=tCw+g7/7gagsLPju3PCwMZhvzQy38+5YtWX9iaZdW2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aM83yW3G22IE0ZZTE0d6JSfI6OY5cgL5UkT2m9RPYXTzi5RU2V2W0O5I3DT+jcXnDYcP8NCgQs+iNKzUOmb2csdky8iDKwJq77aHwSiY+BXek2ODzJASZJBkH/2acxTv/pSK8fs2bhDgNHcpkYswcF8hnVwfXwgb4ExnPyUwD2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AposASQX; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AposASQX" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-83177129e28so596399b3a.1 for ; Thu, 30 Apr 2026 11:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777573237; x=1778178037; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=klUdmlVlpNVXegQCoO7cd9DXbhq3zKfW/7g8zOSk7s0=; b=AposASQXhasbW4RnAqaUf5272lIrXoO1do32DcX92I3jHT8jBuxANAGJfqZv2/Ftn5 ssryFyxhReByinqmU5rabUvbXia43VJevIh3EbUBvmfkhHY5l3k9m6zX49FGFsJEr6OU x7CggiQLrEiTmjQJ3Y7KNvB1u7FIAYKoAXPqo5tjY9XvBTL3o3eXzu4rvv70GN+asNVW LAWyABwcg+oUEC6OWshsDMwJvFuS5/MB3huSZJCMJq1tWZDgUyWfM/ozIiQNEksdPOm/ /o+SAeAKHfAW00oj+qId+byc2m/TQZ8tKV91r/qDC+7xUD/6I0fEYuAFcKpmhnp4UOAL m7PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777573237; x=1778178037; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=klUdmlVlpNVXegQCoO7cd9DXbhq3zKfW/7g8zOSk7s0=; b=cJHbxulMa7U+4X0b5DGlfD7yzLqPGXWWmSeVF69L8sDAiPLQJB4H3jxQ+7JOf87rSx pKsvuC9YxwHjXjjwefR4B91wr1gc8DmtUMnO6Iuxo4zYI0c4TGRA44qSgHV3yWZ6bO0s jDyw9K9aXilOZ6cM9BTn6CoudxqcnXMnSs1VB1MVtfPZ037vllTpQT3vsRf4ODj+OG8s AtewfYB0A9O+OZI+xZcVoH8/MEY1M+gpxyRBXo3ff+blGQ8rGp4UsiioLMg0VBgdtAWc kjvyOQ6YFylMG7E0ZwVwoH1z0MtbALFpi1n+s0YqHH83TOz74TGO2taetZCMXvm3vPVY fQvQ== X-Forwarded-Encrypted: i=1; AFNElJ8PU751Rl5VC2ptkIf3FOTPQmBlNlw0rYqfgKPJQcvzwAPVy9mvHTjndmaUjQwMzycCzGti+JP6gwFY308=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+50i7sy2JUYQxIt8P3KetuM+CyEwX3MgJXwSqmC4aUubgKR6o oDr+Pcs1OHp+4LQZObLSVvM64A0OLZf9mXCxGCsCVX7tVzHSNtXDXG8W X-Gm-Gg: AeBDietamIwtLG0NOQ2/uWMVdN+T2slv1SuSkcXDRM6EPc8ZoT5scn6sQGzG0acgSc9 W3yvTyOidzIR4gQmjKdBMxNUirexz2YDkw+rMMXLCZAPsN2ldvwXmFVjASbqT1gorO0v1ra1i7N SwlSgQ3kYgRIyDjeSfJbnzmUHWcKXi1bGHw562kFatMHlChan8K1DZr1cgazZd7UWAharyXsfLj U4eZd2oNelGi1fT1j2IwrXv0uXB9kqndkycyofb9XlvnCHqnOXbO2hp5ktAxhY6ros9A3hav9ZH v3eunqd6MkPMiKvw0lXNhwN3MioeRLsw+tsyjAqUjhULqHkVHwlH35lz16b/woJKDeB2ZnBQFih YcDWqmJK/ItTvkDwyRu2qQA/JH7Qj+Hw28tAVT8s0P6bpxG4kTV0u/x45t8CDBtmFb1Sa3bB8In n5zUS+ooOcQsfkWFcX716JEbk5IyyTy42++P4Fw37mCqS6PuZy09LbUGTTMg== X-Received: by 2002:a05:6a00:174b:b0:82d:6310:2efc with SMTP id d2e1a72fcca58-834fdb874e8mr4549707b3a.17.1777573237278; Thu, 30 Apr 2026 11:20:37 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8351582e185sm330380b3a.3.2026.04.30.11.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 11:20:36 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 30 Apr 2026 11:20:36 -0700 From: Guenter Roeck To: Myeonghun Pak Cc: Wilken Gottwalt , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] hwmon: (corsair-psu) Close HID device on probe errors Message-ID: <083849bd-9229-4ade-b60e-08cbc4ff1cd4@roeck-us.net> References: <20260424135107.13720-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260424135107.13720-1-mhun512@gmail.com> On Fri, Apr 24, 2026 at 10:50:51PM +0900, Myeonghun Pak wrote: > corsairpsu_probe() opens the HID device before sending the device init > and firmware-info commands. If either command fails, the error path jumps > directly to fail_and_stop and skips hid_hw_close(). > > Use the existing fail_and_close label for those post-open failures so the > open count and low-level close callback are balanced before hid_hw_stop(). > > Fixes: d115b51e0e56 ("hwmon: add Corsair PSU HID controller driver") > Cc: stable@vger.kernel.org > Signed-off-by: Myeonghun Pak > Reviewed-by: Wilken Gottwalt Applied. Thanks, Guenter